summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSzabolcs David <davidsz@inf.u-szeged.hu>2023-07-29 16:22:30 +0200
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2023-08-02 15:10:45 +0000
commitb6db0dfb6a4eb0ebed0b7594e7e3b8bf6a85c567 (patch)
treecf65824fa4915f78c8a109fd00890207a97bc2e5
parent3fd36a5722579814d57a55c780010635eef11b4c (diff)
Apply WebEngineSettings to guest views
Animated scrolling is always enabled in the PDF viewer and can't be disabled by the settings of the embedding web view. The guest view is still not present at the time when we normally apply settings to the main WebContents, it is only possible after it was properly attached. Change-Id: I6b2c99f67ad90bf028b7299280a9a8b0f31e9f65 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 6b46b4503d3672852b4bf590dd276ff4003b26c8) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r--src/core/web_contents_delegate_qt.cpp9
-rw-r--r--src/core/web_contents_delegate_qt.h3
2 files changed, 12 insertions, 0 deletions
diff --git a/src/core/web_contents_delegate_qt.cpp b/src/core/web_contents_delegate_qt.cpp
index f96b68b34..ab41483a9 100644
--- a/src/core/web_contents_delegate_qt.cpp
+++ b/src/core/web_contents_delegate_qt.cpp
@@ -815,6 +815,15 @@ void WebContentsDelegateQt::ResourceLoadComplete(content::RenderFrameHost* rende
}
}
+void WebContentsDelegateQt::InnerWebContentsAttached(content::WebContents *inner_web_contents,
+ content::RenderFrameHost *render_frame_host,
+ bool is_full_page)
+{
+ blink::web_pref::WebPreferences guestPrefs = inner_web_contents->GetOrCreateWebPreferences();
+ webEngineSettings()->overrideWebPreferences(inner_web_contents, &guestPrefs);
+ inner_web_contents->SetWebPreferences(guestPrefs);
+}
+
FindTextHelper *WebContentsDelegateQt::findTextHelper()
{
return m_findTextHelper.data();
diff --git a/src/core/web_contents_delegate_qt.h b/src/core/web_contents_delegate_qt.h
index cce1578be..68649eaa8 100644
--- a/src/core/web_contents_delegate_qt.h
+++ b/src/core/web_contents_delegate_qt.h
@@ -127,6 +127,9 @@ public:
void ResourceLoadComplete(content::RenderFrameHost* render_frame_host,
const content::GlobalRequestID& request_id,
const blink::mojom::ResourceLoadInfo& resource_load_info) override;
+ void InnerWebContentsAttached(content::WebContents *inner_web_contents,
+ content::RenderFrameHost *render_frame_host,
+ bool is_full_page) override;
void didFailLoad(const QUrl &url, int errorCode, const QString &errorDescription);
void overrideWebPreferences(content::WebContents *, blink::web_pref::WebPreferences*);