summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Negyokru <negyokru@inf.u-szeged.hu>2023-08-10 15:51:57 +0200
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2023-08-21 15:13:22 +0000
commitfd3e73dda91f5e66796d6f30bfaa3ef7c39ae8d3 (patch)
treec690511b71f15ffd08a230cfb7abd497004c1597
parentd326e29a38f812b48268d6e86a058f326808253e (diff)
Fix close button in devtools
Handle CloseWindow call coming from DevtoolsUIBindings. Fixes: QTBUG-115976 Change-Id: If58a96e3901234696c55c9c1402c645ba7a8576b Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu> (cherry picked from commit e4eb2dd213df10fb470279763f1ec64e41f26b56) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
-rw-r--r--src/core/devtools_frontend_qt.cpp5
-rw-r--r--src/core/devtools_frontend_qt.h2
2 files changed, 6 insertions, 1 deletions
diff --git a/src/core/devtools_frontend_qt.cpp b/src/core/devtools_frontend_qt.cpp
index 8c537a6c7..49fc0d3aa 100644
--- a/src/core/devtools_frontend_qt.cpp
+++ b/src/core/devtools_frontend_qt.cpp
@@ -209,4 +209,9 @@ std::string DevToolsFrontendQt::GetId(content::WebContents *inspectedContents)
return content::DevToolsAgentHost::GetOrCreateFor(inspectedContents)->GetId();
}
+void DevToolsFrontendQt::CloseWindow()
+{
+ web_contents()->Close();
+}
+
} // namespace QtWebEngineCore
diff --git a/src/core/devtools_frontend_qt.h b/src/core/devtools_frontend_qt.h
index a22bb0559..ec7ccce83 100644
--- a/src/core/devtools_frontend_qt.h
+++ b/src/core/devtools_frontend_qt.h
@@ -61,7 +61,7 @@ private:
void OnLoadCompleted() override;
void InspectElementCompleted() override{};
- void CloseWindow() override{};
+ void CloseWindow() override;
void Inspect(scoped_refptr<content::DevToolsAgentHost>) override{};
void SetInspectedPageBounds(const gfx::Rect &) override{};
void SetIsDocked(bool) override{};