diff options
| author | Kaloyan Chehlarski <kaloyan.chehlarski@qt.io> | 2024-01-16 13:29:33 +0100 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2024-02-01 17:52:09 +0000 |
| commit | f153e8e695c267137130752bfde722a7e9467910 (patch) | |
| tree | 003fed26dbe9e8b1e49f271e2c4839614caabcb9 | |
| parent | 2687c4b7c12e5cf6654c5ef7bac9afdbd2eac741 (diff) | |
Expand helper process stack to 8MB on Windows
Chromium on Windows is built with a linker flag that ensures an
initial stack size of 8MB, whereas a QtWebEngine build never sets one.
The result is that on Windows the helper process only gets the default
1MB stack, which can cause stack overflows in pages with nested
elements (see issue QTBUG-120420). This change makes sure the relevant
linker flag is added when a Windows build is detected, and the stack
size matches the one in Chromium.
Pick-to: 6.6
Task-number: QTBUG-120420
Change-Id: I42ff397f1b90c4455188b5711d5b3e9c1780db23
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit e604b302882d4ca4e8b6d311df31d4e958c9073c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | src/process/CMakeLists.txt | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/process/CMakeLists.txt b/src/process/CMakeLists.txt index bbe47431f..630ba42a8 100644 --- a/src/process/CMakeLists.txt +++ b/src/process/CMakeLists.txt @@ -25,7 +25,7 @@ if(WIN32) set_property(TARGET ${qtWebEngineProcessName} PROPERTY WIN32_EXECUTABLE TRUE) # get libs rsp file, since cmake is not aware of PUBLIC libs for WebEngineCore get_target_property(libs_rsp WebEngineCore LIBS_RSP) - target_link_options(${qtWebEngineProcessName} PRIVATE "@${libs_rsp}") + target_link_options(${qtWebEngineProcessName} PRIVATE "@${libs_rsp}" "/STACK:0x800000") endif() if(MACOS) |