diff options
| author | Shawn Rutledge <shawn.rutledge@qt.io> | 2020-04-21 19:01:43 +0200 |
|---|---|---|
| committer | Shawn Rutledge <shawn.rutledge@qt.io> | 2020-04-22 16:43:45 +0200 |
| commit | ab179f60844f5b0cd6ef863b753566a3588e9d5d (patch) | |
| tree | 86da2d199ab24099ba30bea6f45c61f039eaff7e | |
| parent | 9e56f570e31a0ef18e544bb21dfddebfe43ec2d0 (diff) | |
Fix warning about unexpected null disconnect in QPdfLinkModel
QObject::disconnect: Unexpected nullptr parameter
was caused by disconnecting from the previous document's statusChanged
signal even when there was no previous document.
Change-Id: I740f0e569f445660494011d788c0e917e787ac80
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
| -rw-r--r-- | src/pdf/qpdflinkmodel.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/pdf/qpdflinkmodel.cpp b/src/pdf/qpdflinkmodel.cpp index 4020f036e..900d3cd9e 100644 --- a/src/pdf/qpdflinkmodel.cpp +++ b/src/pdf/qpdflinkmodel.cpp @@ -104,7 +104,8 @@ void QPdfLinkModel::setDocument(QPdfDocument *document) Q_D(QPdfLinkModel); if (d->document == document) return; - disconnect(d->document, &QPdfDocument::statusChanged, this, &QPdfLinkModel::onStatusChanged); + if (d->document) + disconnect(d->document, &QPdfDocument::statusChanged, this, &QPdfLinkModel::onStatusChanged); connect(document, &QPdfDocument::statusChanged, this, &QPdfLinkModel::onStatusChanged); d->document = document; emit documentChanged(); |