diff options
| author | Andras Becsi <andras.becsi@digia.com> | 2013-07-02 17:38:21 +0200 |
|---|---|---|
| committer | Andras Becsi <andras.becsi@digia.com> | 2013-07-03 11:34:17 +0200 |
| commit | 312a133bc8874cfcf68a04c00c76a2f792d42cf3 (patch) | |
| tree | 08d8e7120bf109c681a4d2b3afc8b0fd2046ffed | |
| parent | 5f70d82ba035f4acd8cc38e57de429171694019d (diff) | |
Get rid of some more QT_NOT_YET_IMPLEMENTED
Change-Id: I4fb120592eccfd1e75db32c76ddcbdad77762106
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
| -rw-r--r-- | lib/render_widget_host_view_qt.cpp | 17 | ||||
| -rw-r--r-- | lib/render_widget_host_view_qt.h | 1 | ||||
| -rw-r--r-- | lib/web_contents_view_qt.h | 6 |
3 files changed, 8 insertions, 16 deletions
diff --git a/lib/render_widget_host_view_qt.cpp b/lib/render_widget_host_view_qt.cpp index aa644a27f..f6f15e0ac 100644 --- a/lib/render_widget_host_view_qt.cpp +++ b/lib/render_widget_host_view_qt.cpp @@ -234,19 +234,12 @@ void RenderWidgetHostViewQt::SetBackground(const SkBitmap& background) // Return value indicates whether the mouse is locked successfully or not. bool RenderWidgetHostViewQt::LockMouse() { - QT_NOT_YET_IMPLEMENTED + QT_NOT_USED return false; } void RenderWidgetHostViewQt::UnlockMouse() { - QT_NOT_YET_IMPLEMENTED -} - -// Returns true if the mouse pointer is currently locked. -bool RenderWidgetHostViewQt::IsMouseLocked() -{ - QT_NOT_YET_IMPLEMENTED - return false; + QT_NOT_USED } // FIXME: remove TOOLKIT_GTK related things. @@ -295,8 +288,7 @@ void RenderWidgetHostViewQt::UpdateCursor(const WebCursor&) void RenderWidgetHostViewQt::SetIsLoading(bool) { - QT_NOT_YET_IMPLEMENTED - // Give visual feedback for loading process. + // We use WebContentsDelegateQt::LoadingStateChanged to notify about loading state. } void RenderWidgetHostViewQt::TextInputTypeChanged(ui::TextInputType, bool) @@ -439,7 +431,8 @@ void RenderWidgetHostViewQt::SetScrollOffsetPinning(bool, bool) { } void RenderWidgetHostViewQt::OnAccessibilityNotifications(const std::vector<AccessibilityHostMsg_NotificationParams>&) { - QT_NOT_YET_IMPLEMENTED + // We are not using accessibility features at this point. + QT_NOT_USED } void RenderWidgetHostViewQt::Paint(const gfx::Rect& damage_rect) diff --git a/lib/render_widget_host_view_qt.h b/lib/render_widget_host_view_qt.h index 1cccd2458..4b1a3c66e 100644 --- a/lib/render_widget_host_view_qt.h +++ b/lib/render_widget_host_view_qt.h @@ -94,7 +94,6 @@ public: virtual void SetBackground(const SkBitmap& background); virtual bool LockMouse(); virtual void UnlockMouse(); - virtual bool IsMouseLocked(); #if defined(TOOLKIT_GTK) virtual GdkEventButton* GetLastMouseDown(); virtual gfx::NativeView BuildInputMethodsGtkMenu(); diff --git a/lib/web_contents_view_qt.h b/lib/web_contents_view_qt.h index d12b9df75..456329201 100644 --- a/lib/web_contents_view_qt.h +++ b/lib/web_contents_view_qt.h @@ -87,11 +87,11 @@ public: virtual void SetOverscrollControllerEnabled(bool enabled) { QT_NOT_YET_IMPLEMENTED } - virtual gfx::NativeView GetNativeView() const { QT_NOT_YET_IMPLEMENTED return 0; } + virtual gfx::NativeView GetNativeView() const { QT_NOT_USED return 0; } - virtual gfx::NativeView GetContentNativeView() const { QT_NOT_YET_IMPLEMENTED return 0; } + virtual gfx::NativeView GetContentNativeView() const { QT_NOT_USED return 0; } - virtual gfx::NativeWindow GetTopLevelNativeWindow() const { QT_NOT_YET_IMPLEMENTED return 0; } + virtual gfx::NativeWindow GetTopLevelNativeWindow() const { QT_NOT_USED return 0; } virtual void GetContainerBounds(gfx::Rect* out) const; |