diff options
author | Michal Klocek <michal.klocek@qt.io> | 2022-04-20 09:10:05 +0200 |
---|---|---|
committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2022-06-11 08:33:19 +0200 |
commit | 422ec96c34afd5fd8cace53570303862389d16f6 (patch) | |
tree | ac146e6f51e788a5fe57b5396790ccfc6daf6774 | |
parent | 5dccfdf57b927b6d32184f8bd2a484f36d1426ad (diff) |
Fix printing/no-printing builds
If no 'printing' we should also disable 'cups' otherwise
it asserts in gn. Moreover we use cups on macos and linux only.
Change-Id: Id0c9b34746204e985032d7c42868aeb8567b8e8f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 3f5b5213d42376470274f0e3aaa51731f0d2552a)
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
-rw-r--r-- | src/core/CMakeLists.txt | 4 | ||||
-rw-r--r-- | src/core/api/configure.cmake | 3 |
2 files changed, 6 insertions, 1 deletions
diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt index e200cb12d..18078ba5a 100644 --- a/src/core/CMakeLists.txt +++ b/src/core/CMakeLists.txt @@ -308,6 +308,10 @@ foreach(arch ${archs}) CONDITION QT_FEATURE_webengine_printing_and_pdf ) extend_gn_list(gnArgArg + ARGS use_cups + CONDITION QT_FEATURE_webengine_printing_and_pdf AND NOT WIN32 + ) + extend_gn_list(gnArgArg ARGS enable_plugins CONDITION QT_FEATURE_webengine_pepper_plugins ) diff --git a/src/core/api/configure.cmake b/src/core/api/configure.cmake index 4b1a8e48a..09f674435 100644 --- a/src/core/api/configure.cmake +++ b/src/core/api/configure.cmake @@ -76,7 +76,8 @@ qt_feature("webengine-printing-and-pdf" PRIVATE LABEL "Printing and PDF" PURPOSE "Provides printing and output to PDF." AUTODETECT NOT QT_FEATURE_webengine_embedded_build - CONDITION TARGET Qt::PrintSupport AND QT_FEATURE_printer AND (CUPS_FOUND OR NOT LINUX) + CONDITION TARGET Qt::PrintSupport AND QT_FEATURE_printer AND + (CUPS_FOUND OR WIN32) ) qt_feature("webengine-pepper-plugins" PRIVATE LABEL "Pepper Plugins" |