diff options
| author | Jocelyn Turcotte <jocelyn.turcotte@digia.com> | 2014-08-13 16:52:51 +0200 |
|---|---|---|
| committer | Jocelyn Turcotte <jocelyn.turcotte@digia.com> | 2014-08-15 11:14:28 +0200 |
| commit | bf4064cda667ca64b323223d3adada43f5c8413e (patch) | |
| tree | d2c6af22dfb1bf64b91db8e4e1b2e99463064adb /examples/webenginewidgets/browser | |
| parent | 423b399a3336ed5832ac12fe0bb9c4c3eebc1c82 (diff) | |
Handle new window/tab modifiers also on normal navigations
AddNewContents is only called when window.open is called from JavaScript.
We also want the shift/ctrl modifiers to trigger normal links to open
in the requested disposition. In this case OpenURLFromTab will pass
the detected disposition and we must create a new WebContents
ourselves.
Use the same code path going through
WebContentsAdapterClient::adoptNewWindow except that we pass a null
WebContents pointer to the WebContentsAdapter constructor and let it
create its own when initialized.
Change-Id: I817b0e72aec12723bf92d9b7ad85c1cecbf5e408
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Diffstat (limited to 'examples/webenginewidgets/browser')
| -rw-r--r-- | examples/webenginewidgets/browser/webview.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/examples/webenginewidgets/browser/webview.cpp b/examples/webenginewidgets/browser/webview.cpp index d4dd2649c..e32ab71d6 100644 --- a/examples/webenginewidgets/browser/webview.cpp +++ b/examples/webenginewidgets/browser/webview.cpp @@ -177,8 +177,6 @@ private: QWebEnginePage *WebPage::createWindow(QWebEnginePage::WebWindowType type) { - if (m_keyboardModifiers & Qt::ControlModifier || m_pressedButtons == Qt::MidButton) - m_openInNewTab = true; if (m_openInNewTab || type == QWebEnginePage::WebBrowserTab) { m_openInNewTab = false; return mainWindow()->tabWidget()->newTab()->page(); |