diff options
author | Michal Klocek <michal.klocek@theqtcompany.com> | 2016-04-11 19:23:18 +0200 |
---|---|---|
committer | Michal Klocek <michal.klocek@theqtcompany.com> | 2016-04-21 15:18:17 +0000 |
commit | 4ff390203caf278dcee20e1a61402431fd2166c2 (patch) | |
tree | 6924ac8439826b1718fe52f51ef1b2da217b0b14 /examples/webenginewidgets/simplebrowser | |
parent | 334b9ba69e1e662b04a1eea24bcd205f76962307 (diff) |
Fix contextMenu handling in examples
Adds missing deleteLater on close
Change-Id: Id337856f138e0d38f0c72d3962ccac309d36c73e
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Diffstat (limited to 'examples/webenginewidgets/simplebrowser')
-rw-r--r-- | examples/webenginewidgets/simplebrowser/webview.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/examples/webenginewidgets/simplebrowser/webview.cpp b/examples/webenginewidgets/simplebrowser/webview.cpp index 1fabcc69f..de93bc0c4 100644 --- a/examples/webenginewidgets/simplebrowser/webview.cpp +++ b/examples/webenginewidgets/simplebrowser/webview.cpp @@ -154,9 +154,11 @@ void WebView::contextMenuEvent(QContextMenuEvent *event) if (it != actions.cend()) { (*it)->setText(tr("Open Link in This Tab")); ++it; - menu->insertAction(*it, page()->action(QWebEnginePage::OpenLinkInNewWindow)); - menu->insertAction(*it, page()->action(QWebEnginePage::OpenLinkInNewTab)); + QAction *before(it == actions.cend() ? nullptr : *it); + menu->insertAction(before, page()->action(QWebEnginePage::OpenLinkInNewWindow)); + menu->insertAction(before, page()->action(QWebEnginePage::OpenLinkInNewTab)); } + connect(menu, &QMenu::aboutToHide, menu, &QObject::deleteLater); menu->popup(event->globalPos()); } |