diff options
| author | Arvid Nilsson <anilsson@blackberry.com> | 2013-10-03 12:33:54 +0200 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-10-03 14:52:36 +0200 |
| commit | ef6cb53a1d49de616067126c8f49d2406c9a7f43 (patch) | |
| tree | b515263fb14a8ddaa8e54a4652446dd47a9ba071 /lib/widgets | |
| parent | 8c1de0f07a4b83ad50278231a8866143cf01333c (diff) | |
Quick: Add Favicon API
Adds a favicon API modelled after the WebKit2 QQuickWebView API, but
using an http(s) URL instead of a custom protocol, because there's no
icondatabase yet.
The icon URL lingers even when a new load is committed, until the load
finishes. It might be more prudent to clear the icon when committing a
new load, but I opted to let the app take care of that detail if
desired. Many browsers show a spinner instead of the favicon while
loading, for example.
There's no widget API implementation for favicons yet, because that API
only makes sense if we have a full-fledged icon database (case in
point: QWebEngineSettings::iconForUrl()).
Change-Id: I1e7b85104c80de2ae46a5fe9a273104d43a5c71f
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Diffstat (limited to 'lib/widgets')
| -rw-r--r-- | lib/widgets/Api/qwebenginepage.cpp | 5 | ||||
| -rw-r--r-- | lib/widgets/Api/qwebenginepage_p.h | 1 |
2 files changed, 6 insertions, 0 deletions
diff --git a/lib/widgets/Api/qwebenginepage.cpp b/lib/widgets/Api/qwebenginepage.cpp index ee0238368..ab3b1e675 100644 --- a/lib/widgets/Api/qwebenginepage.cpp +++ b/lib/widgets/Api/qwebenginepage.cpp @@ -69,6 +69,11 @@ void QWebEnginePagePrivate::urlChanged(const QUrl &url) Q_EMIT q->urlChanged(url); } +void QWebEnginePagePrivate::iconChanged(const QUrl &url) +{ + Q_UNUSED(url) +} + void QWebEnginePagePrivate::loadingStateChanged() { Q_Q(QWebEnginePage); diff --git a/lib/widgets/Api/qwebenginepage_p.h b/lib/widgets/Api/qwebenginepage_p.h index 22066b5bc..ad1de0047 100644 --- a/lib/widgets/Api/qwebenginepage_p.h +++ b/lib/widgets/Api/qwebenginepage_p.h @@ -67,6 +67,7 @@ public: virtual RenderWidgetHostViewQtDelegate* CreateRenderWidgetHostViewQtDelegate(CompositingMode mode) Q_DECL_OVERRIDE; virtual void titleChanged(const QString&) Q_DECL_OVERRIDE; virtual void urlChanged(const QUrl&) Q_DECL_OVERRIDE; + virtual void iconChanged(const QUrl&) Q_DECL_OVERRIDE; virtual void loadingStateChanged() Q_DECL_OVERRIDE; virtual QRectF viewportRect() const Q_DECL_OVERRIDE; virtual void loadFinished(bool success) Q_DECL_OVERRIDE; |