summaryrefslogtreecommitdiffstats
path: root/mkspecs
diff options
context:
space:
mode:
authorMichal Klocek <michal.klocek@qt.io>2018-01-16 18:44:01 +0100
committerJędrzej Nowacki <jedrzej.nowacki@qt.io>2018-01-31 15:58:47 +0000
commit7644564d754bbee640a091950b77e23586c2d283 (patch)
tree1c4bf0ebeb519d030f5897316dfa30fb86ae721b /mkspecs
parent1661c8179989378d5cb03f9233ce2b72c582d8c1 (diff)
Fix crashes of url load qml tests
Currently we can get QuickWebEngineViewPrivate::loadFinished while still being in RenderFrameHostImpl::OnDidStopLoading, unfortunately if user connects onLoadingChanged signal with new url load request this will end up in DiscardUnusedFrame and delete on RenderFrameHostImpl which is still on the bottom of the stack. Use QTimer::singleShot to return to the event loop before emitting load handling signals. Post all load handling calls with singleShot to avoid out of order load "signals" delivery in some cases. Emitting signals should be done from WebContentsAdapterClient to make sure the destruction of WebConentAdapterClient prevents emitting signals on already deleted adapter. Task-numbmer: QTBUG-65813 Change-Id: I93263876fb14bd959ba951463c8aeb5155f04a4f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'mkspecs')
0 files changed, 0 insertions, 0 deletions