summaryrefslogtreecommitdiffstats
path: root/mkspecs
diff options
context:
space:
mode:
authorJüri Valdmann <juri.valdmann@qt.io>2020-07-21 10:25:26 +0200
committerJüri Valdmann <juri.valdmann@qt.io>2020-07-21 14:46:49 +0200
commitfa3b416ca4993c11bee91e1c52ef4aea8ad4438a (patch)
tree1339b458b9974bba95a3e8d93ed0ec947ac32fcf /mkspecs
parent603a1809481eb4d4ca972f0f64915d29fb99f53b (diff)
Stop re-enabling warnings disabled by Chromium
Adding -Wall after -Wno-x will undo the -Wno-x. Change-Id: I223b40e495d762d2420b519f080792bca8e71bdd Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Diffstat (limited to 'mkspecs')
-rw-r--r--mkspecs/features/gn_generator.prf13
1 files changed, 5 insertions, 8 deletions
diff --git a/mkspecs/features/gn_generator.prf b/mkspecs/features/gn_generator.prf
index a83b59847..bbaed2331 100644
--- a/mkspecs/features/gn_generator.prf
+++ b/mkspecs/features/gn_generator.prf
@@ -109,6 +109,11 @@ CLEAN_QMAKE_RCC = $$clean_path($$QMAKE_RCC)
# CONFIG SETUP
+# Chromium already enables warnings, so enabling them again will just
+# re-enable all the warnings disabled by Chromium.
+QMAKE_CFLAGS -= $$QMAKE_CFLAGS_WARN_ON
+QMAKE_CXXFLAGS -= $$QMAKE_CXXFLAGS_WARN_ON
+
GN_CONTENTS += "config(\"$${TARGET}_config\") {"
!isEmpty(QMAKE_CFLAGS) {
GN_CONTENTS += " cflags = ["
@@ -122,14 +127,6 @@ GN_CONTENTS += "config(\"$${TARGET}_config\") {"
GN_CONTENTS += " ]"
}
-# Stop the barrage of unused variables warnings.
-gcc|clang|clang_cl {
- QMAKE_CXXFLAGS += "-Wno-unused-parameter"
- QMAKE_CXXFLAGS += "-Wno-unused-variable"
-} else:msvc {
- QMAKE_CXXFLAGS += /wd4100 /wd4101
-}
-
# Chromium activates this, but we need it off to be able to compile QFlags
clang_cl {
QMAKE_CXXFLAGS += "-fno-complete-member-pointers"