summaryrefslogtreecommitdiffstats
path: root/src/core/core_module.pro
diff options
context:
space:
mode:
authorThiago Macieira <thiago.macieira@intel.com>2019-05-31 09:56:28 -0700
committerThiago Macieira <thiago.macieira@intel.com>2019-05-31 13:08:10 -0700
commit597359a16a798df3955404200f1fc6833a7425ab (patch)
treec21136eb65046a4e0250a7372c6368174c4ddc58 /src/core/core_module.pro
parent54fa06ccecaceeffdfbafdd516503f8007569cf0 (diff)
Don't allow QtWebEngineCore to request executable stack
The Chromium sources contain assembly code that causes the library to default to executable stack (the linker requires that *all* .o files have a .note.GNU-stack section in order to default to non-executable). So add the -z noexecstack linker flag to change the setting. The other libraries are not affected. Change-Id: I0bf9ebeb5aa34d19be30fffd15a3d3063dea2005 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'src/core/core_module.pro')
-rw-r--r--src/core/core_module.pro2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/core/core_module.pro b/src/core/core_module.pro
index b5c8542f3..9bd56f9de 100644
--- a/src/core/core_module.pro
+++ b/src/core/core_module.pro
@@ -39,6 +39,8 @@ LIBS_PRIVATE += $$NINJA_LIB_DIRS $$NINJA_LIBS
# GN's LFLAGS doesn't always work across all the Linux configurations we support.
# The Windows and macOS ones from GN does provide a few useful flags however
+unix:qtConfig(webengine-noexecstack): \
+ QMAKE_LFLAGS += -Wl,-z,noexecstack
linux {
QMAKE_LFLAGS += -Wl,--gc-sections -Wl,-O1 -Wl,-z,now
# Embedded address sanitizer symbols are undefined and are picked up by the dynamic link loader