Cleanup code and clang build warnings

Fix build noise as reported by clang for issues like api deprecation,
unused variables, sign/unsigned mismatch and other non critical issues.

Change-Id: I4fba25406eea8170e3283c42e908ae86bd512e3a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 02d58a067fb5f0db32c254e783170f9f283aeb9d)
Reviewed-by: Michal Klocek <michal.klocek@qt.io>

4 files changed, 5 insertions, 34 deletions

diff --git a/src/core/net/plugin_response_interceptor_url_loader_throttle.cpp b/src/core/net/plugin_response_interceptor_url_loader_throttle.cpp
index d66e69ef4..0fc518a9b 100644
--- a/src/core/net/plugin_response_interceptor_url_loader_throttle.cpp
+++ b/src/core/net/plugin_response_interceptor_url_loader_throttle.cpp
@@ -68,10 +68,9 @@
 namespace QtWebEngineCore {
 
 PluginResponseInterceptorURLLoaderThrottle::PluginResponseInterceptorURLLoaderThrottle(
-        content::BrowserContext *browser_context,
         network::mojom::RequestDestination request_destination,
         int frame_tree_node_id)
-    : m_browser_context(browser_context), m_request_destination(request_destination), m_frame_tree_node_id(frame_tree_node_id)
+    : m_request_destination(request_destination), m_frame_tree_node_id(frame_tree_node_id)
 {}
 
 void PluginResponseInterceptorURLLoaderThrottle::WillProcessResponse(const GURL &response_url,
diff --git a/src/core/net/plugin_response_interceptor_url_loader_throttle.h b/src/core/net/plugin_response_interceptor_url_loader_throttle.h
index 0e10b2124..d4ff87846 100644
--- a/src/core/net/plugin_response_interceptor_url_loader_throttle.h
+++ b/src/core/net/plugin_response_interceptor_url_loader_throttle.h
@@ -54,8 +54,7 @@ namespace QtWebEngineCore {
 class PluginResponseInterceptorURLLoaderThrottle : public blink::URLLoaderThrottle
 {
 public:
-    PluginResponseInterceptorURLLoaderThrottle(content::BrowserContext *browser_context,
-                                               network::mojom::RequestDestination request_destination,
+    PluginResponseInterceptorURLLoaderThrottle(network::mojom::RequestDestination request_destination,
                                                int frame_tree_node_id);
     ~PluginResponseInterceptorURLLoaderThrottle() override = default;
 
@@ -67,7 +66,6 @@ private:
     // layer chance to initialize its browser side state.
     void ResumeLoad();
 
-    content::BrowserContext *m_browser_context = nullptr;
     const network::mojom::RequestDestination m_request_destination;
     const int m_frame_tree_node_id;
 
diff --git a/src/core/net/proxying_restricted_cookie_manager_qt.cpp b/src/core/net/proxying_restricted_cookie_manager_qt.cpp
index f86c0e997..f66a4c1a7 100644
--- a/src/core/net/proxying_restricted_cookie_manager_qt.cpp
+++ b/src/core/net/proxying_restricted_cookie_manager_qt.cpp
@@ -61,9 +61,6 @@ namespace QtWebEngineCore {
 // static
 void ProxyingRestrictedCookieManagerQt::CreateAndBind(ProfileIODataQt *profileIoData,
                                                       mojo::PendingRemote<network::mojom::RestrictedCookieManager> underlying_rcm,
-                                                      bool is_service_worker,
-                                                      int process_id,
-                                                      int frame_id,
                                                       mojo::PendingReceiver<network::mojom::RestrictedCookieManager> receiver)
 {
     DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
@@ -72,7 +69,6 @@ void ProxyingRestrictedCookieManagerQt::CreateAndBind(ProfileIODataQt *profileIo
                    base::BindOnce(&ProxyingRestrictedCookieManagerQt::CreateAndBindOnIoThread,
                                   profileIoData,
                                   std::move(underlying_rcm),
-                                  is_service_worker, process_id, frame_id,
                                   std::move(receiver)));
 }
 
@@ -80,31 +76,21 @@ void ProxyingRestrictedCookieManagerQt::CreateAndBind(ProfileIODataQt *profileIo
 // static
 void ProxyingRestrictedCookieManagerQt::CreateAndBindOnIoThread(ProfileIODataQt *profileIoData,
                                                                 mojo::PendingRemote<network::mojom::RestrictedCookieManager> underlying_rcm,
-                                                                bool is_service_worker,
-                                                                int process_id,
-                                                                int frame_id,
                                                                 mojo::PendingReceiver<network::mojom::RestrictedCookieManager> receiver)
 {
     DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 
     auto wrapper = base::WrapUnique(new ProxyingRestrictedCookieManagerQt(
                                         profileIoData->getWeakPtrOnIOThread(),
-                                        std::move(underlying_rcm),
-                                        is_service_worker, process_id, frame_id));
+                                        std::move(underlying_rcm)));
     mojo::MakeSelfOwnedReceiver(std::move(wrapper), std::move(receiver));
 }
 
 ProxyingRestrictedCookieManagerQt::ProxyingRestrictedCookieManagerQt(
         base::WeakPtr<ProfileIODataQt> profileIoData,
-        mojo::PendingRemote<network::mojom::RestrictedCookieManager> underlyingRestrictedCookieManager,
-        bool is_service_worker,
-        int32_t process_id,
-        int32_t frame_id)
+        mojo::PendingRemote<network::mojom::RestrictedCookieManager> underlyingRestrictedCookieManager)
         : m_profileIoData(std::move(profileIoData))
         , underlying_restricted_cookie_manager_(std::move(underlyingRestrictedCookieManager))
-        , is_service_worker_(is_service_worker)
-        , process_id_(process_id)
-        , frame_id_(frame_id)
         , weak_factory_(this)
 {
     DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
diff --git a/src/core/net/proxying_restricted_cookie_manager_qt.h b/src/core/net/proxying_restricted_cookie_manager_qt.h
index 3d4765b3b..37271dfd3 100644
--- a/src/core/net/proxying_restricted_cookie_manager_qt.h
+++ b/src/core/net/proxying_restricted_cookie_manager_qt.h
@@ -56,9 +56,6 @@ public:
     // Expects to be called on the UI thread.
     static void CreateAndBind(ProfileIODataQt *profileIoData,
                               mojo::PendingRemote<network::mojom::RestrictedCookieManager> underlying_rcm,
-                              bool is_service_worker,
-                              int process_id,
-                              int frame_id,
                               mojo::PendingReceiver<network::mojom::RestrictedCookieManager> receiver);
 
     ~ProxyingRestrictedCookieManagerQt() override;
@@ -98,24 +95,15 @@ public:
 
 private:
     ProxyingRestrictedCookieManagerQt(base::WeakPtr<ProfileIODataQt> profileIoData,
-                                      mojo::PendingRemote<network::mojom::RestrictedCookieManager> underlying_rcm,
-                                      bool is_service_worker,
-                                      int32_t process_id,
-                                      int32_t frame_id);
+                                      mojo::PendingRemote<network::mojom::RestrictedCookieManager> underlying_rcm);
 
     static void CreateAndBindOnIoThread(ProfileIODataQt *profileIoData,
                                         mojo::PendingRemote<network::mojom::RestrictedCookieManager> underlying_rcm,
-                                        bool is_service_worker,
-                                        int process_id,
-                                        int frame_id,
                                         mojo::PendingReceiver<network::mojom::RestrictedCookieManager> receiver);
 
     base::WeakPtr<ProfileIODataQt> m_profileIoData;
 
     mojo::Remote<network::mojom::RestrictedCookieManager> underlying_restricted_cookie_manager_;
-    bool is_service_worker_;
-    int process_id_;
-    int frame_id_;
 
     base::WeakPtrFactory<ProxyingRestrictedCookieManagerQt> weak_factory_;