diff options
author | Jüri Valdmann <juri.valdmann@qt.io> | 2019-10-22 16:04:13 +0200 |
---|---|---|
committer | Jüri Valdmann <juri.valdmann@qt.io> | 2019-10-30 10:57:14 +0200 |
commit | 418f929e7a067a13456f50b5478dcb64619b57ef (patch) | |
tree | fff790700a58b80273da4a79d490bf7627001643 /src/core/renderer | |
parent | 24bb272ac83fe42ad4cab58a9e97bdf2a53d2be8 (diff) |
Fix all GCC and Clang warnings
Fix all warnings save for -Wdeprecated-declarations in tests.
Warnings from GCC 9.2.0:
src/core/renderer/extensions/resource_request_policy_qt.cpp:157:23:
warning: variable 'resource_root_relative_path' set but not used
[-Wunused-but-set-variable]
src/core/chromium_overrides.cpp:121:21:
warning: moving a local object in a return statement prevents copy elision
[-Wpessimizing-move]
src/core/render_widget_host_view_qt.cpp:540:12:
warning: enumeration value 'kNull' not handled in switch [-Wswitch]
warning: enumeration value 'kMiddlePanningVertical' not handled in switch
[-Wswitch]
warning: enumeration value 'kMiddlePanningHorizontal' not handled in switch
[-Wswitch]
warning: enumeration value 'kDndNone' not handled in switch [-Wswitch]
warning: enumeration value 'kDndMove' not handled in switch [-Wswitch]
warning: enumeration value 'kDndCopy' not handled in switch [-Wswitch]
warning: enumeration value 'kDndLink' not handled in switch [-Wswitch]
warning: enumeration value 'kMaxValue' not handled in switch [-Wswitch]
src/core/type_conversion.cpp:57:12:
warning: enumeration value ‘kRGBA_F16Norm_SkColorType’ not handled in switch
[-Wswitch]
src/core/api/qtbug-60565.cpp:83:6:
warning: 'void __ShimCppDeleteArrayNoThrow(void*, const std::nothrow_t&)'
alias between functions of incompatible types 'void(void*, const
std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=]
src/core/api/qtbug-60565.cpp:79:6:
warning: 'void __ShimCppDeleteNoThrow(void*, const std::nothrow_t&)' alias
between functions of incompatible types 'void(void*, const std::nothrow_t&)
noexcept' and 'void(void*)' [-Wattribute-alias=]
src/core/api/qtbug-60565.cpp:75:6:
warning: 'void __ShimCppNewArrayNoThrow(size_t, const std::nothrow_t&)'
alias between functions of incompatible types 'void(size_t, const
std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const
std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned
int)'} [-Wattribute-alias=]
src/core/api/qtbug-60565.cpp:71:6:
warning: 'void __ShimCppNewNoThrow(size_t, const std::nothrow_t&)' alias
between functions of incompatible types 'void(size_t, const std::nothrow_t&)
noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'}
and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=]
Warnings from Clang 9.0.1:
src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h:61:29:
warning: private field 'm_dispatcher' is not used [-Wunused-private-field]
src/core/web_event_factory.cpp:1296:5:
warning: unannotated fall-through between switch labels
[-Wimplicit-fallthrough]
src/core/compositor/compositor_resource_fence.h:55:81:
warning: extra ';' after member function definition [-Wextra-semi]
src/core/renderer/render_frame_observer_qt.h:81:10:
warning: 'ReadyToCommitNavigation' overrides a member function but is not
marked 'override' [-Winconsistent-missing-override]
src/core/extensions/mime_handler_view_guest_delegate_qt.h:69:27:
warning: private field 'guest_' is not used [-Wunused-private-field]
src/core/chromium_overrides.cpp:121:12:
warning: moving a local object in a return statement prevents copy elision
[-Wpessimizing-move]
src/core/chromium_overrides.cpp:145:64:
warning: missing field 'set_up_command_line' initializer
[-Wmissing-field-initializers]
src/core/chromium_overrides.cpp:146:55:
warning: missing field 'set_up_command_line' initializer
[-Wmissing-field-initializers]
src/core/render_widget_host_view_qt.cpp:540:13:
warning: 7 enumeration values not handled in switch: 'kNull',
'kMiddlePanningVertical', 'kMiddlePanningHorizontal'... [-Wswitch]
src/core/compositor/stream_video_node.cpp:50:18:
warning: 'updateState' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
src/core/compositor/stream_video_node.cpp:103:18:
warning: 'initialize' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
src/core/type_conversion.cpp:57:13:
warning: enumeration value 'kRGBA_F16Norm_SkColorType' not handled in
switch [-Wswitch]
src/core/renderer_host/web_channel_ipc_transport_host.cpp:59:60:
warning: extra ';' outside of a function is incompatible with C++98
[-Wc++98-compat-extra-semi]
tests/auto/widgets/loadsignals/tst_loadsignals.cpp:237:10:
warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp:1112:62:
warning: lambda capture 'item' is not used [-Wunused-lambda-capture]
tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp:1534:55:
warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
Change-Id: I374be0d4e58accc0a00a2596a560dd6103a98994
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Diffstat (limited to 'src/core/renderer')
4 files changed, 4 insertions, 7 deletions
diff --git a/src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.cpp b/src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.cpp index 39412b76c..aef4903b7 100644 --- a/src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.cpp +++ b/src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.cpp @@ -47,8 +47,7 @@ namespace QtWebEngineCore { -RendererPermissionsPolicyDelegateQt::RendererPermissionsPolicyDelegateQt(extensions::Dispatcher *dispatcher) - : m_dispatcher(dispatcher) +RendererPermissionsPolicyDelegateQt::RendererPermissionsPolicyDelegateQt(extensions::Dispatcher *) { extensions::PermissionsData::SetPolicyDelegate(this); } diff --git a/src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h b/src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h index e2af47657..385b7a4b0 100644 --- a/src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h +++ b/src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h @@ -58,8 +58,6 @@ public: bool IsRestrictedUrl(const GURL &, std::string *) override; private: - extensions::Dispatcher *m_dispatcher; - DISALLOW_COPY_AND_ASSIGN(RendererPermissionsPolicyDelegateQt); }; diff --git a/src/core/renderer/extensions/resource_request_policy_qt.cpp b/src/core/renderer/extensions/resource_request_policy_qt.cpp index a64b1fef8..efe44521d 100644 --- a/src/core/renderer/extensions/resource_request_policy_qt.cpp +++ b/src/core/renderer/extensions/resource_request_policy_qt.cpp @@ -154,9 +154,9 @@ bool ResourceRequestPolicyQt::CanRequestResource(const GURL &resource_url, // hybrid hosted/packaged apps. The one exception is access to icons, since // some extensions want to be able to do things like create their own // launchers. - base::StringPiece resource_root_relative_path = + /*base::StringPiece resource_root_relative_path = resource_url.path_piece().empty() ? base::StringPiece() - : resource_url.path_piece().substr(1); + : resource_url.path_piece().substr(1);*/ if (extension->is_hosted_app() /*&& !IconsInfo::GetIcons(extension).ContainsPath(resource_root_relative_path)*/) { LOG(ERROR) << "Denying load of " << resource_url.spec() << " from " << "hosted app."; diff --git a/src/core/renderer/render_frame_observer_qt.h b/src/core/renderer/render_frame_observer_qt.h index 3c54761f3..fb9fd3869 100644 --- a/src/core/renderer/render_frame_observer_qt.h +++ b/src/core/renderer/render_frame_observer_qt.h @@ -78,7 +78,7 @@ public: private: DISALLOW_COPY_AND_ASSIGN(RenderFrameObserverQt); - void ReadyToCommitNavigation(blink::WebDocumentLoader *); + void ReadyToCommitNavigation(blink::WebDocumentLoader *) override; bool m_isFrameDetached; service_manager::BinderRegistry registry_; |