diff options
author | Peter Varga <pvarga@inf.u-szeged.hu> | 2016-11-24 15:02:34 +0100 |
---|---|---|
committer | Peter Varga <pvarga@inf.u-szeged.hu> | 2016-11-25 13:10:44 +0000 |
commit | 9894a46ced4e760a90b8e0508ca1452f5d2fd7ef (patch) | |
tree | ca983d2d0b3d2153b31bdda591893b6f2bf99700 /src/core/renderer | |
parent | 5bd02ef363a7fcfdb0c34dcd75938c54163bf10f (diff) |
Rework and fix loadVisuallyCommitted signal
- Remove RenderViewObserverHostQt_DidFirstVisuallyNonEmptyLayout message
and use WebContentsObserver::DidFirstVisuallyNonEmptyPaint instead.
- The order of the DidFirstVisuallyNonEmptyPaint and
OnSwapCompositorFrame events is not guaranteed. Check for both events to
do not miss to send any loadVisuallyCommitted signal.
Change-Id: Ic733b3e9a6fae64b1d827e8e07514f180273cf8c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'src/core/renderer')
-rw-r--r-- | src/core/renderer/render_view_observer_qt.cpp | 5 | ||||
-rw-r--r-- | src/core/renderer/render_view_observer_qt.h | 1 |
2 files changed, 0 insertions, 6 deletions
diff --git a/src/core/renderer/render_view_observer_qt.cpp b/src/core/renderer/render_view_observer_qt.cpp index 393b4752c..97485afad 100644 --- a/src/core/renderer/render_view_observer_qt.cpp +++ b/src/core/renderer/render_view_observer_qt.cpp @@ -83,11 +83,6 @@ void RenderViewObserverQt::onSetBackgroundColor(quint32 color) render_view()->GetWebFrameWidget()->setBaseBackgroundColor(color); } -void RenderViewObserverQt::OnFirstVisuallyNonEmptyLayout() -{ - Send(new RenderViewObserverHostQt_DidFirstVisuallyNonEmptyLayout(routing_id())); -} - bool RenderViewObserverQt::OnMessageReceived(const IPC::Message& message) { bool handled = true; diff --git a/src/core/renderer/render_view_observer_qt.h b/src/core/renderer/render_view_observer_qt.h index b62c815af..538ebea8a 100644 --- a/src/core/renderer/render_view_observer_qt.h +++ b/src/core/renderer/render_view_observer_qt.h @@ -57,7 +57,6 @@ private: void onFetchDocumentInnerText(quint64 requestId); void onSetBackgroundColor(quint32 color); - void OnFirstVisuallyNonEmptyLayout() Q_DECL_OVERRIDE; void OnDestruct() Q_DECL_OVERRIDE { } virtual bool OnMessageReceived(const IPC::Message& message) Q_DECL_OVERRIDE; |