[macOS] Use the OpenGL CoreProfile when the global shared context does

Previously when a default QSurfaceFormat was set with an OpenGL Core
profile, all the contexts created on the Qt side would obey the profile,
but Chromium would still use the Compatibility profile for its contexts
leading to warnings when trying to create shared contexts.

The fix is to check which OpenGL profile is used in the Qt global
shared context, and pass that information along to Chromium.

Note that this works only on macOS for now, and the default non-Core
profile is used on other platforms, even though Core was requested.
Passing CoreProfile to Chromium on Windows and Linux currently leads
to crashes.

Task-number: QTBUG-60605
Change-Id: I27a77091923624d19ccc2019953a5b07f9282916
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>

1 files changed, 15 insertions, 1 deletions

diff --git a/src/core/web_engine_context.cpp b/src/core/web_engine_context.cpp
index 2748d2a0f..56dbb84b7 100644
--- a/src/core/web_engine_context.cpp
+++ b/src/core/web_engine_context.cpp
@@ -389,8 +389,22 @@ WebEngineContext::WebEngineContext()
                     }
                 }
             } else {
-                if (!qt_gl_global_share_context()->isOpenGLES())
+                if (!qt_gl_global_share_context()->isOpenGLES()) {
+                    // Default to Desktop non-Core profile OpenGL.
                     glType = gl::kGLImplementationDesktopName;
+
+                    // Check if Core profile was requested and is supported.
+                    QSurfaceFormat globalSharedFormat = qt_gl_global_share_context()->format();
+                    if (globalSharedFormat.profile() == QSurfaceFormat::CoreProfile) {
+#ifdef Q_OS_MACOS
+                        glType = gl::kGLImplementationCoreProfileName;
+#else
+                        qWarning("An OpenGL Core Profile was requested, but it is not supported "
+                                 "on the current platform. Falling back to a non-Core profile. "
+                                 "Note that this might cause rendering issues.");
+#endif
+                    }
+                }
             }
         } else {
             qWarning("WebEngineContext used before QtWebEngine::initialize() or OpenGL context creation failed.");