diff options
author | Simon Hausmann <simon.hausmann@theqtcompany.com> | 2014-12-15 23:58:36 +0100 |
---|---|---|
committer | Michal Klocek <michal.klocek@qt.io> | 2019-11-25 12:01:39 +0100 |
commit | 3db8a36d0a35303fece8e8da45efe8efe928a378 (patch) | |
tree | b6ce6ddced710742a1d40ba265cbc7658bdd04d9 /src/pdf/qpdfdocument.cpp | |
parent | 55b863f2dd2773290c63259c3835b19dcb277098 (diff) |
Clean up error handling
Diffstat (limited to 'src/pdf/qpdfdocument.cpp')
-rw-r--r-- | src/pdf/qpdfdocument.cpp | 24 |
1 files changed, 10 insertions, 14 deletions
diff --git a/src/pdf/qpdfdocument.cpp b/src/pdf/qpdfdocument.cpp index b6fd203cd..1a3a6f3ea 100644 --- a/src/pdf/qpdfdocument.cpp +++ b/src/pdf/qpdfdocument.cpp @@ -63,8 +63,12 @@ void QPdfDocumentPrivate::clear() asyncBuffer.open(QIODevice::ReadWrite); } -void QPdfDocumentPrivate::setErrorCode() +void QPdfDocumentPrivate::updateLastError() { + if (doc) { + lastError = QPdfDocument::NoError; + return; + } switch (FPDF_GetLastError()) { case FPDF_ERR_SUCCESS: lastError = QPdfDocument::NoError; break; case FPDF_ERR_UNKNOWN: lastError = QPdfDocument::UnknownError; break; @@ -96,10 +100,7 @@ QPdfDocument::Error QPdfDocumentPrivate::load(QIODevice *newDevice, bool transfe password = documentPassword.toUtf8(); doc = FPDF_LoadCustomDocument(this, password.constData()); - if (doc) - clearError(); - else - setErrorCode(); + updateLastError(); return lastError; } @@ -150,16 +151,11 @@ void QPdfDocumentPrivate::tryLoadDocument() Q_ASSERT(!doc); doc = FPDFAvail_GetDocument(avail, password); - if (doc) { - clearError(); - } else { - setErrorCode(); - if (lastError == QPdfDocument::IncorrectPasswordError) - emit q->passwordRequired(); - } - if (doc) { + updateLastError(); + if (lastError == QPdfDocument::IncorrectPasswordError) + emit q->passwordRequired(); + else if (doc) emit q->documentLoadStarted(); - } } void QPdfDocumentPrivate::checkComplete() |