diff options
| author | Jüri Valdmann <juri.valdmann@qt.io> | 2017-11-14 16:23:18 +0100 |
|---|---|---|
| committer | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2018-01-02 20:45:07 +0000 |
| commit | 7219986a18d45dd0e32a8004c748ce91d22a535b (patch) | |
| tree | 1162c8e7050eba4afe833109b00f814ec76ec75c /src/webengine/api/qquickwebenginedownloaditem_p.h | |
| parent | 9214f8e6092b48e7b596f343b5e9bb7afd430078 (diff) | |
Deprecate download type
This patch removes the download type property from QtWebEngineCore and replaces
it with a simple boolean 'isSavePageDownload'. On the public API boundary the
type property is reimplemented via this boolean and documented as obsolete.
Rationale being that
1. This feature seems to lack practical use cases, other than perhaps
distinguishing save-page downloads from normal file downloads, which can be
done in a much simpler way.
2. This feature does not work as documented and never has. So far nobody has
complained, hinting again at a lack of practical use cases.
3. In order to fix it we would need to maintain patches on top of Chromium and
Blink (we would, for example, need to propagate the DownloadAttribute type
from Blink to Chromium to WebEngine).
[ChangeLog][Deprecation Notice] (QWebEngine)DownloadItem::type() is deprecated
and replaced with the newly introduced isSavePageDownload() property.
Task-number: QTBUG-62640
Change-Id: Icf4e1e5a635028986df7eab979f4c0527902ff0c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Diffstat (limited to 'src/webengine/api/qquickwebenginedownloaditem_p.h')
| -rw-r--r-- | src/webengine/api/qquickwebenginedownloaditem_p.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/webengine/api/qquickwebenginedownloaditem_p.h b/src/webengine/api/qquickwebenginedownloaditem_p.h index 972b130aa..1699ee9dc 100644 --- a/src/webengine/api/qquickwebenginedownloaditem_p.h +++ b/src/webengine/api/qquickwebenginedownloaditem_p.h @@ -133,6 +133,7 @@ public: Q_PROPERTY(QString interruptReasonString READ interruptReasonString NOTIFY interruptReasonChanged REVISION 4 FINAL) Q_PROPERTY(bool isFinished READ isFinished NOTIFY isFinishedChanged REVISION 5 FINAL) Q_PROPERTY(bool isPaused READ isPaused NOTIFY isPausedChanged REVISION 5 FINAL) + Q_PROPERTY(bool isSavePageDownload READ isSavePageDownload CONSTANT REVISION 6 FINAL) Q_INVOKABLE void accept(); Q_INVOKABLE void cancel(); @@ -148,11 +149,12 @@ public: void setPath(QString path); SavePageFormat savePageFormat() const; void setSavePageFormat(SavePageFormat format); - DownloadType type() const; + DownloadType Q_DECL_DEPRECATED type() const; DownloadInterruptReason interruptReason() const; QString interruptReasonString() const; bool isFinished() const; bool isPaused() const; + bool isSavePageDownload() const; Q_SIGNALS: void stateChanged(); |