path: root/src/webenginewidgets
diff options
authorJocelyn Turcotte <>2014-02-28 11:27:02 +0100
committerThe Qt Project <>2014-03-07 18:19:19 +0100
commit7d371328265a4912fb323779adf95cc922a83541 (patch)
tree2e7a24c90828a11f0879e5877171a118a7e1fd92 /src/webenginewidgets
parenta2e45ded2dd1a9c183f1ff4ea84057f5c43972c5 (diff)
Deploy QtWebEngineCore as a Qt module
This delegates the linking step from ninja to qmake so that we can let qmake decide the destination of the target itself, easing the deployment and installation logic across platforms. The module is only deployed as a binary and no header are available outside of the source tree. This is only to make sure that the dependence of the QtWebEngine and QtWebEngineWidgets libraries on it is resolved at runtime exactly the same way as with other Qt modules, on all platforms. Ninja still takes care of the compilation and gyp lets qmake know how and what to link by dumping the list of flags and input files in a generated .pri file. This has to be done in a separate .pro file so that we can make sure that ninja is run inconditionally before make reaches the dependency check in, ensured by the parent Makefile. Note 1: This patch removes RPATH hacks that are no longer necessary Note 2: Other targets like ffmpegsumo are still linked by ninja. The same logic could be moved to a qmake file but this require some more work to make sure that some switches (e.g. -stdlib=libc++) are coordinated between gyp and qmake. Change-Id: If65968547bde5b9cf732e31e97931c17ae1921a7 Reviewed-by: Zoltan Arvai <> Reviewed-by: Andras Becsi <>
Diffstat (limited to 'src/webenginewidgets')
1 files changed, 1 insertions, 18 deletions
diff --git a/src/webenginewidgets/ b/src/webenginewidgets/
index a871586ae..c97e4b61e 100644
--- a/src/webenginewidgets/
+++ b/src/webenginewidgets/
@@ -4,15 +4,7 @@ TARGET = QtWebEngineWidgets
QT += widgets network
-QT_PRIVATE += widgets-private gui-private network-private core-private
-# FIXME: all this should eventually be turned into QT += webenginecore
-macx:LIBPATH = $$getOutDir()/$$getConfigDir()
-else:LIBPATH = $$getOutDir()/$$getConfigDir()/lib
-LIBS_PRIVATE += -L$$LIBPATH -lQt5WebEngineCore
+QT_PRIVATE += webenginecore widgets-private gui-private network-private core-private
INCLUDEPATH += $$PWD api ../core
@@ -33,12 +25,3 @@ HEADERS = \
-# Some binutils versions configured for cross compilation only support
-# sysroot-relative rpath values and can't use the rpath specified above.
-# Instead, append an appropriate rpath-link to lib_qt_webenginewidgets.pri.
-cross_compile:!build_pass {
- local_build_rpath_link = "QMAKE_RPATHLINKDIR += $$LIBPATH"
- # MODULE_PRI is defined in qt_module_pris.prf
- write_file($$MODULE_PRI, local_build_rpath_link, append)