Fix widgets download state update

Since the DownloadState enum of core does not match the DownloadState
enum of QWebEngineDownloadItem we should never directly compare it,
instead we should convert with the toDownloadState() function,
to fix the missing emission of the finished() signal.
This patch also adds static asserts to verify the match of chromium's
DownloadItem::DownloadState and our core DownloadState.

Change-Id: I51110f55598230e380e15948f75219976d3a68a0
Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>

2 files changed, 2 insertions, 1 deletions

diff --git a/src/webenginewidgets/api/qwebenginedownloaditem.cpp b/src/webenginewidgets/api/qwebenginedownloaditem.cpp
index f97b25431..9bfe1f9fd 100644
--- a/src/webenginewidgets/api/qwebenginedownloaditem.cpp
+++ b/src/webenginewidgets/api/qwebenginedownloaditem.cpp
@@ -91,7 +91,7 @@ void QWebEngineDownloadItemPrivate::update(const BrowserContextAdapterClient::Do
 
     Q_ASSERT(downloadState != QWebEngineDownloadItem::DownloadRequested);
 
-    if (info.state != downloadState) {
+    if (toDownloadState(info.state) != downloadState) {
         downloadState = toDownloadState(info.state);
         Q_EMIT q->stateChanged(downloadState);
     }
diff --git a/src/webenginewidgets/api/qwebengineprofile.cpp b/src/webenginewidgets/api/qwebengineprofile.cpp
index eceee0fd3..8c4dcb59f 100644
--- a/src/webenginewidgets/api/qwebengineprofile.cpp
+++ b/src/webenginewidgets/api/qwebengineprofile.cpp
@@ -91,6 +91,7 @@ QT_BEGIN_NAMESPACE
   cancelled by default.
   The download item is parented by the profile, but if not accepted
   will be deleted immediately after the signal emission.
+  This signal can not be used with a queued connection.
 
   \sa QWebEngineDownloadItem
 */