FaviconManager: fix quadratic loop

QMutableListIterator::remove() is linear, so calling it in a loop
constitutes quadratic behavior. Use std::remove_if, which is linear.

Change-Id: I238b051fe87e348e5576452a6581b8799bfb49b5
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
 
 

1 files changed, 4 insertions, 5 deletions

diff --git a/src/core/favicon_manager.cpp b/src/core/favicon_manager.cpp
index 489e23d99..a06da6769 100644
--- a/src/core/favicon_manager.cpp
+++ b/src/core/favicon_manager.cpp
@@ -229,11 +229,10 @@ QList<FaviconInfo> FaviconManager::getFaviconInfoList(bool candidatesOnly) const
     QList<FaviconInfo> faviconInfoList = m_faviconInfoMap.values();
 
     if (candidatesOnly) {
-        QMutableListIterator<FaviconInfo> it(faviconInfoList);
-        while (it.hasNext()) {
-            if (!it.next().candidate)
-                it.remove();
-        }
+        const auto hasNoCandidate = [](const FaviconInfo &info) { return !info.candidate; };
+        faviconInfoList.erase(std::remove_if(faviconInfoList.begin(), faviconInfoList.end(),
+                                             hasNoCandidate),
+                              faviconInfoList.end());
     }
 
     return faviconInfoList;