summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorViktor Engelmann <viktor.engelmann@qt.io>2016-09-15 15:44:15 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2016-09-19 08:21:26 +0000
commit2057634462750fc7a6157600509044564c2f47fd (patch)
treebf3b296143e88f3f714f4521601f8bfcaebbbc56 /src
parent9c0bd9207560e36e7bad3657e02305aabd7638b9 (diff)
Fix dangling pointer problem
Turn the raw pointer ResourceDispatcherHostLoginDelegateQt::m_authInfo into a scoped_refptr, to prevent chromium from freeing the memory, which caused this pointer to dangle and SEGFAULT upon later usage. Task-number: QTBUG-55828 Change-Id: Ib57e89ca042a4494e2ab77ea10328495e6fc1431 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Michael BrĂ¼ning <michael.bruning@qt.io>
Diffstat (limited to 'src')
-rw-r--r--src/core/resource_dispatcher_host_delegate_qt.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/core/resource_dispatcher_host_delegate_qt.h b/src/core/resource_dispatcher_host_delegate_qt.h
index 57eaa3bc5..49e69ecf9 100644
--- a/src/core/resource_dispatcher_host_delegate_qt.h
+++ b/src/core/resource_dispatcher_host_delegate_qt.h
@@ -73,7 +73,7 @@ private:
int m_renderProcessId;
int m_renderFrameId;
- net::AuthChallengeInfo *m_authInfo;
+ scoped_refptr<net::AuthChallengeInfo> m_authInfo;
// The request that wants login data.
// Must only be accessed on the IO thread.