diff options
author | Michal Klocek <michal.klocek@qt.io> | 2020-08-11 14:46:42 +0200 |
---|---|---|
committer | Michal Klocek <michal.klocek@qt.io> | 2020-08-28 13:40:00 +0200 |
commit | 1978e726a909ac945c32429e216c49ecad3ecb3a (patch) | |
tree | bf0cbbf13ba31f08b4552544122044ac6386fdf4 /tests/auto/quick/publicapi | |
parent | 08375ee796a545e3916feb24e0b35d561e6f0049 (diff) |
Improve QWebEngineCertificateError api
* remove const ref from QWebEngineCertificateError
Q_GADGET is a value type, QWebEngineCertificateError is pass
as const reference from api. This is not so useful since, in qml this
will be anyway copied and for c++ this is not useful since
reject, ignore, defer methods are all const. Therefore simply
pass it by value.
* make consistent naming defer(), acceptCertificate(), rejectCertificate()
* remove properties 'differed', 'answered' which are use internally,
user knows if he calls functions.
* error.errorDescription -> error.description()
* error.error() -> error.type()
[ChangeLog] In QWebEngineCertificateError use acceptCertificate()
instead of ignoreCertificiateError()
Change-Id: I9ffa500a0a455d98445b066252dd283872740731
Reviewed-by: Michael BrĂ¼ning <michael.bruning@qt.io>
Diffstat (limited to 'tests/auto/quick/publicapi')
-rw-r--r-- | tests/auto/quick/publicapi/tst_publicapi.cpp | 38 |
1 files changed, 18 insertions, 20 deletions
diff --git a/tests/auto/quick/publicapi/tst_publicapi.cpp b/tests/auto/quick/publicapi/tst_publicapi.cpp index e5f5bf27d..83ae3f0cd 100644 --- a/tests/auto/quick/publicapi/tst_publicapi.cpp +++ b/tests/auto/quick/publicapi/tst_publicapi.cpp @@ -121,28 +121,26 @@ static const QStringList expectedAPI = QStringList() << "QQuickWebEngineAuthenticationDialogRequest.realm --> QString" << "QQuickWebEngineAuthenticationDialogRequest.type --> AuthenticationType" << "QQuickWebEngineAuthenticationDialogRequest.url --> QUrl" - << "QWebEngineCertificateError.CertificateAuthorityInvalid --> Error" - << "QWebEngineCertificateError.CertificateCommonNameInvalid --> Error" - << "QWebEngineCertificateError.CertificateContainsErrors --> Error" - << "QWebEngineCertificateError.CertificateDateInvalid --> Error" - << "QWebEngineCertificateError.CertificateInvalid --> Error" - << "QWebEngineCertificateError.CertificateKnownInterceptionBlocked --> Error" - << "QWebEngineCertificateError.CertificateNameConstraintViolation --> Error" - << "QWebEngineCertificateError.CertificateNoRevocationMechanism --> Error" - << "QWebEngineCertificateError.CertificateNonUniqueName --> Error" - << "QWebEngineCertificateError.CertificateRevoked --> Error" - << "QWebEngineCertificateError.CertificateTransparencyRequired --> Error" - << "QWebEngineCertificateError.CertificateUnableToCheckRevocation --> Error" - << "QWebEngineCertificateError.CertificateValidityTooLong --> Error" - << "QWebEngineCertificateError.CertificateWeakKey --> Error" - << "QWebEngineCertificateError.CertificateWeakSignatureAlgorithm --> Error" - << "QWebEngineCertificateError.SslPinnedKeyNotInCertificateChain --> Error" - << "QWebEngineCertificateError.answered --> bool" - << "QWebEngineCertificateError.deferred --> bool" + << "QWebEngineCertificateError.CertificateAuthorityInvalid --> Type" + << "QWebEngineCertificateError.CertificateCommonNameInvalid --> Type" + << "QWebEngineCertificateError.CertificateContainsErrors --> Type" + << "QWebEngineCertificateError.CertificateDateInvalid --> Type" + << "QWebEngineCertificateError.CertificateInvalid --> Type" + << "QWebEngineCertificateError.CertificateKnownInterceptionBlocked --> Type" + << "QWebEngineCertificateError.CertificateNameConstraintViolation --> Type" + << "QWebEngineCertificateError.CertificateNoRevocationMechanism --> Type" + << "QWebEngineCertificateError.CertificateNonUniqueName --> Type" + << "QWebEngineCertificateError.CertificateRevoked --> Type" + << "QWebEngineCertificateError.CertificateTransparencyRequired --> Type" + << "QWebEngineCertificateError.CertificateUnableToCheckRevocation --> Type" + << "QWebEngineCertificateError.CertificateValidityTooLong --> Type" + << "QWebEngineCertificateError.CertificateWeakKey --> Type" + << "QWebEngineCertificateError.CertificateWeakSignatureAlgorithm --> Type" + << "QWebEngineCertificateError.SslPinnedKeyNotInCertificateChain --> Type" << "QWebEngineCertificateError.defer() --> void" << "QWebEngineCertificateError.description --> QString" - << "QWebEngineCertificateError.error --> Error" - << "QWebEngineCertificateError.ignoreCertificateError() --> void" + << "QWebEngineCertificateError.type --> Type" + << "QWebEngineCertificateError.acceptCertificate() --> void" << "QWebEngineCertificateError.overridable --> bool" << "QWebEngineCertificateError.rejectCertificate() --> void" << "QWebEngineCertificateError.url --> QUrl" |