diff options
| author | Jüri Valdmann <juri.valdmann@qt.io> | 2019-07-02 12:43:52 +0200 |
|---|---|---|
| committer | Jüri Valdmann <juri.valdmann@qt.io> | 2019-07-02 12:43:52 +0200 |
| commit | 57119f16668cf79dec0dbdfbc9a2183f9e5c44fa (patch) | |
| tree | a9f6c7ec75d91eb8408d02dd2c16eec4a39e0541 /tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp | |
| parent | fb430b4e104dd6313a776980b4798f1333193149 (diff) | |
| parent | bd864f6418ed164c19a700fc4b6ebab3be431c62 (diff) | |
Merge remote-tracking branch 'origin/5.13' into dev
Change-Id: I806417dd7a6d2594a86ee49feedc4ad9ee48add2
Diffstat (limited to 'tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp')
| -rw-r--r-- | tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp | 95 |
1 files changed, 93 insertions, 2 deletions
diff --git a/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp b/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp index e361dbf0a..e579879f4 100644 --- a/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp +++ b/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp @@ -215,6 +215,10 @@ private Q_SLOTS: void recommendedStateAuto(); void setLifecycleStateAndReload(); + void editActionsWithExplicitFocus(); + void editActionsWithInitialFocus(); + void editActionsWithFocusOnIframe(); + private: static QPoint elementCenter(QWebEnginePage *page, const QString &id); @@ -722,8 +726,8 @@ void tst_QWebEnginePage::textSelection() // these actions must exist QVERIFY(page->action(QWebEnginePage::SelectAll) != 0); - // ..but SelectAll is awalys enabled - QCOMPARE(page->action(QWebEnginePage::SelectAll)->isEnabled(), true); + // ..but SelectAll is disabled because the page has no focus due to disabled FocusOnNavigationEnabled. + QCOMPARE(page->action(QWebEnginePage::SelectAll)->isEnabled(), false); // Verify hasSelection returns false since there is no selection yet... QCOMPARE(page->hasSelection(), false); @@ -4050,6 +4054,93 @@ void tst_QWebEnginePage::setLifecycleStateAndReload() QCOMPARE(loadSpy.takeFirst().value(0), QVariant(true)); } +void tst_QWebEnginePage::editActionsWithExplicitFocus() +{ + QWebEngineView view; + QWebEnginePage *page = view.page(); + view.settings()->setAttribute(QWebEngineSettings::FocusOnNavigationEnabled, false); + + QSignalSpy loadFinishedSpy(page, &QWebEnginePage::loadFinished); + QSignalSpy selectionChangedSpy(page, &QWebEnginePage::selectionChanged); + QSignalSpy actionChangedSpy(page->action(QWebEnginePage::SelectAll), &QAction::changed); + + // The view is hidden and no focus on the page. Edit actions should be disabled. + QVERIFY(!view.isVisible()); + QVERIFY(!page->action(QWebEnginePage::SelectAll)->isEnabled()); + + page->setHtml(QString("<html><body><div>foo bar</div></body></html>")); + QTRY_COMPARE(loadFinishedSpy.count(), 1); + + // Still no focus because focus on navigation is disabled. Edit actions don't do anything (should not crash). + QVERIFY(!page->action(QWebEnginePage::SelectAll)->isEnabled()); + view.page()->triggerAction(QWebEnginePage::SelectAll); + QCOMPARE(selectionChangedSpy.count(), 0); + QCOMPARE(page->hasSelection(), false); + + // Focus content by focusing window from JavaScript. Edit actions should be enabled and functional. + evaluateJavaScriptSync(page, "window.focus();"); + QTRY_COMPARE(actionChangedSpy.count(), 1); + QVERIFY(page->action(QWebEnginePage::SelectAll)->isEnabled()); + view.page()->triggerAction(QWebEnginePage::SelectAll); + QTRY_COMPARE(selectionChangedSpy.count(), 1); + QCOMPARE(page->hasSelection(), true); + QCOMPARE(page->selectedText(), QStringLiteral("foo bar")); +} + +void tst_QWebEnginePage::editActionsWithInitialFocus() +{ + QWebEngineView view; + QWebEnginePage *page = view.page(); + view.settings()->setAttribute(QWebEngineSettings::FocusOnNavigationEnabled, true); + + QSignalSpy loadFinishedSpy(page, &QWebEnginePage::loadFinished); + QSignalSpy selectionChangedSpy(page, &QWebEnginePage::selectionChanged); + QSignalSpy actionChangedSpy(page->action(QWebEnginePage::SelectAll), &QAction::changed); + + // The view is hidden and no focus on the page. Edit actions should be disabled. + QVERIFY(!view.isVisible()); + QVERIFY(!page->action(QWebEnginePage::SelectAll)->isEnabled()); + + page->setHtml(QString("<html><body><div>foo bar</div></body></html>")); + QTRY_COMPARE(loadFinishedSpy.count(), 1); + + // Content gets initial focus. + QTRY_COMPARE(actionChangedSpy.count(), 1); + QVERIFY(page->action(QWebEnginePage::SelectAll)->isEnabled()); + view.page()->triggerAction(QWebEnginePage::SelectAll); + QTRY_COMPARE(selectionChangedSpy.count(), 1); + QCOMPARE(page->hasSelection(), true); + QCOMPARE(page->selectedText(), QStringLiteral("foo bar")); +} + +void tst_QWebEnginePage::editActionsWithFocusOnIframe() +{ + QWebEngineView view; + QWebEnginePage *page = view.page(); + view.settings()->setAttribute(QWebEngineSettings::FocusOnNavigationEnabled, false); + + QSignalSpy loadFinishedSpy(page, &QWebEnginePage::loadFinished); + QSignalSpy selectionChangedSpy(page, &QWebEnginePage::selectionChanged); + QSignalSpy actionChangedSpy(page->action(QWebEnginePage::SelectAll), &QAction::changed); + + // The view is hidden and no focus on the page. Edit actions should be disabled. + QVERIFY(!view.isVisible()); + QVERIFY(!page->action(QWebEnginePage::SelectAll)->isEnabled()); + + page->load(QUrl("qrc:///resources/iframe2.html")); + QTRY_COMPARE(loadFinishedSpy.count(), 1); + QVERIFY(!page->action(QWebEnginePage::SelectAll)->isEnabled()); + + // Focusing an iframe. + evaluateJavaScriptSync(page, "document.getElementsByTagName('iframe')[0].contentWindow.focus()"); + QTRY_COMPARE(actionChangedSpy.count(), 1); + QVERIFY(page->action(QWebEnginePage::SelectAll)->isEnabled()); + view.page()->triggerAction(QWebEnginePage::SelectAll); + QTRY_COMPARE(selectionChangedSpy.count(), 1); + QCOMPARE(page->hasSelection(), true); + QCOMPARE(page->selectedText(), QStringLiteral("inner")); +} + static QByteArrayList params = {QByteArrayLiteral("--use-fake-device-for-media-stream")}; W_QTEST_MAIN(tst_QWebEnginePage, params) |