diff options
author | Allan Sandfeld Jensen <allan.jensen@qt.io> | 2021-07-14 11:08:33 +0200 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-07-23 14:32:37 +0000 |
commit | dae47317c1089a438a92d8080109bde43f14b540 (patch) | |
tree | 96cdd51c25990215c34beae7899d4375100bb834 /tests/auto/widgets | |
parent | 90f8de8f95c5151a4cd4d94b7da37e6b8bdd9014 (diff) |
Add QWebEngineNewWindowRequest::openIn(QWebEnginePage *)
Makes for a nicer API
Change-Id: I15e72d526e9cf6cf9ca8bd3e24f5dd7e7b2e9fa5
Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
(cherry picked from commit 9285872b0dd4da8c0ba1dd8ef6c6822f85622f4e)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'tests/auto/widgets')
-rw-r--r-- | tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp b/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp index 8df70d917..824c00f18 100644 --- a/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp +++ b/tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp @@ -564,7 +564,7 @@ private Q_SLOTS: TestPage *page = new TestPage(this); createdWindows.append(page); emit windowCreated(); - page->acceptAsNewWindow(request); + request.openIn(page); } void slotGeometryChangeRequested(const QRect &geom) @@ -3433,8 +3433,7 @@ void tst_QWebEnginePage::openLinkInDifferentProfile() QWebEngineProfile profile1, profile2; QWebEnginePage page1(&profile1), page2(&profile2); connect(&page1, &QWebEnginePage::newWindowRequested, [&](QWebEngineNewWindowRequest &request) { - if (targetPage) - targetPage->acceptAsNewWindow(request); + request.openIn(targetPage); }); QWebEngineView view; view.resize(500, 500); |