Replace the inspectable property with an environment variable

The current implementation would enable or disable the inspector
globally when the inspectable property was set on a WebEngineView,
overwriting the value previously set by other pages.

Instead of havind default port for the debugging server and having
to enable debugging on individual pages, use an environment variable,
QTWEBENGINE_REMOTE_DEBUGGING, to enable the debugging server for the
whole application at the same time as specifying the port. The format
is the same as for QTWEBKIT_INSPECTOR_SERVER in QtWebKit.

QTWEBENGINE_REMOTE_DEBUGGING is set by default in quicktestbrowser
to ease development.

This also keeps the input reading from the --remote-debugging-port
command line switch for convenience, but its usage should be
considered internal.

This patch also take the opportunity to remove the unused
DevToolsHttpHandlerDelegateQt::m_browserContext and to move the
ownership from ContentBrowserClientQt to WebEngineContext since
the list of inspectable pages isn't bound to the BrowserContext
anyway.

Change-Id: I772687f88f4feee0cc14dd182b0129cc0ea384dd
Reviewed-by: Pierre Rossi <pierre.rossi@theqtcompany.com>

1 files changed, 3 insertions, 0 deletions

diff --git a/tests/quicktestbrowser/main.cpp b/tests/quicktestbrowser/main.cpp
index d8fe01aa1..d44f644c3 100644
--- a/tests/quicktestbrowser/main.cpp
+++ b/tests/quicktestbrowser/main.cpp
@@ -53,6 +53,9 @@ int main(int argc, char **argv)
 {
     Application app(argc, argv);
 
+    // Enable dev tools by default for the test browser
+    if (qgetenv("QTWEBENGINE_REMOTE_DEBUGGING").isNull())
+        qputenv("QTWEBENGINE_REMOTE_DEBUGGING", "1337");
     QtWebEngine::initialize();
 
     ApplicationEngine appEngine;