diff options
author | Michal Klocek <michal.klocek@qt.io> | 2021-05-13 15:37:17 +0200 |
---|---|---|
committer | Michal Klocek <michal.klocek@qt.io> | 2021-05-22 14:11:01 +0200 |
commit | 3cdf6827de796b49fb49f94a18906303732bb93f (patch) | |
tree | e79b5e68b96daeb0d76acb23d070f1913fa9d85d /tests | |
parent | 035579f424e5b69cee212d23fda3467f5db8d19e (diff) |
Remove certificate fatal error test
This test did not work for a while and was always skipped.
Moreover OCSP handling does not work anylonger with 88-based.
Task-number: QTBUG-91467
Change-Id: Ifcc4bf34bfafe7811aa159506eaf34168f08807f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'tests')
-rw-r--r-- | tests/auto/quick/qmltests/data/tst_certificateError.qml | 17 | ||||
-rw-r--r-- | tests/auto/widgets/certificateerror/tst_certificateerror.cpp | 18 |
2 files changed, 0 insertions, 35 deletions
diff --git a/tests/auto/quick/qmltests/data/tst_certificateError.qml b/tests/auto/quick/qmltests/data/tst_certificateError.qml index d6c7edfd8..07cfa3aa8 100644 --- a/tests/auto/quick/qmltests/data/tst_certificateError.qml +++ b/tests/auto/quick/qmltests/data/tst_certificateError.qml @@ -115,22 +115,5 @@ TestWebEngineView { view.certificateError.disconnect(handleCertificateError) } - - function test_fatalError() { - var handleCertificateError = function(error) { - verify(!error.overrideable); - // QQuickWebEngineViewPrivate::allowCertificateError() will implicitly reject - // fatal errors and it should not crash if already rejected in handler. - error.rejectCertificate(); - } - view.certificateError.connect(handleCertificateError); - - view.url = Qt.resolvedUrl('https://revoked.badssl.com'); - if (!view.waitForLoadFailed(10000)) - skip("Couldn't load page from network, skipping test."); - compare(spyError.count, 1); - - view.certificateError.disconnect(handleCertificateError); - } } } diff --git a/tests/auto/widgets/certificateerror/tst_certificateerror.cpp b/tests/auto/widgets/certificateerror/tst_certificateerror.cpp index 4bb29fe23..29b35df93 100644 --- a/tests/auto/widgets/certificateerror/tst_certificateerror.cpp +++ b/tests/auto/widgets/certificateerror/tst_certificateerror.cpp @@ -44,7 +44,6 @@ public: private Q_SLOTS: void handleError_data(); void handleError(); - void fatalError(); }; struct PageWithCertificateErrorHandler : QWebEnginePage @@ -126,22 +125,5 @@ void tst_CertificateError::handleError() QCOMPARE(toPlainTextSync(&page), expectedContent); } -void tst_CertificateError::fatalError() -{ - PageWithCertificateErrorHandler page(false, false); - page.profile()->setUseForGlobalCertificateVerification(); - page.settings()->setAttribute(QWebEngineSettings::ErrorPageEnabled, false); - QSignalSpy loadFinishedSpy(&page, &QWebEnginePage::loadFinished); - - page.setUrl(QUrl("https://revoked.badssl.com")); - if (!loadFinishedSpy.wait(10000)) - QSKIP("Couldn't load page from network, skipping test."); - QTRY_VERIFY(page.error); - QVERIFY(!page.error->isOverridable()); - - // Fatal certificate errors are implicitly rejected. This should not cause crash. - page.error->rejectCertificate(); -} - QTEST_MAIN(tst_CertificateError) #include <tst_certificateerror.moc> |