View's contexMenu test: fix assumption for input events

Mouse clicks are set to be ignored in chromium 79 as no useful actions
are available before first real navigation. Add simple blank load for
that and also enforce checks for different kind of policy.

Task-number: QTBUG-80743
Change-Id: Icb0056895c5b194e85bb711b8449e179257f8d5d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>

1 files changed, 28 insertions, 9 deletions

diff --git a/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp b/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp
index 9c9a32917..f15a65469 100644
--- a/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp
+++ b/tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp
@@ -3148,36 +3148,55 @@ void tst_QWebEngineView::noContextMenu()
 void tst_QWebEngineView::contextMenu_data()
 {
     QTest::addColumn<int>("childrenCount");
+    QTest::addColumn<bool>("isCustomMenu");
     QTest::addColumn<Qt::ContextMenuPolicy>("contextMenuPolicy");
-    QTest::newRow("defaultContextMenu") << 1 << Qt::DefaultContextMenu;
-    QTest::newRow("customContextMenu") << 1 << Qt::CustomContextMenu;
-    QTest::newRow("preventContextMenu") << 0 << Qt::PreventContextMenu;
+    QTest::newRow("defaultContextMenu") << 1 << false << Qt::DefaultContextMenu;
+    QTest::newRow("customContextMenu")  << 1 << true  << Qt::CustomContextMenu;
+    QTest::newRow("preventContextMenu") << 0 << false << Qt::PreventContextMenu;
 }
 
 void tst_QWebEngineView::contextMenu()
 {
     QFETCH(int, childrenCount);
+    QFETCH(bool, isCustomMenu);
     QFETCH(Qt::ContextMenuPolicy, contextMenuPolicy);
 
     QWebEngineView view;
 
+    QMenu *customMenu = nullptr;
     if (contextMenuPolicy == Qt::CustomContextMenu) {
-        connect(&view, &QWebEngineView::customContextMenuRequested, [&view](const QPoint &pt) {
-            QMenu* menu = new QMenu(&view);
-            menu->addAction("Action1");
-            menu->addAction("Action2");
-            menu->popup(pt);
+        connect(&view, &QWebEngineView::customContextMenuRequested, [&view, &customMenu] (const QPoint &pt) {
+            Q_ASSERT(!customMenu);
+            customMenu = new QMenu(&view);
+            customMenu->addAction("Action1");
+            customMenu->addAction("Action2");
+            customMenu->popup(pt);
         });
     }
 
     view.setContextMenuPolicy(contextMenuPolicy);
+
+    // input is supposed to be skipped before first real navigation in >= 79
+    QSignalSpy loadSpy(&view, &QWebEngineView::loadFinished);
+    view.load(QUrl("about:blank"));
     view.resize(640, 480);
     view.show();
+    QTRY_COMPARE(loadSpy.count(), 1);
 
     QVERIFY(view.findChildren<QMenu *>().isEmpty());
     QTest::mouseMove(view.windowHandle(), QPoint(10,10));
     QTest::mouseClick(view.windowHandle(), Qt::RightButton);
-    QTRY_COMPARE(view.findChildren<QMenu *>().count(), childrenCount);
+
+    // verify for zero children will always succeed, so should be tested with at least minor timeout
+    if (childrenCount <= 0) {
+        QVERIFY(!QTest::qWaitFor([&view] () { return view.findChildren<QMenu *>().count() > 0; }, 500));
+    } else {
+        QTRY_COMPARE(view.findChildren<QMenu *>().count(), childrenCount);
+        if (isCustomMenu) {
+            QCOMPARE(view.findChildren<QMenu *>().first(), customMenu);
+        }
+    }
+    QCOMPARE(!!customMenu, isCustomMenu);
 }
 
 void tst_QWebEngineView::mouseLeave()