diff options
| -rw-r--r-- | src/core/web_contents_delegate_qt.cpp | 2 | ||||
| -rw-r--r-- | tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp | 5 |
2 files changed, 7 insertions, 0 deletions
diff --git a/src/core/web_contents_delegate_qt.cpp b/src/core/web_contents_delegate_qt.cpp index e57ee4890..30497e5de 100644 --- a/src/core/web_contents_delegate_qt.cpp +++ b/src/core/web_contents_delegate_qt.cpp @@ -63,6 +63,8 @@ void WebContentsDelegateQt::NavigationStateChanged(const content::WebContents* s { if (changed_flags & content::INVALIDATE_TYPE_URL) m_viewClient->urlChanged(toQt(source->GetVisibleURL())); + if (changed_flags & content::INVALIDATE_TYPE_TITLE) + m_viewClient->titleChanged(toQt(source->GetTitle())); } void WebContentsDelegateQt::AddNewContents(content::WebContents* source, content::WebContents* new_contents, WindowOpenDisposition disposition, const gfx::Rect& initial_pos, bool user_gesture, bool* was_blocked) diff --git a/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp b/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp index 2b5f4101c..f2b11c5c2 100644 --- a/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp +++ b/tests/auto/widgets/qwebenginehistory/tst_qwebenginehistory.cpp @@ -124,10 +124,13 @@ void tst_QWebEngineHistory::count() */ void tst_QWebEngineHistory::back() { + SignalBarrier titleChangedBarrier(page, SIGNAL(titleChanged(const QString&))); + for (int i = histsize;i > 1;i--) { QCOMPARE(toPlainTextSync(page), QString("page") + QString::number(i)); hist->back(); loadFinishedBarrier->ensureSignalEmitted(); + QVERIFY(titleChangedBarrier.ensureSignalEmitted()); } //try one more time (too many). crash test hist->back(); @@ -145,10 +148,12 @@ void tst_QWebEngineHistory::forward() loadFinishedBarrier->ensureSignalEmitted(); } + SignalBarrier titleChangedBarrier(page, SIGNAL(titleChanged(const QString&))); for (int i = 1;i < histsize;i++) { QCOMPARE(toPlainTextSync(page), QString("page") + QString::number(i)); hist->forward(); loadFinishedBarrier->ensureSignalEmitted(); + QVERIFY(titleChangedBarrier.ensureSignalEmitted()); } //try one more time (too many). crash test hist->forward(); |