2 files changed, 17 insertions, 6 deletions
diff --git a/src/webenginewidgets/api/qwebenginedownloaditem.cpp b/src/webenginewidgets/api/qwebenginedownloaditem.cpp
index 55d4fcca8..f0f0958a5 100644
--- a/src/webenginewidgets/api/qwebenginedownloaditem.cpp
+++ b/src/webenginewidgets/api/qwebenginedownloaditem.cpp
@@ -197,11 +197,8 @@ void QWebEngineDownloadItemPrivate::update(const ProfileAdapterClient::DownloadI
         Q_EMIT q->downloadProgress(receivedBytes, totalBytes);
     }
 
-    if (info.done != downloadFinished) {
-        downloadFinished = info.done;
-        if (downloadFinished)
-            Q_EMIT q->finished();
-    }
+    if (info.done)
+        setFinished();
 
     if (downloadPaused != info.paused) {
         downloadPaused = info.paused;
@@ -209,6 +206,15 @@ void QWebEngineDownloadItemPrivate::update(const ProfileAdapterClient::DownloadI
     }
 }
 
+void QWebEngineDownloadItemPrivate::setFinished()
+{
+    if (downloadFinished)
+        return;
+
+    downloadFinished = true;
+    Q_EMIT q_ptr->finished();
+}
+
 /*!
     Accepts the current download request, which will start the download.
 
@@ -262,6 +268,7 @@ void QWebEngineDownloadItem::cancel()
     } else {
         d->downloadState = QWebEngineDownloadItem::DownloadCancelled;
         Q_EMIT stateChanged(d->downloadState);
+        d->setFinished();
     }
 }
 
@@ -653,6 +660,8 @@ QWebEngineDownloadItem::QWebEngineDownloadItem(QWebEngineDownloadItemPrivate *p,
 */
 QWebEngineDownloadItem::~QWebEngineDownloadItem()
 {
+    if (!isFinished())
+        cancel();
     if (auto profileAdapter = d_ptr->profile->profileAdapter())
         profileAdapter->removeDownload(d_ptr->downloadId);
 }
diff --git a/src/webenginewidgets/api/qwebenginedownloaditem_p.h b/src/webenginewidgets/api/qwebenginedownloaditem_p.h
index bdcda5be6..b3bc8a3fe 100644
--- a/src/webenginewidgets/api/qwebenginedownloaditem_p.h
+++ b/src/webenginewidgets/api/qwebenginedownloaditem_p.h
@@ -53,7 +53,7 @@
 
 #include "qtwebenginewidgetsglobal.h"
 
-#include "qwebenginedownloaditem_p.h"
+#include "qwebenginedownloaditem.h"
 #include "qwebengineprofile_p.h"
 #include <QString>
 
@@ -84,6 +84,8 @@ public:
     QWebEnginePage *page;
 
     void update(const QtWebEngineCore::ProfileAdapterClient::DownloadItemInfo &info);
+
+    void setFinished();
 };
 
 QT_END_NAMESPACE