summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Set enumaration root directory for File.webkitRelativePath APIBalazs Egedi2021-05-132-2/+21
| | | | | | Fixes: QTBUG-93304 Change-Id: If2f30aab1c6a6eb81cfbad51318ec31adf5e96b6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix FilePickerController's path validation for windows and corresponding testsPeter Varga2021-05-122-5/+5
| | | | | Change-Id: If2445171232864cb4ac51888ccc93bc00cb099a2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add support for Keyboard.getLayoutMap()Peter Varga2021-05-126-2/+98
| | | | | | | | | | | Pulls in the following changes: Submodule src/3rdparty 6c7b4ffb..1d3b13e9 > 1d3b13e9634 Make clang to inline load/store atomic calls for YieldSortKey struct > f6730fe81a0 Enable XkbKeyboardLayoutEngine::SetCurrentLayoutByName for Qt Fixes: QTBUG-92971 Change-Id: I0c0cddfe4d3e25fd6d3f7e0764b302c300303172 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove ResourceTypeSubFrame check after website updateKirill Burtsev2021-05-111-12/+0
| | | | | | | | | | There are no more sub frame resources under test url, so nothing to check for firstPartyUrl and initiator. Change-Id: I12ddf33ec2909d9a427a9819725d941960575612 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit a282c7a36f8707e0777df201855ef0a8a1980de1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Follow InProcessGpuThread::Init() on thread priorityAllan Sandfeld Jensen2021-05-101-1/+1
| | | | | | | If they use NORMAL, then we should too. Change-Id: I252b4606c692ba483434c126fcda3a7484f399e2 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Avoid unknownFunc messages in qmltestsAllan Sandfeld Jensen2021-05-0721-22/+36
| | | | | | | | | It was caused by a nested unnamed TestCase, instead rely on the parent testCase being id'ed as testCase. Task-number: QTBUG-74447 Change-Id: I086155e230d0e71ce224a8aa4c669636fe0e0acd Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Blacklist CertificateError::test_error for macOSAllan Sandfeld Jensen2021-05-071-0/+2
| | | | | | | | It has failed before but wasn't run by the CI. Task-number: QTBUG-91230 Change-Id: I1f22ddad3bb563cc5c1a02b5bf537dc048954ff2 Reviewed-by: Heikki Halmet <heikki.halmet@qt.io>
* Adapt to new Connections syntaxBalazs Egedi2021-05-061-5/+15
| | | | | | | Change-Id: Ieae71f6b1bad3fd4c4aeeec84112e7528e1af5de Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit f5e1fce9998a3eb1790ddb7c1440b47ab508fdfb) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Remove tracking of frame which load error pageKirill Burtsev2021-05-063-15/+4
| | | | | | | | | | | | | | It was added to suppress progress notification for error page load after failure, but since error page load is reported as a new navigation (which clears list of tracked frames), it was actually doing the opposite thing. The only situation where it suppresses progress is when navigation was not finished (due to invalid domain or network error), but in this case it was real progress change for whole load which should propagate further. Change-Id: Ifd1d681fb5c6495fb3afdc4247364afb4472c959 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Fix inconsistent number of load signals and their orderKirill Burtsev2021-05-0615-173/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | This change tries to match how chromium treats one single load. Before the pair of loadStarted/loadFinished methods for api classes was called on delegate's DidStartNavigation/DidFinishNavigation, which might be many within one single logical load. This is true for multiple usecases (like multiple redirects on load, immediate form submit on DOM load, page's subresource load, or just an error page load on failure). Tracking these methods and deciding when to emit signals based on states are error-prone and complicates logic for no benefits. Also it somewhat lies about when real load is done, which is only started and finished on outer methods DidStartLoading/DidStopLoading, which are conveniently called only once for all mentioned usecases. So, this change uses these methods to issue signals for load start/finish, and only makes exception for error page, which is needed for quick's private test support. Fixes: QTBUG-65223 Fixes: QTBUG-76802 Fixes: QTBUG-87089 Fixes: QTBUG-90342 Fixes: QTBUG-91773 Fixes: QTBUG-92063 Change-Id: I9cc99b639030fedd8cf6a9dc04d0869d6be6357d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Doc: Add a note about navigation within a page to a fragmentKirill Burtsev2021-05-061-0/+6
| | | | | | | Task-number: QTBUG-76802 Change-Id: I38cd148706c0479ffbad1e0d2877adc1cad9038d Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Unblacklist and fix load signals test for file downloadKirill Burtsev2021-05-062-18/+7
| | | | | | | | | | | | Since it's a expected and valid behavior, and it's how chromium sees it. First, after link click, load to different document is started, then navigation is initiated, and only later it's resolved to download and aborted (hence load result is false) with page's state staying the same. Fixes: QTBUG-75185 Change-Id: I8b81ba00609649d9d0318f085ff1749a02a6e3cf Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Add more tests to tst_loadsignalsJüri Valdmann2021-05-069-33/+268
| | | | | | | | | | | | | | Add new cases for non-same-page navigations, for navigations triggered from the DOMContentLoaded event handler, for navigations triggered by user action (clicks), and for navigation rejected by the acceptNavigationRequest API. Drop the 'no more signals' waiting time from 10 to 1 seconds. Task-number: QTBUG-65223 Change-Id: Ic074eaf5aa58f779e31927296ae84d9e4faeaaae Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Remove obsolete loadSignals test secondLoadForError_WhenErrorPageEnabledKirill Burtsev2021-05-062-40/+0
| | | | | | | | | | Was added as is in 89bc70bf13, and was already blacklisted. Mostly duplicates logic of 'loadFinishedAfterNotFoundError' (which was added much earlier in aa8b11d3a5), but with a different expectations for the number of signals emitted. And that was never realized. Change-Id: I97bb539b936361089733dc6f26985c09c7bbc3d1 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Allow leaving OCSP offAllan Sandfeld Jensen2021-05-035-14/+24
| | | | | | | | | | This form of OCSP is not good, so try to at least allow it to be disabled, until we remove it. Fixes: QTBUG-91467 Change-Id: Ied9e8c4960e6ea1503dea39ebbced2ad1af08d5d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Blacklist NewViewRequest::test_loadNewViewRequest on macOSAllan Sandfeld Jensen2021-04-292-1/+2
| | | | | | | Until we have time to investigate why it fails now. Change-Id: I3da35bc622e0691b4d1a1b5138c091ba490292c7 Reviewed-by: Heikki Halmet <heikki.halmet@qt.io>
* Update ChromiumAllan Sandfeld Jensen2021-04-291-0/+0
| | | | | | | | | | | | | | | Submodule src/3rdparty 3f594ea1..6c7b4ffb: > FIXUP: Avoid crashing on new window in cross-origin isolated content > [Backport] Security bug 1198309 > [Backport] CVE-2021-21231: Insufficient data validation in V8 > [Backport] CVE-2021-21230: Type Confusion in V8 > [Backport] CVE-2021-21233: Heap buffer overflow in ANGLE > [Backport] CVE-2021-21227: Insufficient data validation in V8 > Avoid crashing on new window in cross-origin isolated content > Fix build with system ICU 69 Change-Id: Iab339abb1a34ce93e03f64608c6b5c5719f36fce Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Merge remote-tracking branch 'origin/5.15.4' into 5.15Allan Sandfeld Jensen2021-04-273-8/+7
|\ | | | | | | Change-Id: I659eb87245dfd59f014a7ca152c9f261ad400238
| * Update Chromiumv5.15.4-lts-lgplv5.15.4-ltsMichael Brüning2021-04-211-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty dd45b1a1..3f594ea1: > [Backport] Security bug 1155297 (3/3) > [Backport] Security bug 1155297 (2/3) > [Backport] Security bug 1155297 (1/3) > [Backport] Security bug 1192552 > [Backport] CVE-2021-21225: Out of bounds memory access in V8 (2/2) > [Backport] CVE-2021-21225: Out of bounds memory access in V8 (1/2) > [Backport] CVE-2021-21224: Type Confusion in V8 > [Backport] CVE-2021-21223: Integer overflow in Mojo > [Backport] CVE-2021-21222: Heap buffer overflow in V8 Task-number: QTBUG-92895 Change-Id: I9c5c3aa451d8a4cab018e23a6407fd0e1f7a58de Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Update ChromiumMichael Brüning2021-04-211-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty c38ae3ec..dd45b1a1: > [Backport] CVE-2021-21209: Inappropriate implementation in storage (5/5) > [Backport] CVE-2021-21209: Inappropriate implementation in storage (4/5) > [Backport] CVE-2021-21209: Inappropriate implementation in storage (3/5) > [Backport] CVE-2021-21209: Inappropriate implementation in storage (2/5) > [Backport] CVE-2021-21209: Inappropriate implementation in storage (1/5) > [Backport] Security bug 1184441 > [Backport] Security bug 1162424 Task-number: QTBUG-92895 Change-Id: I04217fe2026d0087e4b7bd9bc6d5e8fcb5e25ebd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Update Chromium and adapt PermissionManagerQtMichael Brüning2021-04-203-8/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 6764c29f..c38ae3ec: > [Backport] Security bug 1190525 > [Backport] Security bug 1161759 > [Backport] Security bug 1175503 > [Backport] Security bugs 1175522 and 1181276 > [Backport] CVE-2021-21219: Uninitialized Use in PDFium > [Backport] CVE-2021-21217 and CVE-2021-21218: Uninitialized Use in PDFium > [Backport] CVE-2021-21214: Use after free in Network API > [Backport] CVE-2021-21213: Use after free in WebMIDI > [Backport] CVE-2021-21207: Use after free in IndexedDB > [Backport] CVE-2021-21221: Insufficient validation of untrusted input in Mojo > [Backport] CVE-2021-21204: Use after free in Blink. > [Backport] CVE-2021-21203: Use after free in Blink > [Backport] CVE-2021-21202: Use after free in extensions. > [Backport] CVE-2021-21201: Use after free in permissions Task-number: QTBUG-92895 Change-Id: I7e6f3d443366bb291cab027510f76788c14fc023 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Report server directs in navigation typeAllan Sandfeld Jensen2021-04-194-1/+49
| | | | | | | | | | | | | | | | | | | | | | | | A server redirect might not have been reflected in the navigation type at this point, so also check the is_redirect value. Fixes: QTBUG-92819 Change-Id: I711ef041de69552bc3485c9cf3db68c9e6033d6a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io> (cherry picked from commit b29b245fcb9db741d14180ea7e8dcb3ad2d4f49a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* | Docs: Suggest to use higher DPI for printingSzabolcs David2021-04-212-0/+5
| | | | | | | | | | | | | | | | | | | | | | When printing with the default resolution of QPrinter, rasterized images of pages are just too small to produce sharp result. Documentation of QPrinter also mentions that the default ScreenResolution should only be used for drafts. Change-Id: I5fe93f7985d16b1126cf2bbcb9b4a4ddbdfd21f2 Task-number: QTBUG-92185 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Fix application locales againSzabolcs David2021-04-219-29/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Different countries (with the same language) can have different number formatting and navigator.language should report not only the language, but also the country. Locale normalization often falls back by cutting the country off, because we have common .pak files for countries with the same language. This patch: - Uses the locale resolvation only for concatenating .pak file paths and reports the full locale everywhere else. - Properly sets default ICU locale for JS number formats and prevents l10n_util::GetApplicationLocale() to set it sneakily to some resolved one. - Fixes the crashing --lang command line argument and always prefers its value over QLocale. Task-number: QTBUG-91225 Change-Id: I1c09798abdb523b80f0b7a3d69fa8d7a08c7c09a Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* | Report server directs in navigation typeAllan Sandfeld Jensen2021-04-194-1/+49
|/ | | | | | | | | | | A server redirect might not have been reflected in the navigation type at this point, so also check the is_redirect value. Pick-to: 5.15.4 Fixes: QTBUG-92819 Change-Id: I711ef041de69552bc3485c9cf3db68c9e6033d6a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix first party url for cookie filterTamas Zakor2021-04-157-18/+34
| | | | | | | | | | Stop using SiteForCookies::RepresentativeUrl() if it is used to provide first party url because it returns a truncated URL and our API is expected to return the full url of the first party. Fixes: QTBUG-90231 Change-Id: I628f7f31bfbeaf3de976ae9af1a8fa6408b661c5 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Support devtools close button in QuickNanoBrowserBalazs Egedi2021-04-151-0/+12
| | | | | | Fixes: QTBUG-92376 Change-Id: I8b9e35a75a4edb7f3a0dd858987b0f14993df65d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumMichael Brüning2021-04-141-0/+0
| | | | | | | | | | | | Submodule src/3rdparty d13920f2..048f5e99: > [Backport] CVE-2021-21220: Insufficient validation of untrusted input in V8 for x86_64 > [Backport] CVE-2021-21206: Use after free in Blink > Fix build with no extensions on mac Task-number: QTBUG-92080 Change-Id: I0265d3992ac3ec7fe0f55405daf58d1fc2789b12 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update platform notesAllan Sandfeld Jensen2021-04-141-2/+2
| | | | | Change-Id: Iafdfb3c740ce42119a9891729be1ea0c89249039 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Remove qquickwebengineprofile testMichal Klocek2021-04-122-74/+0
| | | | | | | This test is unused and incomplete. Change-Id: I53a4a1238a61a6da3db584fc560b2d40eba3ec36 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Depend on QCoreApplication::startingUp() for checking existence of appAndy Shaw2021-04-121-2/+1
| | | | | | | | | | | | | When using QtWebView with WebEngine then it will hook the call to QtWebEngine::initialize() to the start up of the application object which means it will output the warning because it already exists. However there is still time at this point to set what is needed because it is still being initialized. So by checking if the application is running (i.e. !startingUp()) then we can be safe in knowing that it is still able to do the initialization. Change-Id: I8c5d8808b4b09e1e7bbf4be52e5efc0786ce1472 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix qmltests::WebEngineViewNavigationHistory auto testsBalazs Egedi2021-04-091-2/+2
| | | | | | | | | | Delete loadProgress zero-check from the tests and clear the history instead. The zero-check was used to guarantee the empty history, but it will not pass if multiple tests are performed. Change-Id: I370a51b5631d8fab99209d6a81c8aedd12d5e4a4 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix embedded PDFs when plugins are disabledSzabolcs David2021-04-087-104/+264
| | | | | | | | | | | | | | | | | | Cover all cases from https://pdfobject.com/static - Plugin placeholder is generally broken: displays garbage and crashes on interaction. Fix it and show when PDFs are included by <embed> or <object> tags. - Do not start an automatical download when the disabled PDF plugin was requested by an iframe. Show a clickable placeholder and let the end-users start it manually. - Remove unused class PluginPlaceholderQt Task-number: QTBUG-76314 Change-Id: I01a0c93ab23f54e4272f5aeb30578de0dcf18932 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix prl files on iosMichal Klocek2021-04-061-4/+4
| | | | | | | | | | | Since 42b5da qtbase supports an installation of 3rdpaty in case of static builds. Depend on 'public' qtbase 3rdparty installed libs. This fixes prl generation by not including build paths. Task-number: QTBUG-91385 Change-Id: Ib0609b2b92d6759aad639154617b45fc2fe96916 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Fix qtpdf static builds on windowsMichal Klocek2021-04-061-1/+10
| | | | | | | | | | | Use correct qt zlib lib in case of windows. Passing qtzlib is actually just done in shake of clarity and proper dependency tracking since qtCore is most likely always a dependency for any user app. Fixes: QTBUG-91476 Change-Id: I20816ebf926472c642847e2611797a6decdeecee Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Fix static build of qml qtpdfMichal Klocek2021-04-061-2/+2
| | | | | | | | | Fix duplicated symbols for category logging between core and qml plugin. Task-number: QTBUG-91476 Change-Id: I532ad35b8b0e8a0b93e51b9b7a7b3a4602fad9b3 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Update ChromiumMichael Brüning2021-04-011-0/+0
| | | | | | | | | | | | | | Submodule update src/3rdparty 8d49f9a2..d13920f2: > [Backport] Security bug 1185482 > [Backport] Security bug 1161847 > [Backport] Security bug 1161379 > [Backport] CVE-2021-21198: Out of bounds read in IPC > [Backport] CVE-2021-21195: Use after free in V8 Task-number: QTBUG-92080 Change-Id: I638a0fa0285d46736cfbf5406874702bd3600580 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Update ChromiumMichael Brüning2021-03-311-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 6ec3297a..9d237e39: > Fixup for: [Backport] Security bug 1062941 > [Backport] CVE-2021-21193: Use after free in Blink > [Backport] CVE-2021-21191: Use after free in WebRTC > [Backport] Security bug 1161048 > [Backport] Security bug 1155710 > [Backport] Security bug 1062941 > [Backport] Security bug 1142712 (2/2) > [Backport] Security bug 1142712 (1/2) > [Backport] Security bug 1146813 (2/2) > [Backport] Security bug 1146813 (1/2) > [Backport] CVE-2021-21166: Object lifecycle issue in audio > [Backport] CVE-2021-21187: Insufficient data validation in URL formatting > [Backport] CVE-2021-21183 and CVE-2021-21184: Inappropriate implementation in performance APIs > [Backport] CVE-2020-27844: Heap buffer overflow in OpenJPEG > Fix crashes when webrtc is not compiled in Task-number: QTBUG-92080 Change-Id: Ifaac3e24a5f0cacb8ba783f453ae30c8ae5e9abf Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Update ChromiumMichael Brüning2021-03-241-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty 302379ca..79f989b8: > Build fix for "[Backport] CVE-2021-21160..." with gcc > [Backport] CVE-2021-21160: Heap buffer overflow in WebAudio > [Backport] CVE-2021-21173: Side-channel information leakage in Network Internals. > [Backport] CVE-2021-21190: Uninitialized Use in PDFium > [Backport] CVE-2021-21188: Use after free in Blink. > [Backport] CVE-2021-21178: Inappropriate implementation in Compositing > [Backport] CVE-2021-21175: Inappropriate implementation in Site isolation > [Backport] CVE-2021-21174: Inappropriate implementation in Referrer. > [Backport] CVE-2021-21172: Insufficient policy enforcement in File System API > [Backport] CVE-2021-21171: Incorrect security UI in TabStrip and Navigation > [Backport] CVE-2021-21169: Out of bounds memory access in V8 (2/2) > [Backport] CVE-2021-21169: Out of bounds memory access in V8 (1/2) > [Backport] CVE-2021-21168: Insufficient policy enforcement in appcache > [Backport] CVE-2021-21165: Object lifecycle issue in audio > [Backport] CVE-2021-21162: Use after free in WebRTC > [Backport] CVE-2021-21179: Use after free in Network Internals > [Backport] Security bug 1175975 > [Backport] Security bug 1167277 > [Backport] Security bug 1180871 > Fix WebRtcLoggingController for QtWebEngine Task-number: QTBUG-92080 Change-Id: I8578ea4a3fe13b9e5a3e6ed01f8fe9d3053353fc Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* View: test signal for deletion of external page set to viewKirill Burtsev2021-03-231-0/+22
| | | | | | | | | Verify that view still gets notification about external page deletion through basic QObject::destroyed Task-number: QTBUG-90509 Change-Id: I5ae19f4184d6bbbfd94efe28a3f00fbb8f6d8a01 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Abort findText also right on explicit navigation requestKirill Burtsev2021-03-231-0/+1
| | | | | | | | | | | | | | Current implementation cancels current findText only when new navigation is accepted (since it may be rejected all together), so it's not guaranteed that user code will not receive completion callback if it arrives after explicit load/setContent/setHtml but before acceptNavigationRequest. For explicit navigation it doesn't make sense to wait until it's accepted, since it's only exposed there just for consistency, and an expectation for findText is that it should be canceled on new navigation. Fixes: QTBUG-61887 Change-Id: Ia2e19df3b5712e6b5426443d1bce6b205e186668 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Notify canGoBack/canGoForward changes based on web actionsJüri Valdmann2021-03-224-3/+56
| | | | | | | | | | | | | | | Before, QQuickWebEngineView's canGoBack/canGoForward change signals are based on urlChanged. But the urlChanged signal may be emitted slightly before the value of canGoBack/canGoForwad actually changes, resulting in a missed change notification. After, they get their own signals, which are forwarded from the QQuickWebEngineAction::enabledChanged signal of the respective web actions. Fixes: QTBUG-91565 Change-Id: Id411eb146c776e2824fd2447660e8857974da32e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add web-ui chrome://net-internalsAllan Sandfeld Jensen2021-03-224-1/+11
| | | | | | | Fixes: QTBUG-91695 Change-Id: Ie00b9bb92b62b97c500d427defbf2a4632ddbeda Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Return to using the default devtools pageAllan Sandfeld Jensen2021-03-151-1/+1
| | | | | | | | This includes the screencast mode that now works. Task-number: QTBUG-85171 Change-Id: I11f6fc11db8066a88880df3277e5613db65ae5a5 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Update ChromiumAllan Sandfeld Jensen2021-03-151-0/+0
| | | | | | | | | | | Submodule src/3rdparty 7c8217b3..302379ca: > Fix multiple include dirs > Revert "Use devtools app for Qt" > Prepare net-internals for QtWebEngine usage Task-number: QTBUG-91799 Change-Id: I527fd06a1f3f142cafb098d93ee3bfc0026984f9 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Update chromiumAllan Sandfeld Jensen2021-03-121-0/+0
| | | | | | | | | | | Submodule src/3rdparty d9d9e606..7c8217b3: > [Backport] Remove mouse wheel handler DCHECK > PDF viewer: Restore createBrowserApi() function > [Backport] CVE-2021-21138: Use after free in DevTools Change-Id: I1190e71d109c98285a57365f8ed1315b50895da1 Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu> Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix normalization of app localesAllan Sandfeld Jensen2021-03-124-11/+40
| | | | | | | | | Use the internal Chromium routine to get the app locale Chromium expects. Fixes: QTBUG-91715 Change-Id: I5042eb066cb6879ad69628959912f2841867b4e8 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Only disconnect QWebEnginePage signals that QWebEngineView connectedMichael Brüning2021-03-111-1/+9
| | | | | | | | | | | | | When the QWebEnginePage changed on a QWebEngineView, all signal connec- tions between the view and the previous page were removed as well, even those that the user connected themself. To prevent unexpected behavior, only disconnect the signals that the view connected to automatically and leave the rest of the connections intact when the page on the view is changed. Fixes: QTBUG-90509 Change-Id: Icac3e3be0b598dec8107e8fffdf7f25dd88a4b71 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Remove ui/snapshot overrides for auraPeter Varga2021-03-101-48/+0
| | | | | | | We do build snapshot_aura.cc (Linux) and ui/snapshot_win.cc (Windows). Change-Id: I8b0459a761b76a411371ea175103bd7e864d6417 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Support zoom-in, zoom-out and cell web cursors on macOSPeter Varga2021-03-082-50/+77
| | | | | | Fixes: QTBUG-53593 Change-Id: Ic330875c3ca3ebe460a166ac815dbf2e052143c2 Reviewed-by: Michael Brüning <michael.bruning@qt.io>