| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I52ace7fa49920c4a7fc0cc77cde680f3bf01cca3
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: Ib501ef75c088425c15aa9a0169a1ec8f70bab161
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I3e4970c3a5b65dfa35b82bfd76a826dc13d0144a
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
| |
Change-Id: Id3279026fcc791a9bd5e3e51a7ba7dd3c4a6930c
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
(cherry picked from commit d002a907b5c1016c166d1df0d027b4f391a7273b)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit e0d15f313e6b9f03bceb39aba85acd9dbc5cbf91)
|
|
|
|
|
| |
Change-Id: I119541c1d54fca8aacead7cdc4584bf1478e3ebb
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I1f0833cea8f17ce0d019981732227be82ed17647
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rhi can decide to run D3D11 with the software rendering
through the software adapter aka "Microsoft Basic Render Driver".
This unfortunately does not work well with ANGLE as it can
use another adapter and sharing resources between
qt and skia can fail.
Try to guess which adapter might be used by rhi support
or rhi backing store support classes and pass luid for ANGLE.
Unfortunately this solution is far from perfect as
it creates QRhi just to check what might be used later,
however the user can select something totally different with
QQuickGraphicsConfiguration.
At lest for now we respect QSG_RHI_PREFER_SOFTWARE_RENDERER
and QT_D3D_ADAPTER_INDEX. Moreover this patch should cover
the case when rhi retrys with DXGI_ADAPTER_FLAG_SOFTWARE adapter
if accelerated adapter fails.
This is just a band aid patch to support windows on vm
and we should come up with better solution.
Fixes: QTBUG-116445
Change-Id: I416dd82d688726ce872dc276570fe455d733a48e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 8cef10f4faa9f2a5982e3cb780100cbc62209b07)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit fd3fd9ea0cb669c29382a473cb6f0e763205a8a7)
|
|
|
|
|
| |
Change-Id: Id019e86d826968be8e50b9ba6945d4bcbd3b1c6d
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use ScopedConnection to avoid "stack-use-after-return" address
sanitizer error.
Also reduce potential wait time in case of failure by waiting
for accepted and finished states individually (same as
tst_QWebEngineDownloadRequest tests).
Fixes: QTBUG-116738
Task-number: QTBUG-56093
Change-Id: I49a60c95a816ae1b4cb6b227501ff81ca9c6f82b
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 9e8964001dcdc4c0dba4501ddcb599b86b5939e9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 7dcdca265f4bf2a979d0ba10c29f5674375d10b7)
|
|
|
|
|
| |
Change-Id: I12c07f35d184a1cdd040e46ca664838147733941
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserAccessibilityInterface is deleted when removing it from the
QAccessibleInterface cache. It is removed from the cache in the
BrowserAccessibilityQt destructor explicitly.
On exit, the QAccessibleInterface cache might be destructed earlier than
the corresponding BrowserAccessibilityQt and deletes all the cached
interfaces. Reset the interface pointer to nullptr to make sure that the
destructor doesn't try to delete an already deleted interface.
Fixes: QTBUG-115753
Change-Id: Ide02a84d2230145a3441d9ade47eaa14af897477
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit a931a1ed782b2069749dd316f51ca1044c21a61a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit b65512cafc2e8da767af2d798c73158a8598ca94)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Submodule src/3rdparty a71ba6ff..14780aaa:
* [Backport] Security bug 1427288 (2/2)
* [Backport] Security bug 1427288 (1/2)
* [Backport] Security bug 1449166
* [Backport] Security bug 1469534
* [Backport] CVE-2023-4909: Inappropriate implementation in Interstitials
* [Backport] CVE-2023-4908: Inappropriate implementation in Picture in Picture
* [Backport] CVE-2023-4902: Inappropriate implementation in Input
Pick-to: dev 6.6
Task-number: QTBUG-117059
Change-Id: I22da560b291cb984fffe1599a5f9845192458107
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Policy in qtwebengine is to use a separate d-pointer to avoid tying
the module build to a particular upstream Qt release.
Change-Id: I0be241ee379663721225484cda22d952942a95fd
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit fa4a418ba62bd7243b1542bee7d1491e6d83b857)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 0fbda774701fca4493657949353c46e59a0ef2bc)
|
|
|
|
|
|
|
|
|
| |
Fixes: QTBUG-115722
Change-Id: I34adbb379c62ea59299eafd97c9ae4754983269c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit 56fa2aa75ad4d7a1e3386405794c43d23666cfbc)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 423bfd1b321813270086f279b24189ff70da1d61)
|
|
|
|
|
|
|
|
|
|
|
|
| |
The \value command in QDoc now supports adding since information
in a bracketed argument. This enables listing new enum values
also in the top-level 'What's New in Qt' documentation.
Task-number: QTBUG-116843
Change-Id: I1cbaefe89b1b2311e10d10c6260d974412ecccbb
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
(cherry picked from commit b05da249eb3346fd6bf50132aaaf5299fbe3a240)
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
This enum value is new in Qt 6.6.
Task-number: QTBUG-116843
Change-Id: Ia2525e7fb7ed51a5bde6b113a839c9e00ca6aff5
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 1e5bdadea48d1c9adb2b82adb3bf926fdc78adbd)
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Submodule src/3rdparty b295bd04..a71ba6ff:
* [Backport] CVE-2023-4863: Heap buffer overflow in WebP
* Bump V8_PATCH_LEVEL
* [Backport] CVE-2023-4762: Type Confusion in V8
* [Backport] CVE-2023-4763: Use after free in Networks
* [Backport] blink::HTMLMediaElement::ShouldReusePlayer: avoid dereferencing a potentally NULL domWindow
* FIXUP: Qt GN integration
* Avoid using libdrm
Fixes: QTBUG-115470
Fixes: QTBUG-116501
Change-Id: Ibeff96e0dca65b42ffe512627eab3c2f0f349c8c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit e4d73afd5464bd7f34063e08aab55e8f6b16aa22)
(cherry picked from commit e763db0fb23ec8c38b3423668da2a3d94a0157cd)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
| |
This is a prerequisite for using QT_PDF_REMOVED_SINCE.
Change-Id: I46adece3ba1ff1a4c95218a1bc731dea05afc1f3
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
(cherry picked from commit 34f93ea4294e2254c95478521fa9886dfed43910)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With the invalid 'width' attribute the input element
defaults to a size that depends on the system (charmap) settings.
It may result in failing tests that depend on the size of the element
e.g. tests that use 'elementCenter'.
Task-number: QTBUG-105342
Change-Id: I508d365fc4240d67d3e2240e8e33495c1de6ee4c
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit 17bafdc301a057ed4b28dc3acc9bd636183683d0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
| |
Change-Id: I2025d77a15eca0b26096344c3f97f91138893378
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
(cherry picked from commit ae82cd21c55eacb940f90c084302db8fd21e198d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
| |
There's already nanobrowser in Application Examples so this removes the
other webengine examples from that category.
Change-Id: I1f6dc7be7cb0ad4b0ac8134eb438ac0a0db7a5d3
Reviewed-by: Tuukka Turunen <tuukka.turunen@qt.io>
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
(cherry picked from commit 8b2d2cd8387808dc589eda9bfbc119cc84ca4633)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
| |
Mention the argument 'url' by name and fix minor language issues.
Change-Id: I85e48c49fa258a2b4172fee6ec732726ad7009ef
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
(cherry picked from commit 80b18a8fdf6bbd0607f6ff876c389ea63b8fdcef)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The API was deprecated in Qt 6.0, so use std::unique_ptr instead.
The QWebEngineUrlRequestInfo's destructor is private, so create
a custom deleter struct which properly deletes the object.
This works, because InterceptedRequest is a friend of
QWebEngineUrlRequestInfo.
Pick-to: 6.5
Change-Id: I69e1b31360ec5ae4b32b6e7f0416b39aecb2f5f9
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
(cherry picked from commit 6bd52dc09c0b4d32833c6ffef690838b2cbc73e7)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I71ce53c62026f472dbd4df07bcf5e23c23f042a3
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f14eddb25ec9604f4e706db1577b8ce07d247c73.
The DRI check was removed from chromium already, remove it
here as well.
Fixes: QTBUG-116839
Change-Id: I5195a4e4a278e3727b80dc5a9ba614b88f4dec3f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit f8d9d32e20a63869bae4729efc6d3a26e9dff5dd)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Do comments from api review:
* use static setDnsMode
* use struct for mode and server templates
* remove QObject
* do not use QScopedPointer
* use the namespace instead of the class
Change-Id: I766626330e4cc190a170fcd6b5e32b1f60ad675c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 09e224c57c085457dbc5c2896aacb868a19c2ce6)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
| |
Amends b8419577eb99c158
Change-Id: Ie60b418be63699cf1ff2baec5d867ccd85536f2b
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
(cherry picked from commit 4efc44c7ef44995cc64dc7c8c25513a2ab210417)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
| |
See QML API review
Change-Id: I8eaba74655cb73bac912a48964d86e647c7a854f
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 1ea6ee7b4bb4eeec144cd5ffe3be5cd398d8ee8b)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I63c9ad1bf9ce84841b4ad76a9669d56c0c38b7c1
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Submodule src/3rdparty b02cdcee..b295bd04:
* FIXUP: Temporary fix for missing macOS 12.3 SDK
* Temporary fix for missing macOS 12.3 SDK
* Fix build with clang
* Disable Windows IME for GPU thread
Task-number: QTBUG-73994
Fixes: QTBUG-116278
Change-Id: I9894f341a82b0c5887d38e9d2597ecc2bde11392
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit 3e900b7a91a07fe356ffa9d5de8189cda93220a8)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
| |
For consistency with other response headers, even if it is going
to be inconsistent with existing request headers.
Change-Id: I9e9c36ac20982d9c833486171fa9944c9059f471
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: Ifaabc4edc7b5def83141ed8c35a605fd6d3b4dda
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This function was introduced in
d1347ebbe99b467799680bb6e3cee81932751df5 as a bugfix for QTBUG-111067.
The patch was also picked to 6.5, which is not really correct, because
we normally guarantee forward BC in patch releases.
Generally, there is no reason to expose this method to the API - we
could just use a lambda internally. Do it now.
Treat the exposed function as internal, and remove it completely
both from the API and the ABI.
Change-Id: I48b93767c341aca58135872f391fc731561b68d4
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit 46531f2cae2d08b9c7e192ac5f657d0a7ad9996c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
| |
Include qpdfdocument.h in the private header instead.
Found during Qt 6.6 API review
Change-Id: Ia8bed2a789fb1cb5fc8a8bd6d67f3c4efbf0cf54
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
(cherry picked from commit 01745f99dddccdd3310ab1679f3a12d2d176a42a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I1490b936536e7e20ada2d32a97bdfdc5ed142c6b
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
| |
To allow duplicate key values and preserve order within multi key
duplicates
Change-Id: I8da0a3441255c9b72256d63f4ede10491c96c2dc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
(cherry picked from commit a6263a5e8d95dad6e3523f87d416a573e0420881)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In QPdfBookmarkModelPrivate::appendChildNode it was not necessary to
call FPDF_LoadPage() just to be able to call FPDF_GetPageHeight():
the BookmarkModel has the QPdfDocument which can do that for it,
using FPDF_GetPageSizeByIndex() instead.
7b8832ca2b84d549c9d374550c3c46b3d4d42a38 added
QQuickPdfDocument::carrierFile() returning a pointer that
QQuickPdfDocument continues to own. QQuickPdfDocument::setSource()
took care of deleting the existing one if we open a different
document, but the destructor did not delete it.
Task-number: QTBUG-114953
Change-Id: Ie8d9cea456cb91d9541deb575dac17db0d367ead
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
(cherry picked from commit 8289e5935c0990a4a97afeb1234296ea00ad8054)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I7ba5c8de5ee89f9c440aebf71bbd292b78a38765
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Submodule src/3rdparty cfa9a71a..b02cdcee:
* [Backport] CVE-2023-4430: Use after free in Vulkan
* [Backport] CVE-2023-4431: Out of bounds memory access in Fonts
* [Backport] CVE-2023-4428: Out of bounds memory access in CSS
* [Backport] CVE-2023-4427: Out of bounds memory access in V8
* [Backport] Security bug 1455619
* [Backport] CVE-2023-4365: Inappropriate implementation in Fullscreen.
* [Backport] CVE-2023-4362: Heap buffer overflow in Mojom IDL
* [Backport] CVE-2023-4358: Use after free in DNS
* [Backport] CVE-2023-4357: Insufficient validation of untrusted input in XML.
* [Backport] CVE-2023-4356: Use after free in Audio
* [Backport] CVE-2023-4355: Out of bounds memory access in V8.
* [Backport] CVE-2023-4354: Heap buffer overflow in Skia
* [Backport] CVE-2023-4353: Heap buffer overflow in ANGLE
* [Backport] CVE-2023-4352: Type Confusion in V8
* [Backport] CVE-2023-4351: Use after free in Network
Task-number: QTBUG-116501
Change-Id: Icd416a6218aac88ab0282233ca8f05267dc8f1f3
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit be9f659309f7d71253699d72b579204b885a6235)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Submodule src/3rdparty 2d71c20d..cfa9a71a:
* Fix for QtWebEngine crash on Windows
* FIXUP: Add minimal webrtcdesktopcapture api for hangout services extension
* FIXUP: Jumbo build
* [Backport] CVE-2023-4078: Inappropriate implementation in Extensions (2/2)
* [Backport] CVE-2023-4077: Insufficient data validation in Extensions (3/3)
* [Backport] CVE-2023-4077 (2/3) and CVE-2023-4078 (1/2)
* [Backport] CVE-2023-4077: Insufficient data validation in Extensions (1/3)
* [Backport] Security bug 1429353 (2/2)
* [Backport] Security bug 1429353 (1/2), dependency for CVE-2023-4077 and CVE-2023-4078
* [Backport] Security bug 1454544
* [Backport] Security bug 1465224
* [Backport] CVE-2023-4070: Type Confusion in V8
* [Backport] CVE-2023-4073: Out of bounds memory access in ANGLE.
* [Backport] CVE-2023-4071: Heap buffer overflow in Visuals
* [Backport] CVE-2023-4076: Use after free in WebRTC
* [Backport] CVE-2023-4074: Use after free in Blink Task Scheduling
* [Backport] CVE-2023-4068: Type Confusion in V8
* [Backport] Security bug 1464680
* [Backport] Security bug 1464682
* FIXUP: Fix build with enable_vulkan=false
Task-number: QTBUG-115470
Fixes: QTBUG-115703
Change-Id: I1478381717e2189f74041c9e3b62751bdd089d45
Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit c4e1822f45a8d6a7941c908e72690fc2a578fef7)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I1ce21cd3ef26c007400a0c7f11b1984cc7192be9
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
| |
It was disabled once, but it disappeared from media switches. The new
place to set this is WebPreferences.
Change-Id: I4562db45d2d32a684266d0cb92523f9db0f4afd7
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 754010362f2af7dbeb9b6fdd3888cd0190d8604a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I9eda248a82866338c8f70f1993776cc03d663cef
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It has been found to not have any real effect, therefore, we remove it
again to not release a non-functional API and create false expectations
in users.
This reverts commits
3f5de5fab74e6c152cdf5d04f3d893feaa31790b
ab21f39c6a54be331dd8a155d3374bfe790e0274 (parts)
082eef1916a86d6d5e0c751d271c7c8a1a5e457d
5e257fb57a211f95556ec387fe6f262a60cbb6fe
Task-number: QTBUG-61071
Change-Id: Ifb33e32128e77dfffed863a1a7501ba21796692d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 614c78c6385f6503dce597407c30fb63fa1de451)
|
|
|
|
|
| |
Change-Id: I02d1957082caab27459db998bc6f3ecc6aa8b514
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Yes, the class needs to inherit from QSpinBox in order to override the
protected virtuals, but that doesn't mean a QPdfPageSelector should
model is-a QSpinBox. E.g. the range of the QPdfPageSelector is taken
from the QPdfDocument, and no good can come from a user changing it
through the use of QSpinBox API, esp. if one thinks about the class
being displayed as a native widget in QtDesigner.
In a similar vein, the inheritance from QSpinBox leaves users
wondering (and the docs didn't do anything to enlighten them) what
properties are pertinent to the task at hand. setValue() to set the
page index is ... meh, but still somewhat discoverable. But that
text() is only QPdfDocument::pageLabel() if no affixes are set takes
quite some digging.
Part of this could be fixed by providing domain-specific properties
like currentPage for value, but that would just increase the
confusion, because those two properties would must needs exist on the
same object.
Instead, fix by moving the old QPdfPageSelector as
QPdfPageSelectorSpinBox into qpdfpageselector_p.h, removing its pimpl
and having QPdfPageSelector inherit QWidget instead, aggregating a
QPdfPageSelectorSpinBox. This involves a few more objects (the widget,
the layout), but gives QPdfPageSelector full control over its
interface.
Add a few salient properties (more can be added if needed, by copying
them from QSpinBox or QAbstractSpinBox).
Note how well the new API rhymes with QPdfPageNavigator in the
connect() in pdfviewer example's MainWindow.
Since we still store everything in QPdfPageSelectorSpinBox, but don't
pimpl it anymore, QPdfPageSelectorPrivate can lose the q_ptr now, and
merely contains the pointer to its QPdfPageSelectorSpinBox. This
could be optimized further, by making QPdfPageSelectorSpinBox and
QPdfPageSelectorPrivate the same class, but that's neither BC- nor
SC-relevant anymore, and can be done later (or never, seeing as this
widget is unlikely to be used more than a few times per application).
Found in API-review.
As a drive-by, port to the std-compatible subset of the QPointer API.
Change-Id: I0d82d098d38d5f2fcf7f1c8c9aed6e792a8deb2d
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit 8b20e0636a89dc3e6b06d174286ee16aa427887a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's not actually used, ../../touchbrowser/touchmockingapplication.cpp
is.
I actually started editing this file when I noticed that nothing was
changing. Do the next guy a favor and remove this stale file.
Amends c89fcec0bcb65aae737f2dd733790f74e4303114.
Task-number: QTBUG-100417
Change-Id: I4e08db66e62aaa1b7bcbfb61ea060881c16a48f2
Reviewed-by: Martin Negyokru <negyokru@inf.u-szeged.hu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
(cherry picked from commit fbd6a3411fb8e7c64b2f11311f782b508a51f2f4)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
| |
Change-Id: I48dea24021bec98d9f371479472353dcf7ac9535
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The standard guarantees that int is a default type for enum class, so
no need to spell it out explicitly.
Found during Qt 6.6 API review
Change-Id: I4ec4eb443ffe5d54f24ab20ef1de43105a06bb6d
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit bafbe16d60af9bd988c0e4eda1ce8e2367e5ef80)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|
|
|
|
|
|
|
|
|
|
|
| |
This class was marked as deprecated for Qt 6.5, but not everywhere.
This commit amends 8fd7140082e3a752ca80882a29128ffc12d12fa4.
Change-Id: I7253a88aae20519befbabf01e63bb7d49c37cef0
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
(cherry picked from commit ac946f96e1123f2e6ab1ecb883cbebb2d3898b5c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
|