summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove leftover from FaviconDriverQtHEADdevPeter Varga11 hours2-10/+0
| | | | | | | | | | The favicon URL list is unused since the Chromium 94 update, also see the upstream change: https://crrev.com/c/2852141 Pick-to: 6.7 Change-Id: Ief5da417cfaa57439885dd9d56596baba8390dbf Reviewed-by: Anu Aliyas <anu.aliyas@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Make sure to create QOffscreenSurface on the main thread for EGLPeter Varga11 hours5-21/+27
| | | | | | | | | | | | | Also store if dma-buf creation was successful to avoid to switch OpenGL contexts unnecessarily. Pick-to: 6.7 Fixes: QTBUG-124790 Fixes: QTBUG-124635 Change-Id: I14607a3d6317568c43dee9671da78192516b23d5 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 363cf5a13fdfa51d345ca2538daeb37941b5a528) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot3 days1-4/+4
| | | | | Change-Id: Ic2c2b05f5cc6c0f2c721bbc686553ff528f83e75 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Add QWebEngineFrame and basic APIMoss Heim3 days13-0/+535
| | | | | | | | | | | | This object represents a frame on a web page, e.g. a <frame> or <iframe> element. Frames can be found through QWebEnginePage::mainFrame() and findFrameByName(). Also provides some basic getters on QWebEngineFrame and tests. Change-Id: If3905c6ecd14cf6c3508c65edc98f49415739489 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot4 days1-4/+4
| | | | | Change-Id: I43014e9466dd1acf9d96e116a0ed21b2c50daacb Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update simplebrowser example to use onbeforeunloadMoss Heim4 days2-1/+23
| | | | | | | | | | | | | Previously simplebrowser did not make use of the RequestClose webaction to trigger the beforeunload JavaScript event. This meant that closing a tab would not trigger this event or a confirmation dialog, but reloading a tab would. This commit hooks up the appropriate signal in the example code. Fixes: QTBUG-124004 Change-Id: I0a4ce242b6c2f89583504841d817285610be0bd0 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Thread safe implementation of Favicon Quick APIAnu Aliyas6 days6-145/+184
| | | | | | | | | | Ensured thread-safe access to quick classes, by moving all interaction with these classes to UI thread. Removed thread pool and used signals and slots instead Pick-to: 6.7 6.6 Change-Id: Icd5cecf73258fd7da04f56cd5dd5cb83904b8b40 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* Document how to use signal with private typesAllan Sandfeld Jensen6 days1-0/+4
| | | | | | | | | Needed until we make it public in 6.8 Pick-to: 6.7 6.6 Task-number: QTBUG-120370 Change-Id: I6a6aea92d2cc27142fbbc6cb021787daefa68ad0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Speculative fix for flaky DOH testMartin Negyokru7 days2-4/+14
| | | | | | | | Verify network access before running the test. Task-number: QTBUG-124558 Change-Id: Ida7825854074b9c29d5f0b6db6613d4997e450f8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Update PdfPageView code snippetSafiyyah Moosa7 days2-1/+13
| | | | | | | | | | | | The PdfPageView QML Type documentation contains a code snippet. The code snippet should demonstrate how to use the PdfPageView QML type, however it uses the PdfMultiPageView QML type instead. This fix creates a new code snippet that implements the PdfPageView QML type. This snippet replaces the incorrect snippet that was used previously. Fixes: QTBUG-123536 Pick-to: 6.7 Change-Id: I319b4d86133d7dc41664229110a6c13ed46b7e80 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot7 days1-4/+4
| | | | | Change-Id: I52c0aed0ea96b2a857644fe7646eb5a7db3c1c9b Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Add hasPostData to QWebEngineNavigationRequestAllan Sandfeld Jensen10 days11-14/+66
| | | | | | | | | | [ChangeLog][QtWebEngineCore][QWebEngineNavigationRequest] hasFormData has been added to indicate navigations request (re)posting form data. Fixes: QTBUG-67613 Change-Id: I0275513a12d4591a53040c62bfce636e99926ab7 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot11 days1-4/+4
| | | | | Change-Id: I3e0ef48bf02df0cc6f24e3f9cd89faae82dcba7e Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Add the missing _p suffix to the private header files in WebEngineQuick/WidgetsAlexey Edelev11 days13-13/+57
| | | | | | | Pick-to: 6.5 6.6 6.7 Change-Id: I4b64147cb70c3994ed054374c9047fe9274da777 Reviewed-by: Moss Heim <moss.heim@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix IOSurface memory leakPeter Varga12 days4-3/+32
| | | | | | | | | | | | | | | | | | | | IOSurface is reference counted by the OS. Chromium wraps it by gfx::ScopedIOSurface to handle reference counter implicitly. Calling gfx::ScopedIOSurface::release() doesn't decrement the counter just release the ownership, see //base/apple/scoped_typeref.h. Without ownership, gfx::ScopedIOSurface cannot decrement the counter at the end of the scope and IOSurface remains in the memory. As a fix, replace the release() call with get() and let the scoper handle the lifetime of the object. Also release MTLTexture during clean-up because it can also hold reference to the IOSurface. Fixes: QTBUG-124353 Pick-to: 6.7 Change-Id: Idf590b1e48f0c988de8fc71556e99a43749d52e5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Anu Aliyas <anu.aliyas@qt.io>
* Fix synchronization of skImage in NativeSkiaOutputDevicePeter Varga12 days1-2/+6
| | | | | | | | | | | Wait for SkiaImageRepresentation::ScopedReadAccess::CreateSkImage() completion on UI thread. Amends 663ac447476268998fa7f86b03b32115978dfda4 Pick-to: 6.7 Change-Id: I83c47d65f0e4bf911d45f024cb9c7376ba35b6f1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* QWebEnginePage: Add missing NOTIFYKaloyan Chehlarski12 days1-1/+1
| | | | | | | The NOTIFY for the title property was missing. Change-Id: I7320abcdd788af4c46cf6d9da72d69df1c76446f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Replace unnecessary #include in render_view_context_menu_qt.hKaloyan Chehlarski12 days1-1/+1
| | | | | | | | | The file was including web_contents_adapter_client.h but not using it; this is now replaced with the qtwebenginecoreglobal.h include necessary for the Q_WEBENGINECORE_EXPORT macro. Change-Id: I379b27f34081f9b0c9fcafa84ae7a464ff8b0822 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Avoid using -no_warn_duplicate_libraries flag with class linkerAnu Aliyas12 days1-0/+2
| | | | | | | | | | | The classic linker (triggered via -ld_classic) doesn't support the flag -no_warn_duplicate_libraries linker. Opted out from using this flag by setting QT_NO_DISABLE_WARN_DUPLICATE_LIBRARIES to true. Task-number: QTBUG-122655 Pick-to: 6.7 6.6 6.5 Change-Id: Ia0d93666abd6c9bf2a084ffb4df61eab61f972bc Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Second attempt: Skip build for arm64 on WindowsOliver Wolff13 days1-1/+2
| | | | | | Task-number: QTBUG-124632 Change-Id: Iae116b141743cead3fe984ed87eb036ee97e0273 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot14 days1-4/+4
| | | | | Change-Id: I4d6257443b064daa534e93451ef3c65b239d10e8 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Update ChromiumMoss Heim2024-04-221-0/+0
| | | | | | | | | | | | | Submodule src/3rdparty ac780f41b..3f0d09bfb: * Add missing dependencies to avoid compilation errors * Fix sporadic crash during shutdown * Fix sporadic crash during shutdown Pick-to: 6.7 Fixes: QTBUG-124527 Fixes: QTBUG-124375 Change-Id: Ie3b178b3af7b0e903e2a7cd7fc71dfa5fb276d36 Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
* Fix -no-opengl buildPeter Varga2024-04-184-7/+23
| | | | | | Pick-to: 6.7 Change-Id: Ibb6cb75a25f9b6d69ec03bc2c6734a869ab21899 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2024-04-181-4/+4
| | | | | Change-Id: Ib870d12f5edae250a0210a8f3e6f8a605c49849b Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Improve context log and clean up graphics initializationPeter Varga2024-04-171-52/+138
| | | | | | Pick-to: 6.7 Change-Id: I2c7433530a02a1cb37054b6e6e292d2e13ab8184 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Ensure that the correct modifier key is send to the chromiumAnu Aliyas2024-04-171-1/+1
| | | | | | | | | | | | | | | QtWebEngine converts QtKeyEvent to NativeEvent and then forwards it to Chromium. During the conversion, the value of keyEvent->nativeModifiers is passed as the modifier, leading to this issue. Eg: when using the command modifier, nativeModifiers yielded 264 instead of the expected value NSEventModifierFlagCommand, which is 1 << 20. Used QAppleKeyMapper::toCocoaModifiers() to get NSEventModifierFlags from Qt::KeyboardModifiers Fixes: QTBUG-122970 Pick-to: 6.7 Change-Id: I0c9d8df796187a04475fa944bf1cf4ba2a14109b Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Update ChromiumKaloyan Chehlarski2024-04-171-0/+0
| | | | | | | | | | > [Backport] CVE-2024-3516: Heap buffer overflow in ANGLE > [Backport] CVE-2024-3157: Out of bounds write in Compositing > Fix crash in WGL context creation < Fix crash in WGL context creation Change-Id: I076cf3e56e3d2c6f56a38e99209c965a4547616f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix print preview dialog crashes in printme exampleKaloyan Chehlarski2024-04-162-5/+10
| | | | | | | | | | | | | | The example runs a nested event loop while waiting for the printer to return a document. During that event loop, a user was previously free to click on any of the buttons in the print preview dialog, whoich would mess up the internal state and cause a crash. This change adds a filter to that event loop to exclude user input events, and updates the docs to mention the reasoning behind this pattern. Fixes: QTBUG-122916 Pick-to: 6.7 Change-Id: I4d3d336ffa9bd23e036772bd78f6f1e5870ab732 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update ChromiumKaloyan Chehlarski2024-04-161-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | Submodule src/3rdparty da62c2f7a..c60705f47: > Fix crash in WGL context creation > [Backport] Security bug 326349405 > [Backport] CVE-2024-3159: Out of bounds memory access in V8 > [Backport] Security bug 327183408 > [Backport] Security bug 329674887 (2/2) > [Backport] Security bug 329674887 (1/2) > [Backport] CVE-2024-2887: Type Confusion in WebAssembly > [Backport] CVE-2024-2885: Use after free in Dawn > FIXUP: Restore GLX usage > [Backport] Security bug 41495984 > [Backport] Security bug 40066823 > [Backport] CVE-2024-2626: Out of bounds read in Swiftshader (2/2) > [Backport] CVE-2024-2626: Out of bounds read in Swiftshader (1/2) > [Backport] CVE-2024-2625: Object lifecycle issue in V8 > [Backport] Fix crash when printing on Windows debug builds > CVE-2023-7104 Pick-to: 6.7 Change-Id: I0a71b9bb5b4eadf39ce56e4e54e353f88e164ea3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Minor. Add missing target checksMichal Klocek2024-04-122-4/+12
| | | | | | | | | | | | We need to always add target checks as qt-camke can call configure on tests even if webengine is not built. Otherwise it prints more errors than it should. Pick-to: 6.7 6.6 Task-number: QTBUG-120247 Change-Id: I7e9c1ab9640b91addb8ad1b35889771fb3dd9569 Reviewed-by: Moss Heim <moss.heim@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Improve qpa-xcb error messageMichal Klocek2024-04-121-15/+20
| | | | | | | | | | Add quick fix before new qt configure checks are integrated. Make missing ozone x11 libs as a warning in case qt base is compiled with xcb as it is optional. Task-number: QTBUG-120247 Change-Id: I43b280a37b6b580c4f9bb247efc39f4532ea981f Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix failing autotest in tst_qwebenginepageKaloyan Chehlarski2024-04-123-11/+19
| | | | | | | | | | The localFontAccessPermission test was occasionally failing to acquire transient user activation, and thus failing. This change uses an event hander for when a button is pressed, ensuring the activation is acquired. Change-Id: Iddafa92b7a7e8ea415a73dff8685691b6b39fef4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix Quick WebEngine middle mouse button scrollingKaloyan Chehlarski2024-04-111-0/+1
| | | | | | | | | | | | | | In Qt Quick, mouse movement will be sent to WebEngine as a QHoverEvent instead of a QMouseEvent. This change makes sure that when converting a QHoverEvent to a WebMouseEvent, the screen position is set correctly. This, in turn, ensures that Chromium will correctly interpret mouse movement when performing a middle mouse button scroll; instead of immediately jumping to the top left of the page, it will now scroll correctly. Fixes: QTBUG-120131 Change-Id: Ic5cac761974d422bf1f774616e99e5edbf82f4de Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Correct license for examples filesLucie Gérard2024-04-0930-30/+30
| | | | | | | | | | | | | Example takes precedence over build system file type. According to QUIP-18 [1], all examples file should be LicenseRef-Qt-Commercial OR BSD-3-Clause [1]: https://contribute.qt-project.org/quips/18 Pick-to: 6.7 Task-number: QTBUG-121787 Change-Id: I558c6f409a480835d335101577ae633194b0559d Reviewed-by: Kai Köhne <kai.koehne@qt.io>
* Correct license for build system filesLucie Gérard2024-04-096-6/+6
| | | | | | | | | | | | According to QUIP-18 [1], all build system files should be BSD-3-Clause [1]: https://contribute.qt-project.org/quips/18 Pick-to: 6.7 Task-number: QTBUG-121787 Change-Id: I2f13ceaa8eb68b7745cffc66651f892c1fbeeff2 Reviewed-by: Kai Köhne <kai.koehne@qt.io>
* simplebrowser example: Use new theme iconsFriedemann Kleint2024-04-053-7/+14
| | | | | | Pick-to: 6.7 Change-Id: I1fe5fe8620055eec7c7fd4831459b0aa39864f97 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2024-04-051-4/+4
| | | | | Change-Id: I3cb8e301509da7a2ca039caca397611a0d8baa20 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Handle empty uri-list in dropped MIME dataMoss Heim2024-04-022-1/+24
| | | | | | | | | | | Previously WebContentsAdapter assumed that drag-n-drop MIME data with hasUrls() == true would also have a nonempty url list. This is not always the case. Instead, check directly if urls() is nonempty. Pick-to: 6.7 Fixes: QTBUG-123765 Change-Id: I9e2189e3f0223f98bdd8be273adb96cf063f4be3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* PdfLinkModel: if quadpoints available, convert to rectsShawn Rutledge2024-03-261-2/+23
| | | | | | | | | | | | | | | If QPdfLink stored polygons instead of rects, it would make sense to transform each point using QPdfDocumentPrivate::mapPageToView(); but the quadpoints (polygons) in the test.pdf from QTBUG-100630 happen to describe rectangles. This patch successfully does the transform so that they line up with the link text. It doesn't do much good since the links in that PDF are invalid anyway, but presumably links using quadpoints occur in the real world sometimes. Pick-to: 6.7 Task-number: QTBUG-100630 Change-Id: I0cb151dbb30ca73c8f9ed2bcd29508ced05de064 Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
* Use NO_GENERATE_CPP_EXPORTS explicitlyAlexey Edelev2024-03-256-0/+6
| | | | | | | | | | | Use NO_GENERATE_CPP_EXPORTS explicitly for modules that don't need the autogenerated exports header file. Task-number: QTBUG-90492 Change-Id: Ifb068ca6eb404fefe4587346df8c511413f372f5 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Moss Heim <moss.heim@qt.io>
* Get tst_QPdfSearchModel working; check search results in rotated textShawn Rutledge2024-03-235-4/+246
| | | | | | | | | | | | | API has changed since b6dd845ec4a6bfb6b620686681e20d38a2f24101, and this test wasn't included in CMakeLists so we haven't been running it. Now it checks search result rectangle bounds. The new test PDFs are from the pdfium repository https://pdfium.googlesource.com/pdfium and include different kinds of transforms (the Tm command apparently). Pick-to: 6.7 Task-number: QTBUG-120764 Change-Id: I25cf5944dd227dd4d2c70cbbac470d1d0fcc181a Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
* Add test pdfs for tst_QPdfDocumentShawn Rutledge2024-03-221-0/+2
| | | | | Change-Id: I39bba6769b39e4685fbef10e19f0b1956b62208f Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Convert "page" <-> "view" coordinates for PdfSelection and LinkModelShawn Rutledge2024-03-227-40/+361
| | | | | | | | | | | | | | | Use FPDF_PageToDevice() rather than subtracting from page height, in all the remaining places where we were doing that. Also use FPDF_DeviceToPage() to convert coordinates coming from the view, for hit-testing links and for selecting ranges of text. Mark the private utility functions that we're modifying const while we're at it. Pick-to: 6.5 6.6 6.7 Task-number: QTBUG-100630 Fixes: QTBUG-106565 Change-Id: Ide4f73b80888a0e08381c6e4995f69ebeaa2d12f Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
* Add local fonts permission notification to Quick Nano Browser exampleKaloyan Chehlarski2024-03-221-0/+3
| | | | | | | | | This change adds the relevant permission pop-up text to the Quick Nano Browser example for the local font access API. Task-number: QTBUG-121320 Change-Id: I0347f028301fe57cfece7962798398a0dc9978e5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add local fonts permission support to QuickWebEngineViewKaloyan Chehlarski2024-03-224-0/+11
| | | | | | | | | This change hooks up QuickWebEngineView to the newly-enabled local font access API. Task-number: QTBUG-121320 Change-Id: Ib7e093904ea8d834a2282cd265086e501cb392ff Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Convert search result bounds to account for PDF transformsShawn Rutledge2024-03-223-5/+26
| | | | | | | | | | | | | | | As a drive-by, remove unneeded includes. QPdfDocumentPrivate::convertPageRect() will be useful for fixing related bugs. If PDF files can contain arbitrary transforms, and "page coordinates" returned from pdfium functions are not already converted, then it's never ok to just subtract from page height to invert the y's. Pick-to: 6.5 6.6 6.7 Fixes: QTBUG-120764 Change-Id: Iffce528c0c5e66c499e7147078b7b8718f7610ce Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
* PDF multipage example: don't assume http by defaultShawn Rutledge2024-03-211-1/+3
| | | | | | | | | | | | | | | | Avoid doing network operations unless a network-specific scheme is given. In fact, network loading is not supported anyway, so QUrl::fromLocalFile() would be just as good for now. But perhaps we could support network loading eventually; and this approach is not harmful in the example in the meantime. You just get a "file not found" error if you give an http(s) URL on the command line. Pick-to: 6.5 6.7 Fixes: QTBUG-123548 Change-Id: I2364fd99396d4d65df92106e45818166ef2abf2f Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
* Do not use GBM directly for EGLPeter Varga2024-03-214-90/+238
| | | | | | | | | Replace GBM API usage with using dma_buf import/export EGL extensions. Pick-to: 6.7 Change-Id: I0b332f084d1ada8b7ed58472f546b91628b9d771 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Implement NativePixmap support for EGLPeter Varga2024-03-216-31/+234
| | | | | | Pick-to: 6.7 Change-Id: I321d0de7e12902e1ec915983cf1594508ebac883 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Warn about system GBM only on LinuxPeter Varga2024-03-201-1/+1
| | | | | | | | Amends 30ff354d057a2517d928722402a3dabcc63c31ad Pick-to: 6.7 Change-Id: I76a7edab38473aeb4bb432a6be7dcc344798d2ae Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-06 19:42:16 +0000