summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Doc: Bump QtWebEngine import versionKai Koehne2018-03-081-3/+3
| | | | | Change-Id: Ice026456c9dcc1688ef76cf3f556342b7a0a2ecf Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Update ChromiumMichal Klocek2018-03-081-0/+0
| | | | | | | | | | | | | Pulls in following changes: 458ee912 Fix mixing chromium gles2 types with qt defined ones c4241cdf Do not export .gitignore and .gitattributes afbf89d1 [Backport] Add a .gitattributes file to force LF line-endings in .pins files Task-number: QTBUG-66953 Change-Id: Ibc685f3afd84b9d1abbd54d538724facba09aa31 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Avoid use-after-free of ProtocolHandlerRegistryJüri Valdmann2018-03-083-8/+23
| | | | | Change-Id: Ib84a80472a93f53f3675cb8c2db6fa377322b86b Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Rename protocol() to scheme() in QWERPHPermissionRequestJüri Valdmann2018-03-088-16/+16
| | | | | | | | | Scheme refers to a part of a URL. Protocol refers to a formal standard for communication over a network. Therefore scheme is more accurate here, since registerProtocolHandler only defines simple aliases. Change-Id: I71a1511aa92e41c3e3aca4c0403f54af6d91c563 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Move quota and registerProtocolHandler permission classes to coreJüri Valdmann2018-03-0812-152/+72
| | | | | | | | | | | | | | | | | | | | | | | - Move QWebEngineQuotaPermissionRequest and QWebEngineRegisterProtocolHandlerPermissionRequest to QtWebEngineCore. - Delete QQuickWebEngineQuotaPermissionRequest and QQuickWebEngineRegisterProtocolHandlerPermissionRequest. Miscellaneous cleanup: - Mark QWebEngineQuotaPermissionRequest constructors as internal for QDoc. - Remove superfluous Q_DECLARE_METATYPEs (implied by Q_GADGET). - Remove Q_UNREACHABLE from default constructor. For some reason QML seems to default construct an unused temporary object before throwing it away and copy constructing the actual object. This triggers Q_UNREACHABLE. Change-Id: Icf9f4e34996e4c64aec65b734bcb3bbd22b4dc51 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Stabilize WebEngineViewLoadHtml::test_loadProgressAfterLoadHtmlPeter Varga2018-03-081-1/+9
| | | | | | | | | | | The previous test will set the webEngineView.loadProgress to 100 due to a successful load. Therefore, the test can't expect 0 loadProgress at the beginning. Count the loadProgress changes instead of checking the initial value. Change-Id: I8f4727d5b8c7ebf1b7c640e44a9eb3ca5a7fef44 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Fix doc generation for some QWebEnginePage functionsLeena Miettinen2018-03-083-70/+9
| | | | | | | | | Remove #ifdef Q_QDOC defines and fix the command signatures in \fn commands or remove the commands, where possible. Task-number: QTBUG-66709 Change-Id: Ic591b53f0d52c7c938d8651cd6610f31af0cc540 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Doc: Fix documentation build to work with Clang-enabled QDocTopi Reinio2018-03-082-0/+51
| | | | | | | | | | | | | | | | | Since Qt 5.11, QDoc uses Clang to parse C++ code for documentation. As we have a combined documentation project under src/webengine that covers also webenginewidgets, qmake does not pass the full set of include paths required for Clang to parse also webenginewidgets documentation. Fix this by adding the required include paths in qtwebengine.qdocconf, and by using a custom module header, used for doc builds, to pull in also the QtWebEngineWidgets module header which Clang needs. Task-number: QTBUG-66398 Change-Id: I1da547745c0c06762be216ae55724508b5d6a700 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Doc: Fix doc generation for QWebEngineView::findText()Leena Miettinen2018-03-082-16/+1
| | | | | | | | | | Removed the Q_QDOC define for the FunctorOrLambda and removed the documentation for it. Modified the signature in the \fn command for the remaining docs. Task-number: QTBUG-66398 Change-Id: I142df88fa599f1f31f50da50377267d1eea322d4 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Doc: Add code snippet to QWebEngineCookieStore::setCookieFilter() docsLeena Miettinen2018-03-081-1/+12
| | | | | | Task-number: QTBUG-66723 Change-Id: Ic59f2bea41d6f5a4b0a1ca2b27ed7cce79b4a6ce Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Blacklist tst_qwebenginedownloads on macMichal Klocek2018-03-081-0/+4
| | | | | | Task-number: QTBUG-66888 Change-Id: I11a1526bf6478fc5ffb51f208b59cff7d9a37220 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Also blacklist microFocusCoordinates on OS X 10.11Allan Sandfeld Jensen2018-03-081-1/+1
| | | | | | | Also flaky there. Change-Id: I48a5b497de3b7cbbc1a71413db370777d0daa78f Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Remove unused QQuickWebEngineView::setDevicePixelRatioJüri Valdmann2018-03-062-9/+0
| | | | | Change-Id: Ia202d41907bd7e5925f8995a2ca373ffe5ef03e8 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Add ninja icon to simplebrowserMichal Klocek2018-03-063-0/+10
| | | | | | Task-number: QTBUG-65944 Change-Id: Ie30f2088ca3be90a75d3592433f0c6cf56381dde Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Doc: Fix incorrect spelling in qtwebengines_dictionariesKai Koehne2018-03-061-1/+1
| | | | | | | Change-Id: I5eeed33591501b7218bca204c78594dd02de1dc7 Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Explicitly use custom margins for printing to pdfMichael Brüning2018-03-065-11/+23
| | | | | | | | | | | | | | | 3cec2ccb0ffdd41a41ab55d4c1ba88d4866e71d1 introduced a regression because it was assumed that the page was only printed to pdf when a filename was given. This is not the case when the pdf data is handed to the callback, though. Correct this by explicitly stating when margins should be used. Task-number: QTBUG-66654 Change-Id: I663f578ff5d01c77cc62e6f3756a17f78168a9aa Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Blacklist tst_QWebEngineView::microFocusCoordinates on macOS 10.12Michael Brüning2018-03-061-0/+3
| | | | | | | | | It was failing consistently. Blacklist for now and fix as soon as possible. Task-number: QTBUG-66873 Change-Id: Iab314a3e650e7c20fae3ca74ff2db202c5d5fe7d Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Fix reversed logic for glib dependencyAllan Sandfeld Jensen2018-03-051-1/+1
| | | | | | | We only used if we didn't have it? Change-Id: I56481cce514b7879857cc7fc0b0dc73e615f90d9 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Doc: Link QWebEngineDownloadItem SavePage-related functionsLeena Miettinen2018-03-051-2/+4
| | | | | | | | | Add see-also links between the new 5.11 function, isSavePageDownload(), and the existing related functions. Task-number: QTBUG-66777 Change-Id: I5b135ba2f69213082cd8b516f71c7c5c7124feec Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Doc: Fix docs for QWebEngineCookieStore::setCookieFilter()Leena Miettinen2018-03-052-5/+0
| | | | | | | | | By removing the Q_QDOC define and the \fn command. Required for the Clang doc parser to work. Task-number: QTBUG-66398 Change-Id: I7319e3966382a8f794b2c795f80b88b8129e5b3b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Make cursor position update more reliablePeter Varga2018-03-021-0/+7
| | | | | | | | | | | | | | | This patch makes the cursor position update independent from the order of calling RenderWidgetHostViewQt::OnUpdateTextInputStateCalled() and RenderWidgetHostViewQt::OnTextSelectionChanged(). This fixes the cursor position update after clearing text selection in 65-based Chromium update. From 65-based RenderWidget::WillBeginCompositorFrame() might not be called after text selection changes thus does not trigger an extra TextInputState update which hid this issue with earlier Chromium versions. Change-Id: I80c07e26b66c3a96cb004b9e3ceb57cd99234237 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Document qualified -webengine-proprietary-codecsKai Koehne2018-03-021-1/+1
| | | | | | | | -proprietary-codecs still works, but the more qualified variant is preferred. Change-Id: I17eb023a9c13073f10106cf3e78cf080e97955da Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Fix some QDoc warningsJüri Valdmann2018-03-024-8/+4
| | | | | Change-Id: I1af130982db78184fca763dd61568f350d8a2d42 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Don't percent-encode javascript messagesViktor Engelmann2018-02-261-1/+1
| | | | | | | | Don't percent-encode javascript messages. Task-number: QTBUG-66104 Change-Id: I9ca21cc8f87494b552427724aa6755ddf2620610 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Replace accessibility private API usage with QQmlPropertyv5.11.0-beta1Alexandru Croitor2018-02-221-8/+10
| | | | | | | | | | | | Previously enabling accessibility for the QtQuick WebEngineView was done by calling QuickAccessibleAttached::qmlAttachedProperties() which is a private API call. Instead of that, set the Accessibility attached properties by using QQmlProperty. Task-number: QTBUG-63098 Change-Id: Ibc927c1fce121dee56d8a21af412056d98c82c4d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
* Blacklist mouseMovementProperties test on WindowsAlexandru Croitor2018-02-221-0/+1
| | | | | | Task-number: QTBUG-66527 Change-Id: I2d2c427d5a2e07247222772772ba265e0a153b85 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Expose actual URL for data URLs instead of the virtual URL in the APIPeter Varga2018-02-213-1/+68
| | | | | | | | | | | Chromium considers the actual URL as "scary" therefore prefers to pass a simpler URL via the WebContents::GetVisibleURL() content API function. For data URLs, use the actual URL instead to keep their anchor information. Task-number: QTBUG-64972 Change-Id: I74db3e5dd22a728656a58e50a4e3fba93b82dae2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix webengine-v8-snapshot-support configureAllan Sandfeld Jensen2018-02-211-1/+7
| | | | | | | | | It needs to be checked for all cross builds not just embedded builds, it doesn't need to be checked for 64-bit archictures, and it is helpful to list it in the overview even if we only act on it later. Change-Id: I68c571480186bb9564cb564ca561dfd284f6e231 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fixup merge of downloadType from 5.10.1Allan Sandfeld Jensen2018-02-2111-40/+111
| | | | | | | | | | | | | In 5.11 we deprecated downloadType and at the same time ripped out most of the faulty logic. Later we partially fixed the logic in 5.10.1, but kept the 5.11 version during the merge. This restores the improved logic from 5.10.1, while keeping the property deprecated since it is still misleading at times. Change-Id: I12ee09a2b212506f7ba1a336c9c2e88aa3b1de24 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix embedded-linux -no-opengl buildAllan Sandfeld Jensen2018-02-211-1/+5
| | | | | | Change-Id: Iad7f3f21918fc8727a6fac3733cb6e35f4e1c4b0 Reviewed-by: Karim Pinter <karim.pinter@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Separate argv for QCoreApplication and Chromium in WebEngineProcessKai Koehne2018-02-211-3/+25
| | | | | | | | | | | | | | | | On Linux, Chromium manipulates argv, merging all command line arguments into argv[0] and deleting the other arguments - see set_process_title_linux.cc for the glory details. This potentially confuses QCoreApplication::applicationDirPath(), which assumes that argv[0] contains the binary path. This in turn caused a regression in Qt 5.9.4 where resource files could not be located anymore for QtWebEngineProcess. Avoid this by making two distinct copies of argv already in main(). Task-number: QTBUG-66346 Change-Id: I24d103bb15e77db69faae3bcfc736df25e4ec5d3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Prevent Qt Quick Compiler from removing qrc Javascript source codeAlexandru Croitor2018-02-203-0/+11
| | | | | | | | | | | | | | | | | By default whenever a Qt application is built with Qt Quick compiler, it will scan all qrc resources for javascript files, generate corresponding C++ code, and remove the original JS code. This is problematic for web pages that are loaded in WebEngine because the pages won't be able to access the javascript code, and silently fail (or if you are lucky, you will get some unrelated "can not be found" error). Use the undocumented QtQuick Compiler QTQUICK_COMPILER_SKIPPED_RESOURCES qmake variable to specify that Javascript source code found in qrc files should be left as is. Task-number: QTBUG-66155 Change-Id: Ib1dc744901baddd9e0c17c53db1ffede5c31e544 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
* Add documentation about using Qt Quick Compiler with qrc .js filesAlexandru Croitor2018-02-202-0/+18
| | | | | | | | | | Application developer need to make sure that they skip processing .js files by the Qt Quick Compiler, if the files will be loaded inside HTML pages. Task-number: QTBUG-66155 Change-Id: I09a3c6fa1f31b60a09d30012c6e15ae872bac639 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Merge remote-tracking branch 'origin/5.9' into 5.11Liang Qi2018-02-181-0/+4
|\ | | | | | | | | | | | | Conflicts: .qmake.conf Change-Id: I230e21638604fe75b6f1d6b7877f9bc4b2d2c020
| * Bump versionOswald Buddenhagen2018-02-071-1/+1
| | | | | | | | Change-Id: Idef9a149e21972cfcf48d10b1b5836cd57e801fd
| * Fix crash on accessing WebEngineView properties too earlyPeter Varga2018-02-071-0/+4
| | | | | | | | | | | | | | | | | | | | | | WebContentsAdapter is not created together with the QQuickWebEngineView. Thus querying a view property can lead to a crash if it uses the adapter. This fix adds the missing guards for contentSize and scrollPosition as it is done for similar WebEngineView properties. Task-number: QTBUG-65942 Change-Id: I9c2668a059b08325629f5730608280ba7f3669cf Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | Stabilize tst_QWebEngineDownloads::downloadTwoLinksAllan Sandfeld Jensen2018-02-162-40/+38
| | | | | | | | | | Change-Id: I217fd42c7fa822998ed2e1ebfe952a1f2d505ffc Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Clear HTTP cache before disabling itSzabolcs David2018-02-161-0/+8
| | | | | | | | | | | | | | | | | | | | | | It is a workaround to satisfy this online cache test: http://refreshyourcache.com/en/cache-test/ This way Chromium provides "cache-control: no-cache" headers and indicates the disabled state of our cache backend. Task-number: QTBUG-63606 Change-Id: I0fdaf0b8dcaa98891b3d0380f4deeaa28a8aba4b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge "Merge remote-tracking branch 'origin/5.10' into 5.11" into ↵Allan Sandfeld Jensen2018-02-152-2/+30
|\ \ | | | | | | | | | refs/staging/5.11
| * \ Merge remote-tracking branch 'origin/5.10' into 5.11Allan Sandfeld Jensen2018-02-152-2/+30
| |\ \ | | | | | | | | | | | | Change-Id: I2169baef0a8adb5523d2cfe58896199e967ac1b7
| | * | Add license header5.10Kai Koehne2018-02-061-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add license header to file added in commit f0c5f3306fadc. Change-Id: I4343f74857f8afdca277666a206d08d7a1167bbf Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * | Disable failing developer build tests for QemuSami Nurmenniemi2018-02-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Task-number: QTBUG-63152 Change-Id: I7016195c43ba308153d4748a6f9837f1772e762d Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | | Allow disabling cache of off-the-record profilesAllan Sandfeld Jensen2018-02-153-6/+11
| | | | | | | | | | | | | | | | | | | | Change-Id: Ib319f46465e9f330ef5f2c7a5b2f6a3d50c33c00 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | | Fix linux-clang buildsv5.11.0-alpha1Allan Sandfeld Jensen2018-02-141-1/+2
|/ / / | | | | | | | | | | | | | | | | | | A gn linked with lld doesn't work at all. Change-Id: I488acb65b482cc1348ecd4909b20897e5edb8ef7 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* | | Fix AssertBrowserContextWasntDestroyed DCHECKJüri Valdmann2018-02-131-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | Triggered sometimes in tst_qwebenginedownloads if the memory allocator reuses memory for a BrowserContextQt. Change-Id: Idb2db94cf0a8419dc45c25620708f3f3da8f9ec8 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix undefined reference to qCompare errorJüri Valdmann2018-02-132-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Linking against qtbase 5.9 fails with error: undefined reference to 'bool QTest::qCompare<QString, char [13]>([...])' due to QCOMPARE of QString with C string literal. Change-Id: If4f4312d21d0b1a8ce2577d5f9d3a9ac0731b3a2 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
* | | Fix javascriptCanPaste NOTIFY signalJüri Valdmann2018-02-131-1/+1
| | | | | | | | | | | | | | | Change-Id: Ic3f1e11f42f26e7800524dd88f707200ef3b7705 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Add support for registerProtocolHandlerJüri Valdmann2018-02-1329-0/+685
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extend initialization of URLRequestContextGetterQt to create a content::ProtocolHandlerRegistry for each content::BrowserContext and add the registry's URL request interceptor to the front of the interceptor chain. Implement methods in WebContentsDelegateQt to add/remove protocol handlers to/from the ProtocolHandlerRegistry. Add permission request signal and classes for core, quick and widgets. Add widgets autotest. Add signal handlers to quicknanobrowser and simplebrowser. Task-number: QTBUG-62783 Change-Id: I808e7eb9a1cb4d7216686deed4895de14fe46310 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Register metatype of QWebEngineQuotaPermissionRequestJüri Valdmann2018-02-132-4/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Declare and register metatype for QWebEngineQuotaPermissionRequest. Enables the quotaPermissionRequested signal to be used with queued connections and QSignalSpy. Needs a public default ctor. Task-number: QTBUG-62783 Change-Id: Ibc2b57b1b47a668f7a1f6fe9f591952d5275c7e2 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | QuotaPermissionController: Factor out PermissionControllerJüri Valdmann2018-02-133-28/+88
| | | | | | | | | | | | | | | | | | Task-number: QTBUG-62783 Change-Id: I15fdfe6b0d4e8517b8f5752bd1af5c5a321e9cd0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>