summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Update Chromiumv5.12.1Allan Sandfeld Jensen2019-01-161-0/+0
| | | | | | | | | | | | | Changes: 9aa80f767b Fix jumbo build with GCC 35e15c6001 [Backport] Security bug 880207 4848d71bd9 [Backport] Security bug 881252 and 896326 27c402195e [Backport] Security issue 849942 fec48c17fa FIXUP: [Backport] Security bug 881252 and 896326 Fixes: QTBUG-72612 Change-Id: I27c3214b9491112a0ec576ef4f609534e4eb0e94 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Add changes file for Qt 5.12.1Antti Kokko2019-01-161-0/+78
| | | | | Change-Id: Ic750e5a1668c533b197ef0224dceb747d5b1fde3 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Fix incorrect GLX pbuffer attributes terminatorKirill Burtsev2019-01-091-1/+1
| | | | | | | Reland fix 04337275e4 after adaptations d5bffb5125 Change-Id: Ieca40fd2ac3d245f760c9b24e2d42d21855b836a Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix hide/show of delegate widgetMichal Klocek2019-01-092-0/+24
| | | | | | | | | | For QQuickWidget::show does not work correctly if widget was not hidden. Fixes: QTBUG-72299 Change-Id: I12fba8c18cbf3f847d30de8b057a50e6d9917fde Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Fix recreation of cookie store and channel id serviceMichal Klocek2019-01-093-91/+73
| | | | | | | | | | | | | | | | | | | | | | | | As more things gets mojofy and become services, we can not simply delete parts of storage context. Therefore regenerate whole storage in case of cookie store, cache, agent settings updates. URLRequestContextStorage guards correct order of destruction. This change aims to fix some crashes during cookie store and http cache recreation when ChannelIDService gets deleted. Depending on timing this ends with different stacktraces like in cookie store manager or during ssl handshake. We still keep network delegate outside of storage context to prevent crashes when url requests end their life due to (forced) request cancellation in cancelAllUrlRequests(). Please note this is just band-aid patch, and introduction of 'profile builder' will be a proper fix. Fixes: QTBUG-71895 Change-Id: If33a7af3ebba2632ea33f32d913e1c21a4534817 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge 5.12 into 5.12.1Kari Oikarinen2019-01-0838-87/+593
|\ | | | | | | Change-Id: Ia86d2e001e3575bb4995f5f57b88d6c809246941
| * Rename leftovers of BrowserContext to ProfileAdapterMichal Klocek2019-01-074-10/+10
| | | | | | | | | | Change-Id: Ia86459503be86eb9b0d97affe94b7ce82d5e29f1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Bump versionKari Oikarinen2019-01-071-1/+1
| | | | | | | | Change-Id: Iabf973e3b8eff91244a60ae8b84fd675bd723622
| * Unify input event timestamps among platformsPeter Varga2019-01-041-21/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | Chromium's expected timestamp base is the time when the system was started. QInputEvent::timestamp() returns a timestamp for the actual platform that may differ from the Chromium's standard. Use base::TimeTicks::Now() at the input conversion instead. This may provide less precise but valid timestamp for all cases. Fixes: QTBUG-72654 Change-Id: I2235344a629072c15f7b16c033e13260093de958 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
| * Fix building with clangAllan Sandfeld Jensen2019-01-041-2/+2
| | | | | | | | | | | | | | | | We are doing an assign later, so the properties can't be const, or the default assign operator is automatically deleted. Change-Id: I4ddb46cbde9098ad5c3aa72687c3107da9485a96 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| * Fix QWebEngineUrlRequestInfo::firstPartyUrl() after 69-basedTamas Zakor2019-01-0319-19/+330
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue was introduced by this Chromium change: https://chromium-review.googlesource.com/c/chromium/src/+/1025772/ Add new auto tests for first party url. Depends on Chromium change: d2f5d6869f Add net::URLRequest::first_party_url() Task-number: QTBUG-70790 Change-Id: Ib43bde69990e7fb1d495cc32ac2f6860a613f185 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Lock profile mutex during interceptRequestJüri Valdmann2019-01-024-7/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes setRequestInterceptor take effect atomically, so it's always safe to delete the interceptor after unsetting it from the profile. On the other hand, we run into a deadlock if the user code tries to wait for a profile operation on the UI thread to finish. It seems quite unlikely though that user code would do that and it would probably still be easier for users to understand and debug than the current non-deterministic use-after-free problems. Task-number: QTBUG-72260 Change-Id: I1784a9d9f00029d440508f0bb076d1081a326758 Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
| * Fix key and keyCode of KeyboardEvents for dead keysJüri Valdmann2019-01-021-6/+77
| | | | | | | | | | | | | | | | | | | | | | 1. Extend Qt::Key to ui::DomKey conversion to handle most Qt::Key_Dead_* keys. 2. Supplement Qt::Key to windows key code conversion with a fall back to DomCodeToUsLayoutKeyboardCode. Fixes: QTBUG-72655 Change-Id: I9ab8dc5f931065c4dc381adc5a1690ee288b8244 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| * Fix uniquifying download filenameTamas Zakor2019-01-021-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | The QFileInfo::baseName() can’t be used to split the filename when it contains a dot what is not for extension. Moreover, use timestamps after 100 numerically deduplicated filenames as chrome do: https://chromium-review.googlesource.com/c/1278137 Task-number: QTBUG-66262 Change-Id: Ice548ba2824bd43cf7ad00509b598853087274af Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| * Merge "Merge remote-tracking branch 'origin/5.11' into 5.12" into ↵Liang Qi2018-12-222-4/+76
| |\ | | | | | | | | | refs/staging/5.12
| | * Merge remote-tracking branch 'origin/5.11' into 5.12Liang Qi2018-12-132-4/+76
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: .qmake.conf examples/webenginewidgets/minimal/doc/src/minimal.qdoc Change-Id: I7475770b8a18a69a33601cf88842a7873ba6003c
| | | * Merge remote-tracking branch 'origin/5.11.3' into 5.11Qt Forward Merge Bot2018-12-042-0/+66
| | | |\ | | | | | | | | | | | | | | | Change-Id: I936104c8a28df6079916ffcea755dbc00a648407
| | | | * Add changes file for Qt 5.11.3v5.11.3Antti Kokko2018-11-231-0/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Id4bef9a7bd6a798511f8b8850d27f48f75fbeebd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Kai Koehne <kai.koehne@qt.io>
| | | | * Update ChromiumAllan Sandfeld Jensen2018-11-201-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: 9f4aba1869 FIXUP: Building with plugins but webrtc disabled 37195be7fc [Backport] Fix for CVE-2018-17478 2095a35f30 FIXUP: Building with plugins but webrtc disabled Change-Id: I2a95bb45c8e580246b4c00620045a45aafc635cd Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | | | * Update ChromiumMichael Brüning2018-11-091-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: 33fd7a21ed - [Backport] Fix for CVE-2018-17466 4a6c45c124 - [Backport] Second fix for CVE-2018-12371 cf0481a4fb - [Backport] Fix for security issue 875494 f428bbce2a - [Backport] Fix for security issue 888678 5d514fa9ba - [Backport][Blink/SPv175+] Change DCHECK(chunk clip escaped layer clip) to a DLOG Fixes: QTBUG-71203 Change-Id: I20449b1e688e09313cb96e111f9e356120ba7088 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | | * | Fix documentation of WebEngine Widgets Minimal ExampleKai Koehne2018-11-091-4/+10
| | | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The printing of the source code was broken in commit 0fe0b133b7410. Make sure that the whole source code is printed. Also document the commandLineUrlArgument() function. Task-number: QTBUG-71691 Change-Id: I0044fb6508c712eab91e8d342624df5ea23e2fdc Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
| | | * Merge 5.11 into 5.11.3Oswald Buddenhagen2018-11-091-1/+1
| | | |\ | | | | | | | | | | | | | | | Change-Id: Ibebb21d4948bd720badabe6a176274341098a9a0
| | | | * Bump versionOswald Buddenhagen2018-11-081-1/+1
| | | | | | | | | | | | | | | | | | | | Change-Id: I907509e71cec2c63b9631458fba9ad70907fb422
| | | * | Update ChromiumMichael Brüning2018-11-061-0/+0
| | | |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: 1b6fc616ee - [Backport] Fix for CVE-2018-17462 567960cec4 - [Backport] Update LCMS 39ae61b30a - [Backport] Fix for CVE-2018-17468 ddd25ab971 - [Backport] Fix for CVE-2018-17469 37b5fe3597 - [Backport] Fix for CVE-2018-17470 e467d56363 - [Backport] Fix for CVE-2018-17471 2dcf2c6d0c - [Backport] Fix for CVE-2018-17474 976446bcc0 - [Backport] Fix for CVE-2018-17473 cb98d8cc57 - Build fix for [Backport] Fix for CVE-2018-17470 bc188914f3 - Fixup for fix for CVE-2018-17469 ccb8f3ea6e - Fixup for Fix for CVE-2018-17468 8a39f81276 - [Backport] Fix for CVE-2018-17476 Task-number: QTBUG-71203 Change-Id: I6b698e77272cd762ca40f73c94fa31ce746bd8ff Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| * | | Doc: Fix a broken link to macOS requirementsLeena Miettinen2018-12-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The docs we restructured for 5.12. Change-Id: I0b879bc9fb085d5743a16bc89d405e11f22ca66c Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
| * | | Doc: Add full stop to the end of brief statementLeena Miettinen2018-12-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | To get rid of a QDoc warning. Change-Id: Ib5d25edcf3b7e4a9786dd2056b025757ed5f7beb Reviewed-by: Kai Koehne <kai.koehne@qt.io>
| * | | Document and safeguard usage of custom schemesAlexandru Croitor2018-12-124-6/+60
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The change improves the documentation of QWebEngineUrlSchemeHandler to notify the requirement of registering a custom scheme before installing a custom scheme handler. Also start showing warnings when QWebEngineProfile::installUrlSchemeHandler() is called before a scheme is registered. Also show warnings when installing the handler using QML. Task-number: QTBUG-72079 Change-Id: If249592ea43fe2f9ad587a6ff4e8c9dedcc5d3d3 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Kai Koehne <kai.koehne@qt.io>
| * | use new feature name xkbcommon_evdev -> xkbcommonGatis Paeglis2018-12-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The xkbcommon configure logic was refactored in qtbase/c3a963da1f9e7b1d37e63eedded61da4fbdaaf9a. For more details see the relevant commit. Fixes: QTBUG-72448 Change-Id: I04a5c7f7d0d64eb6a278560f439a585fba259cb4 Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
* | | Update ChormiumMichal Klocek2018-12-211-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following patches: * b3a4dd9 Fix heap overflow when allocating PowerSaveBlocker * 5463947 Fix use-after-scope on reference temporary detected by ASan Change-Id: I1777cb6d25d3364257e79054b1db23a4265ae00a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Update ChromiumMichal Klocek2018-12-201-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in following patches: * 4010e56 Minor. Remove old src version of sqlite * f97a65c [Backport] Update SQLite / Security bug 900910 * 35b62be [Backport] Prepare for sqllite update * 63dee74 [Backport] Security bug 877843 * 0ccf56b [Backport] Security bug 892643 * 2efddba [Backport] Security bug 839250 * 4627bab Add extensions to Qt build and fix it up for building * daa969c [Backport] Security bug 880665 * 04610f2 [Backport] Security bug 879965 * e1fe9e1 [Backport] Security bug 882270 * 7181bb5 [Backport] Security bug 895885 * 0dbd045 [Backpack] CVE-2018-18359 * 0473fab [Backport] CVE-2018-18358 * ed2a611 [Backport] CVE-2018-18357 * 5ee3488 [Backport] CVE-2018-18356 * 5e8a4ea [Backport] CVE-2018-18355 * 7d3f4e6 [Backport] CVE-2018-18350 * e0811d9 [Backport] CVE-2018-18349 * 26dba65 [Backport] CVE-2018-18347 * f0135d4 [Backport] CVE-2018-18345 * 586c41a [Backport] CVE-2018-18343 Fixes: QTBUG-72632 Task-number: QTBUG-72612 Change-Id: I32ddc57529b96e531cf14504fa0978cc8d490a26 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Update ChromiumMichael Brüning2018-12-191-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fbc71baba4 - [Backport] CVE-2018-18342 493c18adef - [Backport] CVE-2018-18341 f5ff8d4a62 - [Backport] CVE-2018-18340 f942ac6b4d - [Backport] CVE-2018-18339 58532117f8 - [Backport] CVE-2018-18338 ef4d1e1ef1 - [Backport] CVE-2018-18337 9a197eab29 - [Backport] CVE-2018-18335 c9155825f4 - [Backport] CVE-2018-17481 7f1f62997f - [Backport] CVE-2018-18336 4a26a08520 - [Backport] Security bug 851821 e63b2a8cb8 - [Backport] CVE-2018-17480 Task-number: QTBUG-72612 Change-Id: I6e970d3527249f1a229a7f3f42dea8886eaa1b6e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix building with -no-opengl on macOSMichael Brüning2018-12-181-1/+1
|/ / | | | | | | | | | | | | | | Based on a patch Dmitriy Kuminov. Change-Id: I5365b16e3b25fcfc5e8be33e6cdcfb85e3e118e4 Fixes: QTBUG-72540 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Disable external text handles and edit menuPeter Varga2018-12-083-4/+4
| | | | | | | | | | | | | | | | | | | | | | Chromium implements its own ones and we don't want to conflict with them. This disables the QtVirtualKeyboard's selection handle what is not functional with QtWebEngine. Task-number: QTBUG-59999 Change-Id: I6a615a04d5eac1ce2d0392d63ba0fc9039583914 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Disable text prediction for inputPeter Varga2018-12-073-4/+4
| | | | | | | | | | | | | | | | | | | | This is a workaround to avoid issues with QtVirtualKeyboard when used with QtWebEngine. Task-number: QTBUG-70158 Task-number: QTBUG-71995 Change-Id: I1e6fcd4dceb131dbe781dd7ab3856cb154ac6a18 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge remote-tracking branch 'origin/5.12.0' into 5.12Qt Forward Merge Bot2018-12-051-1/+1
|\ \ | | | | | | | | | Change-Id: Ib9d391c432e6f7841c9dbc94529b9fb6989b3a00
| * | Fix misleading information in changesv5.12.0-rc2v5.12.0Allan Sandfeld Jensen2018-11-271-1/+1
| | | | | | | | | | | | | | | Change-Id: I8b940140bbbb132e4b4524ac0b205551750a9585 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
| * | Reinstate skipping content/browser for jumbo-buildsv5.12.0-rc1Allan Sandfeld Jensen2018-11-191-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are hitting OOM crashes on the CIs again. Task-number: QTBUG-71870 Change-Id: Ief97b83b26091136acf4988e555b331191ce8271 Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit 24d883d703d3599d6818b6b371ae06dd4ca6f734) Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
* | | Fix missing TransportSecurityPersisterMichal Klocek2018-12-042-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | Commit d603b7055 introduced TrasnsportSecurityPersister, however it did not survive merge form 5.11 to 5.12. Task-number: QTBUG-69605 Change-Id: I6357af25afcfd5c08aae77695bd2131f1cef6b71 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Blacklist failing tst_QQuickWebEngineView tests in openSUSE 15.0Tony Sarajärvi2018-12-042-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | This time we blacklist in the right directory Task-number: QTBUG-71461 Change-Id: If60b128f485b6d1810d759c44275555a5a422525 Reviewed-by: Liang Qi <liang.qi@qt.io>
* | | Fix xscrnsaver detectionAllan Sandfeld Jensen2018-12-031-5/+5
| | | | | | | | | | | | | | | | | | | | | With Ozone use_xscrnsaver defaults to false, so reverse when we set it. Change-Id: I6950f68a693092bf9315e3d8202347adac3c4742 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Update ChromiumAllan Sandfeld Jensen2018-12-011-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes: e67f78ca38 Fix building skcms with intel cc 085b0fd918 Fix compiling zlib without thumb 782b63902d Fix idle detection with X11 Ozone d2f5d6869f Add net::URLRequest::first_party_url() dbafb145af FIXUP: Pass virtual url of data url request back to the UI f98eb4915b Fix bogus check for thumb in zlib bee1c29f64 [Backport] Fix of CVE-2018-17479 (1/2) f365fecfa8 [Backport] Fix of CVE-2018-17479 (2/2) e99d664a35 FIXUP: Switch to use glx over ozone 323b45aa24 FIXUP: Pass virtual url of data url request back to the UI Change-Id: Ic0c5f6fa3e0792032f1c288470bc7f1df1cc15d6 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Reinstate GetQtXDisplayAllan Sandfeld Jensen2018-11-292-2/+8
| | | | | | | | | | | | | | | | | | | | | | | | Is needed by the X11-services with no working Ozone equivalent for runtime detection of X11. Change-Id: Iac79b5e29b9a8ef92af35209f3df40eb91c738f7 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Enable bilinear filtering for software texturesAllan Sandfeld Jensen2018-11-291-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently these will always have a filter value of 0 from Chromium. However fixing it exposes another bug that looks worse, so depend on that being fixed in 5.12.1. Change-Id: I3481a8cc5fa9fb98ae597905d22973ec411a1134 Fixes: QTBUG-71322 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | | Avoid binding loops caused by default context menuSzabolcs David2018-11-292-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a WebEngineAction is tied to a UI element and a context menu request modifies its enabled state, the users get a warning: 'Binding loop detected for property "enabled"' Avoid triggering the action's notifier signal when the default context menu is being built. Change-Id: Ie23087f0b879399cf1cb88c44a42cd0be537a750 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix input method updatePeter Varga2018-11-297-26/+396
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Do the update after the input properties are changed in RenderWidgetHostViewQt. Moreover, always update on input state changes, like cursor position, surrounding text and text selection (see QInputMethod::update() docs). Task-number: QTBUG-70158 Task-number: QTBUG-71995 Change-Id: I9d5c6e299826fbe66f5285b648013ef79aabed9b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Docs: Extend documentation of WebActionsSzabolcs David2018-11-283-17/+31
| | | | | | | | | | | | | | | | | | | | | | | | Add some useful information. Change-Id: I39290c8dfc6c4a1d87c6b24fe6c48cab93f805db Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Document client certificate featureAllan Sandfeld Jensen2018-11-271-0/+18
| | | | | | | | | | | | | | | | | | Change-Id: Id47a763642003f6056f1591e8ba7f82e255cd43e Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Fix use-after-free in URLRequestCustomJobProxy::replyJüri Valdmann2018-11-271-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following operations are executing concurrently on the UI & IO threads: 1. UI thread executes QWebEngineUrlRequestJob::reply --> PostTask(IO, URLRequestCustomJobProxy::reply). IO thread executes URLRequestCustomJob::Kill --> PostTask(UI, URLRequestCustomJobProxy::release). 2. UI thread executes URLRequestCustomJobProxy::release, then deletes the QWebEngineUrlRequestJob and the QIODevice. IO thread executes URLRequestCustomJobProxy::reply and tries to use the QIODevice. Depending on scheduling, the IO thread will try to use the QIODevice after it has been deleted on the UI thread. Change-Id: I7a9793a7492a493e1787e7ee6d0058c0d1aa00ac Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Fix IME with negative start positionPeter Varga2018-11-222-8/+45
| | | | | | | | | | | | | | | Change-Id: I64a39975788cc40c5e0595c1a0c5db9000889bfd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix emulated touch eventsAllan Sandfeld Jensen2018-11-222-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | Touch events now does hit-testing based on surface, so we need to register outselves as a surface to have touch events do anything. Fixes: QTBUG-71801 Change-Id: Iafd43dfcecf029f9c11e0c0c58a349ff38badbaa Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>