summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| | * Make linker call look great againMichal Klocek2019-05-274-11/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix issues with messed up linker path: * do not use LIBS_PRIVATE on linux at least for passing object and archive responses files. * do not use QT and QT_PRIVATE with same libs, it simply includes libs in LIB and LIB_PRIVATE so doubles linker libs. * remove bogus dependency for gui and core for webengineheaders pseudo module. * remove unused egl config flag Fixes: QTBUG-75832 Task-number: QTBUG-75357 Change-Id: I1720394e636e3f89d546f372b10932dd4ad395fe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit ee12b53eba009e8a3ca12ef77031d9a48c609cb4) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * Fix linker too long argument listMichal Klocek2019-05-271-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For yocto builds linker can get quite long path since all archives are listed as absolute paths. This can end up as "execvp: /bin/sh: Argument list too long" Use rsp files also for archives. Change-Id: I096e2f35ed72b68261bf465e84baddd1f78cd917 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 546c42e42643a209d893d5291c26c3f8ef7102a3) Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * Bump versionFrederik Gladhorn2019-05-231-1/+1
| | | | | | | | | | | | Change-Id: I2e0a1e8912cb236e89f97f009411b94103b0ff64
* | | Doc: Improve documentation for QWebEngineView::setHtml()Leena Miettinen2019-06-072-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...and QWebEngineView::setContent()and WebEngineView.loadHtml() The baseUrl cannot be empty. Fixes: QTBUG-75760 Change-Id: If276767ed6a7a9421292299e0ac79d02bbbca0e3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | | Add a close button and ensure text height fitting in tabs for quicknanobrowserLeander Beernaert2019-06-071-6/+56
|/ / | | | | | | | | | | | | | | | | | | | | | | Ensure the text can be correctly displayed vertically by reserving some height and add a close button via a custom tabview style. This change aloso fixes the case where all tabs are closed and new one can't be created using the ctrl+t short cut. Fixes: QTBUG-75291 Change-Id: I139bb832119d56d0e0f12f054e924e5d944b91d4 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* / Disable edit actions when content has no focused framePeter Varga2019-05-2715-9/+292
|/ | | | | | | | | Task-number: QTBUG-75505 Change-Id: Ia1329ff554a86e307aa7995e9af1665ea6c5e64c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add path validation for QWebEngineDownloadItem::setPath()Tamas Zakor2019-05-203-0/+146
| | | | | | | | | | | Do not set path if it ends with separator or if it matches with an already existing directory name. Task-number: QTBUG-75566 Change-Id: I4b78b28afe034c7589633c569a4945a36b32008e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix detection of the webengine-arm-thumb featureJoerg Bornemann2019-05-214-12/+19
| | | | | | | | | | | | | | | | Configure tests must run in a clean environment. That's why functions that are defined below the mkspecs directory are discarded during the configure run. As a result, extractCFlag could not be found when running qtConftest_hasThumbFlag. This patch moves extractCFlag to src/core/config/functions.pri. Also, extractCFlag gets a qtwebengine_ prefix to avoid collisions with functions defined in other modules. The alias extractCFlag in functions.prf lets us use the old function within QtWebEngine itself. Fixes: QTBUG-75748 Change-Id: I6be613fbc569d5f7b3c145ef44b9a7be8e2ecb9d Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Referrer HTTP Header no longer ignored when set via RequestInterceptorLeander Beernaert2019-05-203-3/+54
| | | | | | | | | | | Make sure the HTTP referer is properly placed on a request when it's set via the QWebEngineUrlRequestInterceptor. Added test case to catch future incidents. Fixes: QTBUG-60203 Change-Id: Ida2f713a7352c3199fc9f8e15b5d8350d50afdda Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Doc: Add \a commands for WebEngineView signal and method argumentsLeena Miettinen2019-05-151-25/+28
| | | | | | | | To suppress QDoc warnings in the doc snapshot server: http://doc-snapshots.qt.io/qt5-5.13/qdoc-warnings.log Change-Id: I75a54cb584251877e329c22c380ec4ae5f95f2fb Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Update ChromiumJüri Valdmann2019-05-101-0/+0
| | | | | | | | | | | This pulls in the following changes: * 8d400b02 Fix crashes due to pa_context_get_server_info * b439cd9e Link with -latomic on mipsel * 4c061bfd Fix building GN with VS 2019 Change-Id: I26bef10d1ad051d29dd4a809d8c089a157d93ea9 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update docs and test for runJavaScriptJüri Valdmann2019-05-093-0/+22
| | | | | | | Fixes: QTBUG-69567 Change-Id: Icdf5a200f7be1eb7a98cce62848e3a641c49e804 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Q(Quick)WebEngineProfile: Update list of internal schemesJüri Valdmann2019-05-075-64/+84
| | | | | | | | | | | Disallow installing handler for "about" and everything in kStandardURLSchemes of url/url_util.cc. Except for "gopher" which is used in tests. Suppress warning about custom schemes for "gopher" since it's not a custom scheme. Also lowercase the scheme in urlSchemeHandler() and removeUrlSchemeHandler(). Change-Id: I72b06d4fa6433882019405a0d600a593c8971bf1 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Skip qtwebengine for -no-gui build (also in the configure system)Kai Koehne2019-05-061-0/+1
| | | | | | | | This amends 26ac59af2306 Fixes: QTBUG-75465 Change-Id: I22df5dc851f80724a44c028310269289548dacc5 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Do not crash on QWebEnginePagePrivate::releaseProfile()Allan Sandfeld Jensen2019-05-032-5/+28
| | | | | | | | | Deregistering the widget or deleting the view should be able to handle a now missing d_ptr in the old page. Change-Id: Ic843f7bde12776b6aad4fad865ccf14a25695154 Fixes: QTBUG-75547 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Doc: Add notes about delegating navigation requestsLeena Miettinen2019-05-022-5/+22
| | | | | | | | ...by overloading QWebEnginePage::acceptNavigationRequest() Task-number: QTBUG-75185 Change-Id: Ieaf9cacd5dd9259159767edba319191cf93f19ad Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Silence warnings in tst_qwebengineprofileAllan Sandfeld Jensen2019-04-301-0/+20
| | | | | | | Register custom schemes Change-Id: I536a27da8f936e4ea6569e39a8ec6e30e23af03a Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Handle corner case of assigning an implicit page to a new viewAllan Sandfeld Jensen2019-04-302-9/+28
| | | | | | | | Pass the ownership on to the the new view, so it is still handled like an implicit page. Change-Id: I76ad3cb349a492e60e3ad2bdd4aebaabed07bd4f Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Skip qtwebengine for -no-gui buildKai Koehne2019-04-291-0/+4
| | | | | | | Fixes: QTBUG-75465 Change-Id: Iaf8c75d60d00dac3079fcb3f7108e1c3e5ea5245 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* QWebEngineUrlScheme: Prevent registration of standard schemesJüri Valdmann2019-04-291-0/+5
| | | | | Change-Id: I05ef67b81d9b871d38fcc51639b742b2a7b8a387 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Profile test: fix buffer for request job being deleted on main threadKirill Burtsev2019-04-231-2/+1
| | | | | Change-Id: I894946ce7c9dcf4f787c5c928e3737cd80a7dc52 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Simple browser example: create off-the-record profile in a lazy mannerKirill Burtsev2019-04-233-14/+24
| | | | | | | | Do not create multiple profiles immediately on start. Allows to start and run browser with default profile with 'single-process' flag. Change-Id: Idea7da8167152f718a3c2d4086ad4216d8e1b722 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Allow VS 2019 to try to build QtWebEngineAllan Sandfeld Jensen2019-04-181-0/+2
| | | | | | Task-number: QTBUG-75212 Change-Id: I1d1a99d9a5b6684d23e51cf55d384e7dfee6ef2a Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix printing of landscape orientationSzabolcs David2019-04-171-13/+15
| | | | | | | | | | QPageLayout::pageSize() is always defined in portrait orientation. Removing margins without considering the actual orientation was incorrent. Use QPageLayout::paintRect() instead. Task-number: QTBUG-75092 Change-Id: I34c19d3f0587ae21da2d985e3107b6ec673f53d0 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Fix QWebEngineView::setPage not deleting old pageJüri Valdmann2019-04-174-0/+56
| | | | | | | | | | | Also fix QWebEnginePage::setView not deleting old page Also fix wrong page being deleted if it's parented to the view. Fixes: QTBUG-75131 Fixes: QTBUG-75175 Change-Id: Ie4dfb15b3182de7aa3a94cddcac54ea40a86121b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge remote-tracking branch 'origin/5.12.3' into 5.12Qt Forward Merge Bot2019-04-171-0/+79
|\ | | | | | | Change-Id: Ia13b1c71798aa877685dd0ac6c9697a2835a3d5c
| * Add changes file for Qt 5.12.3v5.12.3Antti Kokko2019-04-051-0/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | + f5bad87426599ff52e382aa7e0698a7e4b4b62de Doc: Copy minimal example code into overview page + fd2acd57df7d62490a9a7c1f7b5b60ae50c51ce6 Clarify documentation of QWebEnginePage::title() + 598bfc652edffb047948e01c3c76eb9e0cb7db4e Doc: Always treat \brief as full sentence + 837347e1901086a9757b5aca7e5bbee7b0d8e20e Fix handling of touch icons when it is disabled + 1f77d4709946511b919810354f19875824399096 Fix crash on dynamic_cast in global event filter + 4263778b2cf06dbdba24c7dfe2e54268a50de257 Quicknanobrowser: Hide status bubble properly + 0091ec9046c2c4812dee109fcbfb8372d9435461 Doc: Fix JavaScriptDialogRequest.DialogTypeBeforeUnload enum value + 8600d3d22d86be364a4c29e559dda7990594d0c5 Fix incrementing download ID + ddfa2997939fc4de2993b3e0de2201eca534af61 Fix destruction of qt quick profile after WebEngineContext gets deleted + 56fadb571f32b721d8b99554e6e38692009ec37f Force destruction of webcontent client before profile adapter + 2bf39d83a532a7fa69adc99caafaa523276b03c5 Expose missing translations to lupdate + ac147ec310c71510f8d72d52c3fcec2bfe49b4a4 Fix warning: implicit conversion of NULL constant to 'const int' + eedee8d37bb49239de54011241eaedded5a4c0ce Update Chromium + cbeef3ee920576d668664ca2e0b8a55ae307959a Do not report client redirects as link-clicked + 3efb842be6e2c663b75f2e920fca00dd71da2ce7 Bump version + 01c763c83d0c846164dcb5b69b9343e6ee2ac0b7 Fix tabbing in recipebrowser + c8d11a21c648e87f3560042e1c022f031a6e6519 Fixup focus implementation + 54ac91fd60ba0e84be239cefa1b56a489c420f9e Fix markdown rendering of titles in recipebrowser + 1fe5566c5d494a9a6cea8282c7387b36ef0e4c0b Fix regression in setting background colors + ea65bb32fa988b37d030c3737b8a036f049d1354 Switch to setting 'official build' for non developer builds + 159a1c8da5eb3d105f2fb47d5b15fce8d1010786 Update Chromium + 0d1351132e7b848247fc50343796d22b5dcf1e3b Fix escaped characters in tooltip + dad0cfa3eba01b0dff698f457242f80f6eae4698 Fix style of media audio controls + 1110b9b50e61bf2663e2037ce9e28e74a8943919 Fix timestamp deduplication for Windows Change-Id: I9636039392c9f043885f22aeabb161fc3ce10079 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | Fix resolving relative URLs with custom schemesJüri Valdmann2019-04-162-0/+49
| | | | | | | | | | | | | | | | Pull in 3rdparty patch and add test. Fixes: QTBUG-74864 Change-Id: I5440f58ff55297c2a51f896d43f479404ff6ca2f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Add PrintMe exampleMichal Klocek2019-04-1511-2/+509
| | | | | | | | | | | | | | | | | | This example shows how to do simple printing with print preview. Task-number: QTBUG-53745 Change-Id: I4b1adbb9847b72928a988b5687fb13c84bb987cd Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Take BrowsingDataRemoverDelegateQt instance ownership by ProfileQtKirill Burtsev2019-04-122-1/+5
| | | | | | | | | | | | | | Delegate assumed to be owned and released by BrowserContext instance Change-Id: I1b5dc3ad2ace6f5c40b9f56e7ed7eb6b23b60925 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* | Profile test: fix waiting for load finished signalKirill Burtsev2019-04-111-1/+2
| | | | | | | | | | Change-Id: I797b596b73d62e420592ef9e96601c35ea7ecad6 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* | Run non-MainWorld DocumentCreation scripts even if JS disabledJüri Valdmann2019-04-082-8/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes regression, introduced by the fix for QTBUG-66011, where setting JavascriptEnabled to false stops all scripts from running instead of only MainWorld scripts (as documented). Only the DocumentCreation injection point is affected. The original change which introduced the regression consisted of moving the DocumentCreation injection point from ContentRendererClient::RunScriptsAtDocumentStart to RenderFrameObserver::DidClearWindowObject. The problem of scripts not working on view-source URLs was fixed by this move, but it turns out that the call to DidClearWindowObject happens to be conditional on Document::CanExecuteScripts and this is, of course, false if JS is disabled. Hence the regression. This new patch moves the injection point again to a task launched from RenderFrameObserver::DidCommitProvisionalLoad. DidCommitProvisionalLoad and DidClearWindowObject are both indirectly called from DocumentLoader::InstallNewDocument, however the former is called before the Document is opened and is therefore too early for script execution. As such, the execution is delayed by posting a task which, in theory, should be scheduled very soon after the normal call to DidClearWindowObject. Fixes: QTBUG-74304 Change-Id: Iac8714bcc5651c287b73181811af26996d955af5 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Merge "Merge remote-tracking branch 'origin/5.12.3' into 5.12" into ↵Allan Sandfeld Jensen2019-04-052-4/+4
|\ \ | | | | | | | | | refs/staging/5.12
| * | Merge remote-tracking branch 'origin/5.12.3' into 5.12Allan Sandfeld Jensen2019-04-052-4/+4
| |\| | | | | | | | | | Change-Id: I8a087fefcb9f0f1c750747d29819e53c11984b41
| | * Update ChromiumMichal Klocek2019-04-041-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pulls in security patches: * [Backport] Security bug 933743 * [Backport] Security bug 917608 * [Backport] Security bug 916874 * [Backport] Security bug 914511 Task-number: QTBUG-74445 Change-Id: Id1ad904857e8f8e15208ae80c8c0258e3d8f4faa Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * Update ChromiumMichael Brüning2019-04-012-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also fixes the fact that WebEngine was passing POST data to Chromium even if the request was not a POST request. This triggered an assert in the backported code. 3aaf2ca833c [Backport] Security bug 906739 e4e10461659 [Backport] Security bug 906437 0a717e1dbe9 [Backport] Security bug 913212 c7fa9a16957 [Backport] CVE-2019-5803 ebe1e7068ca [Backport] Dependency for CVE-2019-5802 (1/5) 597dae52a3b [Backport] CVE-2019-5802 (1/5) 64d3770e5e9 [Backport] CVE-2019-5802 (2/5) a34d2fb5dd1 [Backport] CVE-2019-5802 (3/5) 62f25b2d83f [Backport] CVE-2019-5802 (4/5) a63d51633ab [Backport] Dependency for CVE-2019-5802 (5/5) c6d0023bc59 [Backport] CVE-2019-5802 (5/5) f7fcbe53871 [Backport] Security bug 905509 (1/13) 94f1317917f [Backport] Security bug 905509 (2/13) 812a9e68a2c [Backport] Security bug 905509 (3/13) 36c2c5e8b27 [Backport] Security bug 905509 (4/13) 8b01fa3780a [Backport] Security bug 905509 (5/13) 69b772f1e9a [Backport] Security bug 905509 (6/13) f2dfd87785a [Backport] Security bug 905509 (7/13) ec503eae3ed [Backport] Security bug 905509 (8/13) f5a4144a132 [Backport] Security bug 905509 (9/13) 03d8580cf59 [Backport] Security bug 905509 (10/13) 03c4a4ffb98 [Backport] Security bug 905509 (11/13) 700a4af1fb5 [Backport] Security bug 905509 (12/13) 03be3aa656a [Backport] Security bug 917707 269d53ceabd [Backport] Security bug 905509 (13/13) d720564a5ba [Backport] Security bug 938251 85136fedbde [Backport] Security Bug 929088 037efcfdba3 [Backport] Security Bug 931640 1/2 bea83ccee0f [Backport] Security Bug 931640 2/2 dd18af1614f [Backport] Security Bug 924905 e54c1076009 [Backport] Security Bug 919572 258feedf8e1 [Backport] Security Bug 919340 f4f1e852df5 [Backport] CVE-2019-5789 8566ec6cc21 FIXUP: [Backport] Security bug 905509 (3/13) 3d59c5717de FIXUP: [Backport] Security bug 906739 dd6863f4aea FIXUP: [Backport] Security bug 905509 43c92056fab FIXUP: [Backport] CVE-2019-5802 d6d21a17c5a FIXUP: [Backport] Security bug 913212 a4a129005d8 FIXUP: [Backport] Security bug 905509 38a6ae037ee FIXUP: [Backport] Security Bug 924905 d147ad350da FIXUP: [Backport] Security bug 905509 (3/13) Task-number: QTBUG-74445 Change-Id: Ic8d750bc89950c0e020eb43881dbf03328108940 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Normalize download path on WindowsPeter Varga2019-04-051-1/+1
|/ / | | | | | | | | | | | | Task-number: QTBUG-74698 Task-number: QTBUG-74251 Change-Id: I4358feb7fb28b226edb24ed10611e797fcd3c326 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Increase timeout and add some debug info to tst_dialogMichal Klocek2019-04-042-1/+3
| | | | | | | | | | | | Task-number: QTBUG-72113 Change-Id: I9b2dfb360a18995cae9e0e4a98443e796c3d8ad0 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Make tst_dialogs less flakyMichal Klocek2019-04-031-0/+1
| | | | | | | | | | | | | | | | | | Wait to finish javascript execution before opening next dialog. Task-number: QTBUG-72113 Change-Id: I383e3fc3c405a94ddcbd74fe1cc7ab0d81c4e315 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | Doc: Avoid auto-linking the string 'WebEngine' to the QML typeLeena Miettinen2019-04-0136-185/+176
| | | | | | | | | | | | | | | | | | | | Remove the previous workaround (internal \externalpage command) that was used for this purpose, and replace it with a \QWE macro that expands to the string 'Qt \WebEngine'. The backslash in the expanded string instructs QDoc not to attempt auto-linking the word. Change-Id: If4e1c95423fa07479b1af055e4760a890c0ac667 Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* | Improve configure -help outputKai Koehne2019-04-011-1/+2
|/ | | | | | | | Add a newline after the module title, like it is done for other modules. Also call the module "WebEngine", not "Webengine". Change-Id: I78579fb0ab131373212ea302eb5d3e5dd9cc62ca Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix timestamp deduplication for WindowsPeter Varga2019-03-281-2/+9
| | | | | | | | Based on https://chromium-review.googlesource.com/c/chromium/src/+/1432882 Task-number: QTBUG-74764 Change-Id: I74b4711f5146d2d2261487f13ccac702b9aa969e Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix style of media audio controlsAllan Sandfeld Jensen2019-03-261-0/+4
| | | | | | | | | The modern media controls in 69-based were not completely ready, so stay with the legacy media controls until 5.13. Fixes: QTBUG-74484 Change-Id: I06de16d8210341443a10d8c984f1978d373de0d9 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Fix escaped characters in tooltipAllan Sandfeld Jensen2019-03-261-3/+5
| | | | | | | | | Go back to making the tooltip richtext, but set a white-space:pre to keep the tooltip mostly unwrapped. Fixes: QTBUG-74659 Change-Id: I5e30ee0098a608eda969b090355915a75f55405f Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Update ChromiumMichal Klocek2019-03-251-0/+0
| | | | | | | | | | | | | | Pulls in security patches: * [Backport] CVE-2019-5787 * [Backport] Security bug 906652 * [Backport] CVE-2019-5797 * [Backport] Dependency for CVE-2019-5797 2/2 * [Backport] Dependency for CVE-2019-5797 1/2 * [Backport] CVE-2019-5795 Change-Id: I273570d8c5d57e0ce441a6509360d862f2568bab Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Switch to setting 'official build' for non developer buildsAllan Sandfeld Jensen2019-03-234-1/+10
| | | | | | | | | | | Some things controlled by the OFFICIAL_BUILD defined are commented as unsafe to ship in production, so we need that as well. Note that GOOGLE_CHROME and OFFICIAL_BUILD are two different settings, so this just denotes the build as one shipped in production. Change-Id: I1fdcfec7f5c5142dd2bdc5f1d1f9a296a60e5708 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix regression in setting background colorsAllan Sandfeld Jensen2019-03-224-0/+12
| | | | | | | | | This logic was incorrectly stripped out in adaptations for Chromium 68, but is still needed. Fixes: QTBUG-74519 Change-Id: Iefe7aba352bd43148898c1abeea34f4afe354d72 Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
* Fix markdown rendering of titles in recipebrowserAlexandru Croitor2019-03-217-0/+7
| | | | | | | | | | | Apparently not having a newline before each recipe title, prevented the markdown JS renderer from rendering the titles properly, instead the titles wee unformatted and also displayed the = signs. Add the new lines. Change-Id: I8176e8f3029ca2e80114d6555bbb73696ba51509 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fixup focus implementationAllan Sandfeld Jensen2019-03-2110-32/+61
| | | | | | | | | Follow the other implementation and pass TakeFocus to WebContents Delegate, and hook to our UI from there. Also fixes use of Blur instead of LostFocus, which means we now render unfocused more correctly. Change-Id: I34a1882489bc68b9ff36ed5139af0ee8a3a95b79 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Fix tabbing in recipebrowserAllan Sandfeld Jensen2019-03-212-5/+3
| | | | | | Fixes: QTBUG-55146 Change-Id: I034ebb3e65341b5424a24d5a143013d726d55e10 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>