| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Merge the generation of the v8_snapshot toolchain back to being made
in configure_host.pro. This is a lot cleaner and safer against errors,
to make it work however we need to cache the target archicture so that
it is still available with option(host_build) enabled.
Change-Id: Iefed9c97528f8ce338e7a0d4fe5c6884fb4ef4bd
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Calculate movementX/movementY at every turn, not only when
the mouse is in locked state.
Task-number: QTBUG-59127
Change-Id: I362e055e6b5d6f831671604a093434373cedf19a
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
...to display all properties available for the type.
Task-number: QTBUG-59673
Change-Id: I0ee61abefcfbcc229812dc7c3875d16fb279f9e0
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|\
| |
| |
| | |
Change-Id: I8a281e308ec1a6e93dc9756ba6399ca1b50210d8
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Calling QWebEngineHistory::currentItem() before the first item is
inserted, caused a segfault, due to accessing an illegal QList index.
We now delegate the lookup to QWebEngineHistory::itemAt(), which checks
the index first and returns a dummy element in case of an illegal
index.
Task-number: QTBUG-59599
Change-Id: I9cdd2533e33415a7b812c29fff5429eb005020dc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When clicking on a blank link target, the constructor of the
RenderWidgetHostViewQtDelegateWidget instance for the newly created
view is called with the originating QWebEngineView as its parent
and will connect its removeParentBeforeParentDelete slot to the
originating view's destroyed signal.
This leads to the situation where the delegate's parent will be set to
null when the originating view is closed, causing the view to display
only an empty widget with the actual web contents remaining live in
the background.
This patch removes the connection to the old view when initializing
the delegate as a child of the QWebEnginePagePrivate instance. The
addition to the layout updates the parent and child relationship
between the view and the delegate internally.
Task-number: QTBUG-58381
Change-Id: I448380478c2bcfcfbddaee8a35caf46010e57972
Reviewed-by: Florian Bruhin <qt-project.org@the-compiler.org>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| | |
Change-Id: Iae853d4d3ab73306f90d93b62a419d1d440a3259
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The issue has been fixed in the qtwebengine-chromium 55-based branch:
2890c82cbd3a3e66d7062c9d9f4f065f5cc09d9e
This test is based on the corresponding chromium test:
https://codereview.chromium.org/2537773008/patch/1/10002
Change-Id: Ia930c42f2c3337f10fe133a35ffb5b596aa61d9f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Remove now dead GYP related code.
Change-Id: I7d5b8f28f8925e553211dc88acd571b605ffe80d
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I6b8e49913fc73ec3728b5c005fd83d2e573ad4ea
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
This is consistent with what we do for gcc/clang.
Change-Id: Ibda94dbc0c506c4a8053e0e3b2da25fa7dbed3a8
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Texture nodes has an alternative and rarely used way of setting source
rect using uv_top_left and uv_bottom_right. This patch adds support
for it.
Task-number: QTBUG-59407
Change-Id: Ic14c3dbdede6ece07eb3cda2dcfea8e860654ef2
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Extends the matching bitwidth check for v8snaphost builds
to include x86 targets as well.
Task-number: QTBUG-59504
Change-Id: Ieea917b8a2ed92e157d4cdb4cc272c1bd7a5f74d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Rename the platform to make it clear it is not just for eglfs. Fixes
formating, and also removes parts unnecessary for us that original ozone
platforms doesn't use anymore either.
Change-Id: I04e5792e2ced2580ae0cbfe208b4e594af60a09a
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Translate MIPS configuration to GN like we do for GYP
Change-Id: Ieb2534eeb40bdec54d2c986c65c523239c41a355
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Sets the external ozone platform and make sure we don't set bad
QT_LIBDIR defines for libEGL and libGLESv2 when not doing cross builds.
Change-Id: I60eada3c93224a3aa3a105b007d669932516d331
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Use the separate GN toolchain for v8snapshot to match bitwidth of host
and target for that tool.
Task-number: QTBUG-59504
Change-Id: Ic01675a4d4daf4be0327c516195fe87ac16720f2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Samuli Piippo <samuli.piippo@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Change-Id: Ic7768d9b2677ed488d6af05f34942321b670671e
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Do the error message comparison with utf-8 enconding since the localized
error messages are stored in utf-8 format (error_page_strings.grdp).
This also stabilizes the test because it doesn't depend on the encoding
used by the Chromium.
Change-Id: I24addc1c18d5b4325f4c0270e675e02c3f4e0812
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Updates chromium including:
579ba08 Remove dependency on data_use_measure compontent
7172fcd Fix shim headers for vpx
0085696 Fix builds with path containing "+"
aad9dc4 Support linux-clang-libc++ builds
Change-Id: Ic4fa0bea77ee170c55f02efb883d86b3537d9229
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Detect ARM configuration and pass it to GN.
Change-Id: I809db0e096dc8c8785b37990769d4a981b147624
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
It's going to be deprecated.
Change-Id: Iec967478785d327caa846a259fb8eeff18173429
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I6a39d1ec0ffc0394fbb472ab1df2963ed5c69ec7
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Chromium always allows copying to clipboard (even when this is disabled) if it's
resulting from an user interaction.
Change-Id: I0363b892fef6ce015a2f8ae9b89423e1655b516c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Switch to software mode if it was requested with application attributes.
Task-number: QTBUG-59273
Change-Id: Ia48b4587a3cbe3590ee9231375e07d45381bc7b2
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Changes the order of the function declaration to match the original
file chrome/browser/printing/print_view_manager_base.cc.
This should make it easier to compare with updated versions of the
original after updates of Chromium.
Change-Id: I525ca13e865725e7ca143aee3e9d072d4e4dc1d5
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Use the new configure system to control if we are using system opus,
webp and ffmpeg libraries.
Change-Id: I53db66ca1668fc939a51bf7811f967468456b924
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Enables proprietary codecs and using system FFMPEG
Pulls in Chromium changes:
725c4c9 Optionally link with system ffmpeg
Change-Id: Id7b3379c99a709348bf8684f78e44b41169a1e5a
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Use Custom Dialog API instead of Test Support API for testing form
validation messages. Moreover, remove the form validation part from the
Test Support API.
Change-Id: I8ecc80745ddad26f90df413d9a1d04045512af6c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The new handler prints stack trace if the browser process crashes due to
segmentation fault while running QML tests. The solution is based on the
QTestLib signal handler implementation.
Change-Id: I5ccffc92043375fbf6fa5805a4592c61603efb3f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This patch adds the missing QRegExp includes in prevision of
the qtbase include cleanup.
Change-Id: Ic2cfddcd30207944c573096990032f7f7616a2b1
Reviewed-by: André Hartmann <aha_1980@gmx.de>
|
| |
| |
| |
| |
| |
| |
| |
| | |
We must set target_cpu="x86" for 32 bit builds.
Task-number: QTBUG-59334
Change-Id: I2d58045de47c51953c5f8712a175d2ebdcb00e15
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Deriving from this class is not expected.
Change-Id: I75be53358292fbcdc813fc6d48b21362f1cc3f16
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Even though the touched properties don't have Q_PROPERY modifieds or
changed signals, the values can still be changed by internal code.
Change-Id: Idb235dde0466f819b9c78835a8d7ad36092d2623
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Again enable linking with the flags GN calculated for us.
Also fixes a typo that meant we didn't get the link timing flags on
Windows.
Change-Id: Idd46fd65ea7618a9c510fa2c790569f5974aa5ff
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Also updates Chromium pulling in:
eb8da98 Reland: Optionally unbundle libvpx, opus and FLAC
6cdd0a0 Legalize chromium's directory sort
503e84f46 Optionally link with system ICU
e429a99 Fix incorrect dependency on shim headers
Change-Id: If6da022c410ac5de6ab40ab8a800bf547406efb5
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|\ \ |
|
| |\|
| | |
| | |
| | | |
Change-Id: Iff6ab3c287c58d8ec84a1513460bfce5218e8a61
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In WebContentsDelegateQt::RunFileChooser, we get a
content::RenderFrameHost*, to which chromium wants us to pass the
files that were selected. We now store that pointer in the
FilePickerController, so that we can pass the files there in
FilePickerController::filesSelectedInChooser.
The attribute content::WebContents *m_contents is no longer needed
then, because that was only used to obtain the main frame to which
the files were sent (this caused problems when the file input was
inside an iframe - we sent the result to the wrong frame in that
case, so the file input object remained blocked).
Task-number: QTBUG-59168
Change-Id: Ic2fdacb225e5a1a9e46ced6a1e4a9ff428f18a62
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Keeping the same Channel ID Service after changing the cookie store
leads to segmentation fault on https connections, because chromium
tries to reuse resources that have become invalid.
Task-number: QTBUG-58650
Change-Id: I90a32ba8e05567b5ba990d2351c6e22324c89835
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Previously when Airplay was activated and a new QWebEngineView instance
was created, a black area would be rendered inside the view.
This happened because of incompatible OpenGL contexts. The global Qt
OpenGL context could not share its textures with the newly created
"after-airplay" context, due to the contexts being used by different
GPUs (only possible on a MacBook Pro).
The fix is to add the NSSupportsAutomaticGraphicsSwitching option into
the application plist file, which informs macOS that the application
supports usage of dual GPUs, and thus allows sharing of contexts
across GPUs.
Task-number: QTBUG-54053
Change-Id: Ic37fb75f164922bcca6456054174171fa9ba2bfb
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
6f84a09dfb and b2501b0bda in qtdeclarative introduced a synthetic
hover move event being sent once per frame if the item underneath
the mouse is marked as dirty. This triggers a loop when the web
contents changes reacting to mouse move events as the item needs to
be marked dirty to be rerendered.
Ignore hover move events if the position of the mouse has actually not
changed to work around this.
Task-number: QTBUG-58561
Change-Id: Ic7f3c06e7acf5dfeacc95e347bd026233c957556
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Instead of calling deleteLater, just tell close to delete the menu
itself.
Task-number: QTBUG-59080
Change-Id: I3eae382781f813ed3c6f27b78088b94ed1c486dd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Update chromium to include following fixes:
93db3776 Don't schedule wholeSubtreeInvalid sets
42e3484e Allow Service Workers without HTTP headers
589f21d2 Allow using quota management API for non-standard URLsi
015d648e Fix Linux kernel lacking V4L2_CID_POWER_LINE_FREQUENCY_AUTO
675c165d Fix not working pkg-config on some older distros
Change-Id: Idd503d1ceec50483e69d757ce2daf09f9c9c5c54
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In 58467ed1950ee070d0907cbdabb8466aba277305, the window type for dropdown popups
was changed from Qt::ToolTip to Qt:Tool to fix issues when using a
QWebEngineView inside a modal dialog on macOS.
However, this causes a separate window to pop up at least under Linux, so we use
Qt::ToolTip again there.
Task-number: QTBUG-58488
Task-number: QTBUG-58544
Change-Id: I951b91980be89a37ee07b19fca684d13b6098af0
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
In the destructor of QWebEnginePage and QQuickWebEngineView, we
now call adapter->stopFinding() to suppress callbacks that would
cause segmentation faults if a findText request is still active
at that point.
Task-number: QTBUG-58563
Change-Id: I9d5d8407ee6c28cd76bf6ecf0b62808394e151cd
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
During the build of the spellchecker example, the dictionary
conversion tool is executed to convert some dictionaries. The tool
will fail to find the ICU data file because the file is not present
at the Qt install location at examples build time.
The fix is to allow passing the ICU data directory via an environment
variable. Specifically the QtWebEngine build directory which contains
the ICU data file will be passed when the spellchecker example is
built.
Task-number: QTBUG-58451
Change-Id: I6188f0b7aabe8b2e55cd2e0d59553282058c5035
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When dragging something over a WebEngineView we're waiting for the
result of the asynchronous DragTargetDragOver using a RunLoop. The
result will be delivered by a call to updateDragAction.
The RunLoop will call MessagePumpForUIQt::Run which spins a QEventLoop.
The QEventLoop will dispatch more posted QDragMoveEvent objects while
we're handling the current QDragMoveEvent. This triggers a recursion
guard's Q_ASSERT when dragging from a QtQuick item onto a WebEngineView.
When waiting for the DragTargetDragOver result we're not interested in
Qt events. Instead of using a RunLoop, implement a poor man's chromium
event loop and actively wait for updateDragAction being called.
In practice, no more than two iterations of the loop are run until
updateDragAction is called. Therefore the extra CPU and sleep times are
negligible.
Task-number: QTBUG-58920
Change-Id: Icfdf9c680c4c9987ac3dbb41fbc3e1403af0fa9f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Custom texts are not supported anymore in unload dialogs. Fill them
with a better message.
Task-number: QTBUG-58673
Change-Id: I820155452461db90bf1df2ae8a8ec10ee752aab1
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The widgets object hierarchy related to focus goes like this:
QWebEngineView's focus proxy is ->
RenderWidgetHostViewQtDelegateWidget, which has an internal
QQuickRootItem defined by QQuickWidget, and the child of the item is ->
RenderWidgetHostViewQuickItem.
Previously when QWebEngineView::setFocus was called, the focus was set
on the RenderWidgetHostViewQtDelegateWidget and the QQuickRootItem,
but not on the RenderWidgetHostViewQuickItem. This caused for e.g.
an active HTML text input not receiving focus.
Make sure the RenderWidgetHostViewQuickItem is marked to have focus
within its root item, so that if the root item receives active focus,
so will RenderWidgetHostViewQuickItem receive it.
Task-number: QTBUG-58515
Change-Id: I175610e3dfebc03733aefe26c16f47096df8ff5b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|