summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Blacklist flaky test_linkHoveredDoesntEmitRepeated QML testPeter Varga2016-11-221-0/+3
| | | | | | | Task-number: QTBUG-55870 Change-Id: I0d8dc7253e49662d1f73e7ef09d2529c530595b1 Reviewed-by: Milla Pohjanheimo <milla.pohjanheimo@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add support for compiling WebEngine with Clang sanitizer optionsAlexandru Croitor2016-11-222-0/+106
| | | | | | | | | | | | | | This change pipes the already supported Qt sanitize options to Chromium, so the Chromium build system adds the correct compiler sanitizer flags. The change also checks whether the requirements to build a sanitizer enabled Chromium are met (currently works properly on macOS with an Apple clang >= 7.3.1, and on Linux with clang + libc++). Change-Id: Ibab2d5735935ddc92226575fc0e9f5912b807329 Task-number: QTBUG-52656 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove mouse click workaround from test_navigationRequestedPeter Varga2016-11-171-3/+0
| | | | | | | | The issue has been fixed in the quick test framework. Task-number: QTBUG-56223 Change-Id: I101ca4cdd3f741623111d35d13dfcdb35ca85ea3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Build with Qt 5.6Allan Sandfeld Jensen2016-11-173-1/+11
| | | | | | | Make minimal changes so QtWebEngineCore 5.8 still builds with Qt LTR. Change-Id: Iae3ae606b3457a6ca311ae174b3d2a331e9b20bc Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* Update plugin.qmltypes to 1.4Marco Benelli2016-11-161-3/+3
| | | | | Change-Id: I988eead2a65a3aa657864631d1d87b9d9a4f0ab3 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Wait for focus before key press in NewViewRequest::test_jsWindowOpenPeter Varga2016-11-165-45/+23
| | | | | | | | | This patch is intended to fix flaky failure and factors focus related test functions out to TestWebEngineView. Task-number: QTBUG-56540 Change-Id: Id7e17c08a4a9e863389ae991c9cadc00379377db Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add gn build files to take_snapshotMichal Klocek2016-11-161-2/+4
| | | | | Change-Id: I9da4f98c203dcaa41653dc1d00fcd34a1dd66b85 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add faviconbrowser quick manual testPeter Varga2016-11-1511-11/+774
| | | | | Change-Id: I3b6353b5c58d62c968c704b20224ff8ee600a524 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Rename class of tst_QWebEngineAccessibility widget auto testPeter Varga2016-11-151-10/+10
| | | | | Change-Id: I042e1be6f0c29b8dc8e5e409e5ecff71a58d0c64 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Pass correct clang prefix directory to GYPJan Kundrát2016-11-151-1/+4
| | | | | | | | | Previously the prefix was hardcoded to "/usr". Now the current environment clang path is considered instead. Change-Id: I23173bb31591dfb6df7a81a37a58502dd6b12886 Task-number: QTBUG-52656 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Add spellchecker feature to new config systemMichal Klocek2016-11-148-8/+16
| | | | | Change-Id: I35a5c815c9f2b3ebacb5991ba6645641b17db2db Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix compilation warning in corePeter Varga2016-11-141-3/+6
| | | | | | | | Replace deprecated v8::Object::ForceSet by v8::Object::DefineOwnProperty as it is suggested by the V8 API. Change-Id: I8c49999d391149676daf42784b796fa01918874f Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Enable spellcheck test on macOSMichal Klocek2016-11-141-3/+6
| | | | | | Change-Id: I938ca8afb1d98103590a7ac4cbba77610a0eb099 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Make view source working with qrc URLsPeter Varga2016-11-116-12/+28
| | | | | | Task-number: QTBUG-56353 Change-Id: I9c5dc3a6ba4e6b08ecbb4e44d38a53d24010807b Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Merge "Merge remote-tracking branch 'origin/5.7' into 5.8" into refs/staging/5.8Allan Sandfeld Jensen2016-11-1124-99/+151
|\
| * Merge remote-tracking branch 'origin/5.7' into 5.8Liang Qi2016-11-1124-99/+151
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: src/core/content_browser_client_qt.cpp src/core/content_browser_client_qt.h src/core/gl_surface_qt.cpp src/core/print_view_manager_qt.cpp src/core/web_contents_delegate_qt.cpp src/core/web_engine_context.cpp src/webengine/doc/src/qtwebengine-overview.qdoc src/webengine/doc/src/qtwebengine-platform-notes.qdoc src/webenginewidgets/render_widget_host_view_qt_delegate_widget.cpp src/webenginewidgets/webenginewidgets.pro sync.profile Change-Id: I44495f4d899580c882d6b86d68d7f6b77c8e91f6
| | * Fix sites with optional client certificate supportAllan Sandfeld Jensen2016-11-102-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We fail to load pages that supports client certificates because we didn't implement the client certificate selection. This patch makes a small implementation that selects no certificate whenever a client certificate is requested. Task-number: QTBUG-56206 Change-Id: I95394d9664c7e8e4d03d9e63e5043da81e2672a4 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * Make Linux QPA combinations more robustAllan Sandfeld Jensen2016-11-092-24/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use resourceForIntegration to get egldisplay since not all QPA return a egldisplay for context (in particular xcb_egl). Implement EGL fallback for linux desktop builds, to make Wayland work without an X11 server present. Change-Id: Idcead42250fa00a36e50c082711f5618fd213556 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * Merge remote-tracking branch 'origin/5.6' into 5.7Michael Brüning2016-11-092-16/+5
| | |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Needed to update QWebEnginePagePrivate to match modified WebContentsAdapter API in 5.7. Conflicts: src/webenginewidgets/api/qwebenginepage.cpp Change-Id: If3da3b4db9dc27e5d6aae1e31a4e7b45c435697e
| | | * Copy web channel from QWebEnginePage when adopting WebContentsAdapterMichael Brüning2016-11-081-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It used to be just ignored. Task-number: QTBUG-56643 Change-Id: Ife7ac05fce7e93a6eba1ac6e6db1095574c83e42 Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io> Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
| | | * remove dependencies from sync.profileOswald Buddenhagen2016-11-061-16/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | the CI obtains them from the qt5 super repo nowadays. Change-Id: If41f7c5306ca739fd3800cec3f680fa72df2a871 Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@qt.io>
| | * | Do not fail for wayland-eglMichal Klocek2016-11-071-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Client-side buffer integration can be set manually, therefore beside accepting generic wayland plugin accept also wayland-egl. Change-Id: I8269f117f81cf8bb9462bea525cb253727910bc6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * | Merge remote-tracking branch 'origin/5.6' into 5.7Liang Qi2016-11-0411-31/+32
| | |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also apply a4b04e4c on src/webengine/doc/src/qtwebengine-deploying.qdoc, use the macro \macos. Conflicts: src/core/media_capture_devices_dispatcher.cpp src/webengine/doc/src/qtwebengine-deploying.qdoc src/webengine/doc/src/qtwebengine-platform-notes.qdoc Change-Id: Ia6092a56bfe23da7c06f5389718ebbc9b78ef820
| | | * Pepper flash search-path for package adobe-flashpluginViktor Engelmann2016-11-032-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since version 54, the chromium distribution package does not contain the pepper flash plugin anymore. Because of this, the plugin cannot be installed using the Ubuntu package "pepperflashplugin-nonfree" anymore (because the package pulled the plugin from the chromium distribution). The plugin is also contained in the package adobe-flashplugin, which installs the file to /usr/lib/adobe-flashplugin/libpepflashplayer.so. [ChangeLog] Pepper flash is now also searched in /usr/lib/adobe-flashplugin/ Change-Id: I7c135a2eac1628b0d338bbfed07695c9578458e6 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | | * Doc: Change instances of 'OS X' to 'macOS'Topi Reinio2016-10-312-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As of version 10.12 (Sierra), the name of Apple's desktop operating system will be macOS. Change all occurrences where the Mac platform is discussed to use the macro \macos (defined in the documentation configuration in qtbase), except in link targets where QDoc does not expand macros. Change-Id: Icad4e7817d93b9e7b0e1a9a13a8618b3341ab2ba Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
| | | * Allow Pepper Flash to access Media DevicesViktor Engelmann2016-10-281-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Q_UNREACHABLE caused WebEngine to block Pepper Flash from accessing Media Devices such as the WebCam (this rendered http://testwebcam.com unusable for example) Task-number: QTBUG-55017 Change-Id: I7979c9a5690173e86310f7448c78949371fbc909 Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | | * Disable GPU when no shared OpenGL context is availableAllan Sandfeld Jensen2016-10-271-11/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In case an OpenGL context can not be created we can try running in software compositing mode. This should have a much better chance of working as a fallback. Change-Id: Icaab24dde8f4b6c8ea4023cf36b0bb679143166f Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | | * Fix leakage of FilePickerControl objects in QWebEnginePageJoerg Bornemann2016-10-261-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Delete the FilePickerControl object after we're done with it, analog to what the QtQuick UIDelegatesManager does. Change-Id: Id5ef6666c8536b9e5c6877cd522b4c20adae37e5 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | | * Doc: Clarify that font size is in pixelsKai Koehne2016-10-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | Task-number: QTBUG-56645 Change-Id: I16ca76d3a26d0142846b068cc1ba52bee71cf106 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
| | | * Fix IME window placement relative to QWebEngineViewAlexandru Croitor2016-10-142-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The position of the IME window is computed using the widget input item transform. When a regular QWidget gets a focusIn event, the input item transform is recomputed inside the QWidgetPrivate::updateWidgetTransform method. This did not happen for the QWebEngineView, because the focus event is handled internally and not passed down to QWidget::event. Fix consists in calling updateWidgetTransform manually whenever the view receives focus. The other cases when updateWidgetTransform should be called (namely resize and move events) are handled properly by delegating to QWidget::event. Task-number: QTBUG-55634 Change-Id: Ic93662929e169d860f8ca567f1955da4dc45f9fe Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * | Add missing override to initializeEngine in pluginMichal Klocek2016-11-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Task-number: QTBUG-56870 Change-Id: I36338a1a29bc4e82f5c84cfa1ea641b8df3b5f4f Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
| | * | Apply page margins also for PDF printing (backport from 5.8)Michael Brüning2016-10-281-28/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was left out by oversight. Task-number: QTBUG-56710 Change-Id: Ie23229396eb94b949212324fb50022763935d524 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
| | * | Prevent crash with overridden drag 'n drop event handlersJoerg Bornemann2016-10-262-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Suppose the user overrides QWebEngineView::dragEnterEvent without calling the base implementation and without overriding dragLeaveEvent. Then our implementation will notify chromium about the drag leave without having ever seen a drag entering and crash. Only notify chromium about leave/drop/move events if we've notified it about the drag enter before. Also, catch the case where the user overrides dragLeaveEvent without calling the base implementation. Task-number: QTBUG-54896 Change-Id: Ib958040e5fa7ecab86bac9b724d478c81a521fcc Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * | Fix hang when dragging files from file picker onto QWebEngineViewJoerg Bornemann2016-10-262-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The method WebContentsAdapter::updateDragPosition actively waits for the UpdateDragCursor message, sent by the renderer. This active wait does not work whenever we're currently in a base::MessageLoop::RunTask call, because of its internal recursion guard nestable_tasks_allowed. Add a check for nestable_tasks_allowed and bail out if we know that the active wait will fail. This fixes the hang. Ensure that the modal file picker dialog is shown outside of base::MessageLoop::RunTask. This enables drag 'n drop updates from the file picker to QWebEngineView. Task-number: QTBUG-56488 Change-Id: Ia13ada9c19e7780e12ca633ab1caeac352aca2a9 Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io> Reviewed-by: Michael Brüning <michael.bruning@qt.io>
| | * | Forward more load parameters in OpenURLAllan Sandfeld Jensen2016-10-141-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a number of missing load url parameters following the example of the shell and android webviews in Chromium. Change-Id: Ice27ab3efc550b8b7cfa6a5386aaf09574428a56 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
| | * | Give better error on unsupported platformsAllan Sandfeld Jensen2016-10-131-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add check for our supported and semi-supported platforms. Task-number: QTBUG-56465 Change-Id: Ic2f934ceac1b21ab5c688fa67e1c1a74ddf4a43b Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io> Reviewed-by: Kai Koehne <kai.koehne@qt.io>
| | * | Respect command-line flags overriding our embedded defaultsAllan Sandfeld Jensen2016-10-111-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check if the opposite flag has been given by the user before adding our own defaults. Task-number: QTBUG-56432 Change-Id: I7d6b8fed2c3e20405e3986f9afeb2193751a93f3 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
| | * | Consider multiple contents in mimeDataFromDropData conversionViktor Engelmann2016-10-111-9/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | content::DropData can have multiple contents (e.g. an <img> tag has itself as .html property, but also the src="..." attribute as .url property. Therefore, we should always consider all 3 cases and not return immediately when we have found the first content. Task-number: QTBUG-55858 Change-Id: Ie13851e8edb9ada45184a19b6ccfe38839bb9923 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
| | * | Doc: Set the correct indexTitle for C++ Classes pageTopi Reinio2016-10-061-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... and mention namespaces in the title, listing the namespaces with a group selector. Change-Id: I06056beba464a441ab56cb0acbfb0440c0878f0d Task-number: QTBUG-56298 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | | | Add out of source builds for ninja bootstrapMichal Klocek2016-11-111-16/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of coping the src ninja files to shadow dir, do out of source build. Change-Id: I00c577e5def66c0415681deab63b7c7947a39200 Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | | Fix DCHECK when dropping items onto WebEngineViewJoerg Bornemann2016-11-111-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chromium 53 now requires to call RVH::FilterDropData() before DragTargetDragEnter and DragTargetDrop. This fixes the DCHECK and allows Chromium to filter the dropdata's URL (via RenderProcess::FilterURL) before proceeding. Task-number: QTBUG-56303 Change-Id: I29ad350b0b66d2ca1daae1d6d83f6e01206d1250 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
* | | | Fix drops that originate outside the WebEngineViewJoerg Bornemann2016-11-112-16/+13
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Dragging things from another application onto QWebEngineView crashed. RenderViewHost::DragTargetDrop now requires a DropData object. Save the DropData object also in the case where we create it for a drag from outside. Change-Id: I8409500a4b27d06aeec02dce9856aca7e1415402 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
* | | Disable -Werror on Linux when clang is usedJan Kundrát2016-11-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Standard gcc warnings should be considered as errors, but clang warnings should not, because clang has some extra warnings. Change-Id: I298889895af7f9d4e004c3d97e5167738a8c09ad Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix handling of drag 'n drop events in QWebEngineViewJoerg Bornemann2016-11-101-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | QWebEngineView was not receiving any drag 'n drop events anymore since the switch of RenderWidgetHostViewQtDelegateWidget's base class from QOpenGLWidget to QQuickWidget. Turn off the default handling of drag 'n drop events in RenderWidgetHostViewQtDelegateWidget to let its parent handle those. Task-number: QTBUG-57006 Change-Id: Icf29b2619e9b0c36641cb31eafdd2ee5cd0ab38a Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
* | | Start using new config systemAllan Sandfeld Jensen2016-11-103-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds the optionproprietary codecs to configure.json, so it can be selected by the global configure, and is summarized there too. Keeps the old system for compat with building against older Qt. Change-Id: I5deba10f2e25445870cbdc7507155b0b76c307de Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* | | Only use system proxy if QNetworkProxy::useSystemConfiguration() says soKai Koehne2016-11-092-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | This allows users to disable _any_ proxy globally by calling QNetworkProxy::setUseSystemConfiguration(false). Change-Id: If6f5d978316b603c53520512dac1eac57ab6c176 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* | | move invocation of (old style) configuration to top-level projectOswald Buddenhagen2016-11-084-26/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | there doesn't appear to be a reason for magically invoking the configuration from default_pre/post, and it would cause problems further down the line with the new configure system. Change-Id: I3cf743a444e96bb397116f2ad4dce923f57aacfc Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | Fix crash when trying to execute script on a detached RenderFramePeter Varga2016-11-086-18/+54
| | | | | | | | | | | | | | | | | | Task-number: QTBUG-56661 Change-Id: I546222dde64c54955c62d2c30df79d4773b9973c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* | | move setup of QTWEBENGINE_ROOT to .qmake confOswald Buddenhagen2016-11-072-3/+4
| | | | | | | | | | | | | | | | | | | | | less effort, more standardized. Change-Id: Iee03d85b2d3fea2721a5271874b876f411ef8ce9 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
* | | Doc: link error in qtwebengineNico Vertriest2016-11-041-3/+3
| | | | | | | | | | | | | | | | | | | | | qtwebengine-features.qdoc:28: warning: Can't link to 'QQuickWebEngineProfile::spellCheckLanguage Change-Id: Id99ce94ce31e4306891dda7e77331cd8ab8f9d54 Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>