| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The position of the IME window is computed using the widget input item
transform. When a regular QWidget gets a focusIn event, the input item
transform is recomputed inside the
QWidgetPrivate::updateWidgetTransform method. This did not happen
for the QWebEngineView, because the focus event is handled internally
and not passed down to QWidget::event.
Fix consists in calling updateWidgetTransform manually whenever the
view receives focus.
The other cases when updateWidgetTransform should be called (namely
resize and move events) are handled properly by delegating to
QWidget::event.
Task-number: QTBUG-55634
Change-Id: Ic93662929e169d860f8ca567f1955da4dc45f9fe
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Task-number: QTBUG-56870
Change-Id: I36338a1a29bc4e82f5c84cfa1ea641b8df3b5f4f
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This was left out by oversight.
Task-number: QTBUG-56710
Change-Id: Ie23229396eb94b949212324fb50022763935d524
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Suppose the user overrides QWebEngineView::dragEnterEvent without
calling the base implementation and without overriding dragLeaveEvent.
Then our implementation will notify chromium about the drag leave
without having ever seen a drag entering and crash. Only notify chromium
about leave/drop/move events if we've notified it about the drag enter
before. Also, catch the case where the user overrides dragLeaveEvent
without calling the base implementation.
Task-number: QTBUG-54896
Change-Id: Ib958040e5fa7ecab86bac9b724d478c81a521fcc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The method WebContentsAdapter::updateDragPosition actively waits for the
UpdateDragCursor message, sent by the renderer. This active wait does
not work whenever we're currently in a base::MessageLoop::RunTask call,
because of its internal recursion guard nestable_tasks_allowed. Add a
check for nestable_tasks_allowed and bail out if we know that the active
wait will fail. This fixes the hang.
Ensure that the modal file picker dialog is shown outside of
base::MessageLoop::RunTask. This enables drag 'n drop updates from the
file picker to QWebEngineView.
Task-number: QTBUG-56488
Change-Id: Ia13ada9c19e7780e12ca633ab1caeac352aca2a9
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Adds a number of missing load url parameters following the example
of the shell and android webviews in Chromium.
Change-Id: Ice27ab3efc550b8b7cfa6a5386aaf09574428a56
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add check for our supported and semi-supported platforms.
Task-number: QTBUG-56465
Change-Id: Ic2f934ceac1b21ab5c688fa67e1c1a74ddf4a43b
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Check if the opposite flag has been given by the user before adding our
own defaults.
Task-number: QTBUG-56432
Change-Id: I7d6b8fed2c3e20405e3986f9afeb2193751a93f3
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | | |/
| | |/|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
content::DropData can have multiple contents (e.g. an <img> tag has
itself as .html property, but also the src="..." attribute as .url
property.
Therefore, we should always consider all 3 cases and not return
immediately when we have found the first content.
Task-number: QTBUG-55858
Change-Id: Ie13851e8edb9ada45184a19b6ccfe38839bb9923
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
... and mention namespaces in the title, listing the namespaces with
a group selector.
Change-Id: I06056beba464a441ab56cb0acbfb0440c0878f0d
Task-number: QTBUG-56298
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Instead of coping the src ninja files to shadow dir,
do out of source build.
Change-Id: I00c577e5def66c0415681deab63b7c7947a39200
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Chromium 53 now requires to call RVH::FilterDropData() before
DragTargetDragEnter and DragTargetDrop. This fixes the DCHECK and allows
Chromium to filter the dropdata's URL (via RenderProcess::FilterURL)
before proceeding.
Task-number: QTBUG-56303
Change-Id: I29ad350b0b66d2ca1daae1d6d83f6e01206d1250
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Dragging things from another application onto QWebEngineView crashed.
RenderViewHost::DragTargetDrop now requires a DropData object. Save the
DropData object also in the case where we create it for a drag from
outside.
Change-Id: I8409500a4b27d06aeec02dce9856aca7e1415402
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Standard gcc warnings should be considered as errors, but clang warnings
should not, because clang has some extra warnings.
Change-Id: I298889895af7f9d4e004c3d97e5167738a8c09ad
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
QWebEngineView was not receiving any drag 'n drop events anymore since
the switch of RenderWidgetHostViewQtDelegateWidget's base class from
QOpenGLWidget to QQuickWidget. Turn off the default handling of drag 'n
drop events in RenderWidgetHostViewQtDelegateWidget to let its parent
handle those.
Task-number: QTBUG-57006
Change-Id: Icf29b2619e9b0c36641cb31eafdd2ee5cd0ab38a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Adds the optionproprietary codecs to configure.json, so it can be selected by
the global configure, and is summarized there too.
Keeps the old system for compat with building against older Qt.
Change-Id: I5deba10f2e25445870cbdc7507155b0b76c307de
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This allows users to disable _any_ proxy globally by calling
QNetworkProxy::setUseSystemConfiguration(false).
Change-Id: If6f5d978316b603c53520512dac1eac57ab6c176
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
there doesn't appear to be a reason for magically invoking the
configuration from default_pre/post, and it would cause problems further
down the line with the new configure system.
Change-Id: I3cf743a444e96bb397116f2ad4dce923f57aacfc
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-56661
Change-Id: I546222dde64c54955c62d2c30df79d4773b9973c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
less effort, more standardized.
Change-Id: Iee03d85b2d3fea2721a5271874b876f411ef8ce9
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
qtwebengine-features.qdoc:28: warning: Can't link to 'QQuickWebEngineProfile::spellCheckLanguage
Change-Id: Id99ce94ce31e4306891dda7e77331cd8ab8f9d54
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Removes RequestType prefix from FormValidationMessageRequest's
RequestType enumeration members.
Change-Id: I51b7eb77b0bae2a8d3109e3ee3b7ea42349b211c
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This allows the Qt WebEngine licensing documentation to be listed
as part of the output for '\generatelist annotatedattributions'.
Change-Id: Ief91ec5f414c66a8a14c8b4e323cddac87837f58
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The example shows how to create and use custom dialogs
instead of webengine's default dialogs.
Task-number: QTBUG-56063
Change-Id: I440305b2d4357d2b47c6b5a1a821b25c71221aa2
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-56074
Change-Id: I2a66e91dd4ed1026e5ab2539cfd3f9094263b48c
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add dictionary loading error handling, do not download
dictionaries from google.
Change-Id: I00ad7189f85d7eab07f7d8c6e3e9610d510971ff
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When custom dialogs are created for FormValidationRequest, it
is possible to accept Show request but reject Move request,
in that case default MessageBubbleItem is not created and
request should be ignored.
Change-Id: I5f168802a66d88baa68d76396a073b5ff6517542
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Get rid of some potential flaky issues:
- Fix typo in redirect.html
- Do not check URL before wait the result of the load. As a corner case
the load might be finished earlier than the comparison.
- Get rid of unnecessary signal handlers for unrelated test cases. The
superfluous operations might have enough overhead to cause a comparison
to be timed out.
- Separate data URL test case and blacklist it due a to known issue
(QTBUG-56661)
Task-number: QTBUG-56180
Task-number: QTBUG-56661
Change-Id: I76cec4e761be646c2f60588a34bae806cf558b3a
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-56242
Change-Id: Ib6689d6f183532502382c86f92fdbdf27dd6c37c
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
the simulator_and_device CONFIG flag is now gone. this also implies that
we can set the debug_and_release and build_all flags based on the same
condition.
Change-Id: Ib16d05213e738a961c9e0b232829985b8ad64a50
Reviewed-by: Jake Petroules <jake.petroules@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Format the output slightly more, and report the list of optional
bundled and system libraries used.
Change-Id: I1fd06a5a83fb01e93dfd29236774a6e320530a6e
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
fdf3a40 in qtwebview fixed the macOS 10.9 build issue.
This reverts commit 41ba9b70525139fb52d00ba81eb8a53293ad71db.
Change-Id: I178ba785500bf7d15f1b0b8319fe520d07f0388c
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Update Chromium for the actual fix. Add quick auto test for the issue
and unskip WebViewFindText::testfindTextManyMatches.
Task-number: QTBUG-56373
Change-Id: Id70291e5231f572c85b0a7c1ec1b6facd161115a
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The change fixes spellchecking to work on macOS.
A new WebEngine configure option is available to allow spellchecking on
macOS to use either Hunspell like the other platforms, or the native
spellchecker that comes with the OS. The default is to use Hunspell.
Task-number: QTBUG-53135
Change-Id: I3e45b2e0d728b1bf2659c35f3d0a042b0ecd6239
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Title might be changed after a successful page load too. The order is
not guaranteed. Implement wait for the expected title change.
Task-number: QTBUG-56180
Change-Id: If8c529e6246fe9e8c93e41be84c8934c8ed8d729
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 6e9779ac2c5b0d941bb415fb00e0f193d685457c.
It seems there is an issue with 10.9 & Qt 5.8, see QTBUG-56563.
Reverting this to be able to integrate qt5.git in '5.8'
Change-Id: Ide35be544e81d31c3bcbd525bb43d3a864ce116c
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Use convert_dict_linking.pri instead of QtWebEngineCore_linking.pri
for qwebengine_convert_dict linking step. New linking information
contains only required dependencies, so linker should have much
less work to resolve all the symbols.
The target change to executable is also required to
generate convert_dict_linking.pri
Task-number: QTBUG-53135
Change-Id: I1432207bd1853e762d5d8291ce61027592fd0161
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add a page for exposed Qt WebEngine module C++ classes.
Change-Id: I4fd15e9d5c5c1b8c51a836ad5a036083adaae328
Reviewed-by: Topi Reiniö <topi.reinio@theqtcompany.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Simplify code and remove unnecessary wait calls.
Change-Id: If3a783a2a4f97e84de993b9394f5cfa0df948ec2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This fix implements an attempt to remove wait from the test.
Task-number: QTBUG-56180
Change-Id: I2bfeb14ebc9451a1237178aa3c97bd1b27e9485c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Reimplement setting focus on a HTML element in JavaScript.
Change-Id: I1db53bcb526fd52df1fa23527089f8186dfd0ea3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-56540
Change-Id: Ic48883f94d72acf9a965fe8687abb20205a4703b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-56373
Change-Id: I599c02a12a0dfb35bb8b3d1d3abbede1c6498f9e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit c8851dd1a77e730bc6a3c17b7c75b1a4c6b41f53,
and allows building on OS X 10.9 with OS X 10.10 SDK.
Change-Id: Id59b08424165272fd0d35418eef45a03fce731fb
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Reduce the number of messages to be translated to reduce the
translation workload.
Change-Id: Ifa76b02ed6474522eea3b9f74434ead95a6b0d0c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I4d781ba23e4c46a8dd515edcf01e253c208170b3
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I283365c72d351e62bc749cbc60e06472e52255ec
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Task-number: QTBUG-55765
Change-Id: I5576876191fe1c819aa85f2e312391126c904201
Reviewed-by: Christophe Chapuis <chris.chapuis@gmail.com>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There's also QWidget::setContextMenuPolicy and
QWidget::customContextMenuRequested, which is arguably a better
approach. Anyhow, this isn't specific to QWebEngineView, so
let's leave it at that. Finally, there's no need to call
triggerPageAction if you add an action to a menu.
Change-Id: I0c84038746a78316ed6b90a98b68fa5eb95fbad5
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|\| |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/3rdparty
src/webengine/api/qquickwebenginesettings.cpp
Change-Id: Ie4abadb076c51d070cbb05f29b9ebcd9705933ad
|