| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
It fails occasionally and blocks integration
Task-number: QTBUG-57117
Change-Id: I7266ccf4fe7e0905dc31e5e7c085be6f90d0aa03
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Register Qt IPC messages for logging. The usage of
content::RegisterIPCLogger function adds the
content_common.content_ipc_logging.o to the link dependency. Thus it
will register the Chromium Content IPC messages too.
Task-number: QTBUG-57224
Change-Id: I2c45691feb22a34f6074940cc35b8a4ba7804370
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
If .git does not exist then this is not from a git build and therefore
there is no reason to invoke git (which might not even exist on the
system anyway). This prevents an error appearing due to trying to invoke
git on Windows when it does not exist.
Change-Id: I8c0b5b237cfdaffdbb33efdd16cf20cd1560f1a1
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously when a QWebEngineView was inside a modal QDialog, trying to
click on a select tag option did not properly select the option. It
either focused the new option without closing the popup, or didn't
focus it at all.
Fix consists in making sure the newly created popup QWindow and
RenderWidgetHostViewQtDelegateWidget are marked as children of the
QWebEngineView, so that they are considered part of the current modal
session by the OS, thus allowing user interaction with them.
Because the ownership of the delegate widget should still be retained
by its respective RenderWidgetHostViewQt instance, the QObject parent
of the delegate is unset before the parent is destroyed.
Also to make it work on macOS, the window attribute has to be set
to Qt::Tool instead of Qt::ToolTip.
Change-Id: I56d6f446254a624428a0c661ac3c49eb409c931e
Task-number: QTBUG-54836
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
It used to be just ignored.
Task-number: QTBUG-56643
Change-Id: Ife7ac05fce7e93a6eba1ac6e6db1095574c83e42
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
| |
the CI obtains them from the qt5 super repo nowadays.
Change-Id: If41f7c5306ca739fd3800cec3f680fa72df2a871
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since version 54, the chromium distribution package does not contain
the pepper flash plugin anymore. Because of this, the plugin cannot
be installed using the Ubuntu package "pepperflashplugin-nonfree"
anymore (because the package pulled the plugin from the chromium
distribution).
The plugin is also contained in the package adobe-flashplugin, which
installs the file to /usr/lib/adobe-flashplugin/libpepflashplayer.so.
[ChangeLog] Pepper flash is now also searched in /usr/lib/adobe-flashplugin/
Change-Id: I7c135a2eac1628b0d338bbfed07695c9578458e6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
As of version 10.12 (Sierra), the name of Apple's desktop operating
system will be macOS. Change all occurrences where the Mac platform
is discussed to use the macro \macos (defined in the documentation
configuration in qtbase), except in link targets where QDoc does
not expand macros.
Change-Id: Icad4e7817d93b9e7b0e1a9a13a8618b3341ab2ba
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The Q_UNREACHABLE caused WebEngine to block Pepper Flash from
accessing Media Devices such as the WebCam (this rendered
http://testwebcam.com unusable for example)
Task-number: QTBUG-55017
Change-Id: I7979c9a5690173e86310f7448c78949371fbc909
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
In case an OpenGL context can not be created we can try running in
software compositing mode. This should have a much better chance of
working as a fallback.
Change-Id: Icaab24dde8f4b6c8ea4023cf36b0bb679143166f
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
| |
Delete the FilePickerControl object after we're done with it, analog to
what the QtQuick UIDelegatesManager does.
Change-Id: Id5ef6666c8536b9e5c6877cd522b4c20adae37e5
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-56645
Change-Id: I16ca76d3a26d0142846b068cc1ba52bee71cf106
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The position of the IME window is computed using the widget input item
transform. When a regular QWidget gets a focusIn event, the input item
transform is recomputed inside the
QWidgetPrivate::updateWidgetTransform method. This did not happen
for the QWebEngineView, because the focus event is handled internally
and not passed down to QWidget::event.
Fix consists in calling updateWidgetTransform manually whenever the
view receives focus.
The other cases when updateWidgetTransform should be called (namely
resize and move events) are handled properly by delegating to
QWidget::event.
Task-number: QTBUG-55634
Change-Id: Ic93662929e169d860f8ca567f1955da4dc45f9fe
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I102bda62bfaa16a8c9ff4c4929e6b5a055de3e25
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
We do not share context between "processes", but between
"threads"
Change-Id: I20f558f913c1f19fc469ade6faab45762f42d528
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
| |
Pulls in changes to build debug+release correctly and build with Xcode 8
Change-Id: I38d6bd50048b332939416b0fae3f20978995d789
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
| |
Based on widget solution: 1e83a2d1b61b13323163dfe8cac64dad397cb202
Task-number: QTBUG-55650
Change-Id: I6df45e7e018fa201c50fe81e8679c36f97ddeb1e
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Change-Id: I9c571c823b6fa2411e003799f7ff8627ef6e1d5e
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\
| |
| |
| | |
Change-Id: I3e152ee134ed38628d1bf9571df58f469b29e74b
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a link triggers a NewViewRequest, and the latter creates
a new window with a new WebEngineView inside, the "adapter" pointer
can still be NULL when the adoptWebContents is called by openIn.
Therefore is it necessary to test the adapter pointer before using it.
(cherry picked from commit bfc2683ab4ca3f56a2effd1b2f7e68850acb72ba)
Task-number: QTBUG-55765
Change-Id: Iaa7cb4e8c7780a2e3f1a8c85b7b5da0ec541b2f3
Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ie355f72a0bf575e66ab465fb2fcada0430ed8c7c
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Do not rely on "include/QtWebEngineWidgets" or "include/QtCore"
being in the default include path.
Task-number: QTBUG-56107
Change-Id: I9535f723814efdef7bf8290a891978aabfa899bb
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a link triggers a NewViewRequest, and the latter creates
a new window with a new WebEngineView inside, the "adapter" pointer
can still be NULL when the adoptWebContents is called by openIn.
Therefore is it necessary to test the adapter pointer before using it.
Task-number: QTBUG-55765
Change-Id: Ia1a299dd65c229705462c9444b81d7b26567fc09
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Turn the raw pointer
ResourceDispatcherHostLoginDelegateQt::m_authInfo
into a scoped_refptr, to prevent chromium from freeing the memory,
which caused this pointer to dangle and SEGFAULT upon later usage.
Task-number: QTBUG-55828
Change-Id: Ib57e89ca042a4494e2ab77ea10328495e6fc1431
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|\|
| |
| |
| | |
Change-Id: Ie075563e90ca184f8bd38be4a9a9bd49b4640769
|
| |
| |
| |
| |
| | |
Change-Id: I45fcde261328114510ce260a30ad83b8d598c222
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
In line 282f of
chromium/content/browser/frame_host/render_frame_host_manager.cc,
RenderFrameHostManager::Navigate passes nullptr to
WebContentsImpl::NotifyViewSwapped.
In line 3833f of
chromium/content/browser/web_contents/web_contents_impl.cc,
this is passed on to the observers, including
UserResourceControllerHost::WebContentsObserverHelper::RenderViewHostChanged
which dereferenced it unchecked, causing a crash.
Task-number: QTBUG-55254
Change-Id: Ibdb6645f63957d28a89c50b51faeb3aea086a8b3
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Chromium defaults to arm_neon=1 and then sets -mfpu=neon if the arm
architecture is 7.
Change-Id: Ib144dd4188ba4221ed35367026de9f9a04c69792
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I44105c768a958714590b979d3877724f0db659ee
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
| |
Add a lightweight "fake" QWebEngineView class that is returned when Qt Designer
queries the default property values by calling
QDesignerCustomWidgetInterface::createWidget() with 0 parent,
preventing crashes during QWebEngine initialization.
Task-number: QTBUG-53984
Change-Id: Iced64b7d8af4c958fe7e29fa2f64bb9b681fbab2
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was introcuded a new logic which proves that
no mouse / keyboard events are forwarded to
Chromium if the view has no focus, and activeFocusOnPress is set to false.
The selection box get focus when the user click on it,
but the popup window never get (focus is on QuickRootItem)
in this case these mouse events are ignored to forward to Chromium.
Task-number: QTBUG-54795
Change-Id: Id6e81ee39dcde21a6c5c46e302888b9e9478352f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
Pulls in fixes for webcursors and building against FFMPEG3
Change-Id: Ic852604eea1a15cbf96decd536278f01a7f9dcf3
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for QTBUG-48969 was only half-baked patch and
introduced massive memory leak on fbo and texture
alloctaions. Delete fbo and extra allocated
textures.
Task-number: QTBUG-52575
Task-number: QTBUG-48969
Change-Id: I2148f37cd27dab9e40ab72caeb6857752b69379f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Ensure that if QWebEnginePage::createWindow returns 'this' that we fall
back to navigating in current tab.
Change-Id: Idffe25dcafaaf3c824815b3cf1f0e400eaec2923
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-55367
Change-Id: If073f0be97d01dfb26ad47803250eb645b386a1c
Reviewed-by: Johanna Äijälä <johanna.aijala@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
|
|
|
|
|
|
|
|
| |
Unfortunately Mir is not supported yet, see EGL context retrieval code
in src/core/content_browser_client_qt.cpp.
Change-Id: Icade55c4c35f1a2a625479c31699d33853922087
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
| |
Pulls in security updates from Chromium 52
Change-Id: I4fb5183a321b45fdf5515f0a88100b48697ee3aa
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
| |
Change-Id: I86eea3a64a38f6ec9984f663499abffa03cd9eb2
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Chromium does not appear to use it anymore.
Change-Id: I846fd869ffb15b832f208764fe8066f000187973
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
| |
This list is shown in qtdoc/qmlmodules.html
Change-Id: Ib51f0405e7581571f8a124ea6806e7bc4982dba3
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, when a WebEngineView's RenderWidgetHostViewQtDelegateQuick
had focus, but not activeFocus, Chromium was told that it had keyboard
focus. That is not correct, because having focus inside the FocusScope
(the WebEngineView), does not mean it has keyboard focus, it just
means the RWHVQDQ will receive active focus, when the WebEngineView
does.
The call path for that erronous check was done when a new page was
loaded, specifically going through
NavigatorImpl::DidNavigate() ->
RenderFrameHostManager::CommitPending() ->
render_frame_host_->GetView()->HasFocus() ->
RenderWidgetHostViewQtDelegateQuick::hasKeyboardFocus(),
which resulted in incorrect display of a blinking caret in an
input, when the view actually wasn't focused.
The fix consists in checking for the activeFocus rather than the
focus property.
Change-Id: I97002be3fc8adfec2228a1b5ad62696f8872d3cc
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-54114
Change-Id: I63ae6c47eb76a4acf85cd5b0c7adb21399a985dd
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
| |
The docs do not currently get built, because docs for a QML type
need to reside in one file. Also edited the docs for grammar and
style.
Change-Id: Ic62f293e113d0e4bfe0497ce4a665a2a42971eb3
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium does not exclude localhost connection from its proxy rules by
default.
When using a qt proxy with any other form of qt-based connections,
connections to localhost are excluded by default.
This patch adds localhost connections to the proxy-bypass rules.
Change-Id: I76c43a2ae0de8d8fad455445a64a739c6c6b40f0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Changes core_generated.gyp from being generated in the source directory
to being generated in the build directory.
Task-number: QTBUG-43014
Change-Id: Ia67df47bfadbf5dfca6e60a613dcf7b162b468fd
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Since the profile owns the QWebEngineDownloadItem then it is likely that
it will still be around when the QWebEngineProfile is deleted. As the
QWebEngineDownloadItem is a child of the QWebEngineProfile then it will
try to delete it when deleting the QWebEngineProfile which means it cannot
trigger a function call into QWebEngineProfilePrivate.
Change-Id: I51077a7857fb49a6708224a9e9942d17de6f6778
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-54644
Change-Id: Ief2e92e6baf3057cb4c1835557c51c4728c34ec0
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Remove backspace short-cut, Chromium will already handle that if it is
standard on the platform. Also we were not triggering on Back/Forward
buttons due to those being mapped to prev/next tab item in Qt.
Task-number: QTBUG-54546
Change-Id: I9a4f48c718c5685ca9ca1b032d8b04409ac622ca
Reviewed-by: Jesus Fernandez <jesus.fernandez@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
| |
Change-Id: I51562b2dff1ffe4359c6db4a802c406c3706de84
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
| |
Change-Id: Idf18d236816aab12fb01e1b5725e5ad1c73dbaad
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|