| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
| |
Change-Id: Id3bf1218e43609cdb471e087e2077d4c0c0e5153
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On webengine profile destruction all download
items in progress are canceled. This triggered
stateChanged of QWebEngineDownloadItem which
called lambda function on already deleted object.
Do not use lambda functions in this case.
Change-Id: Ia1d359fe47204baa51f1380d1c3547c28550bc28
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-61910
Change-Id: I894d1f180ba9952213b6f67a2445aa927dfd7e9b
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Old QWebEnginePage is destructed by the QWebEngineView::setPage() call.
No need to destruct it explicitly.
Task-number: QTBUG-62147
Change-Id: I8ec33d5df618f69e4acf1667490df4a67dad9a16
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
| |
Change-Id: I398f88943e6f59781ad9227e2888cb25079b638c
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-61788
Change-Id: Ie6c29f3999ea795a37ea444f56e40ddc70ca1c03
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
| |
Change-Id: I4533e28a2c1a338abdb1d373a0a3bfe598a5edce
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code tried to find out whether a user has set an
application proxy by checking the type of the applicationProxy.
This is wrong, because a system proxy will actually also change the
applicationProxy type.
Instead, we now rely on QNetworkProxyFactory::usesSystemConfiguration
to decide whether to use QtNetwork's application proxy, or Chromium's
logic for the system proxy. We also save the state of
QNetworkProxy::useSystemConfiguration to be able to track changes.
[ChangeLog][Networking] Fixed an issue where system proxy settings were
not picked up correctly.
Task-number: QTBUG-61910
Change-Id: I1d9af3f6006ba187266fe50c645f425a46632e41
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
| |
Wait for receiver object to be set after show.
Task-number: QTBUG-61816
Change-Id: I2eb62775d30b0f8f9ec3e76d60a924b56c811865
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: If4db465b9764be80df7fe953be63fc1a40b60d75
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Accept downloads and add a downloads list.
- Fix toolbar icons being pixelated on hidpi screens by
- enabling attribute AA_UseHighDpiPixmaps, and
- replacing the 22x22 icons with 32x32 versions.
- Move favicon selection to WebView to reduce duplication.
- Replace UrlLineEdit with a standard QLineEdit using a QAction for the favicon
and setClearButtonEnabled(true) for the clear button.
- Fix bug where the "File -> New Tab" action would create background tabs
because the QAction::triggered(bool) signal was connected to the
TabWidget::createTab(bool) slot with the bool argument having a completely
different meaning between the two.
- Make the toolbar unmovable. Nobody wants to move the toolbar.
- Add tooltips to toolbar buttons.
- Add tooltips to the tab bar (page titles).
- Stop adding icons to menu items only to disable them right after.
Task-number: QTBUG-60655
Change-Id: I10cc0fa82dbf39281bbdbbf9ef901e1b26402f80
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-61954
Change-Id: I681f7adaab1e0ef1ec162fa98c4a70569e8c3948
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Re-export missing C memory handling functions.
Task-number: QTBUG-61521
Change-Id: I8f94d93a70c81117735a9610e391a1e31c54f15a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
This command-line argument makes it possibly to block exposure of
internal IP addresses when WebRTC access hasn't been granted, using
--force-webrtc-ip-handling-policy=default_public_interface_only
Task-number: QTBUG-57505
Change-Id: I0cddd1b20e0814811894204cb31e0c463a75f7be
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-61275
Change-Id: I7e741ffaaa4044b3b61b6df06ea3eab181db9c97
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unhandled key presses for printable keys were not received by the parent
widget anymore. This was a regression from 5.8.0.
The propagation is suppressed if NativeWebKeyboardEvent::skip_in_browser
is true.
Commit 4501b9d8 accidentally removed the wrong skip_in_browser
assignment.
Task-number: QTBUG-61621
Change-Id: I7eafa1fac5fb9a7edc4af2bc1aac21c106264713
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
| |
Move files from marked, markdown.css to a 3rdparty directory,
and properly document them with a qt_attribution.json file.
Finally, reference the (automatically generated) documentation
in the respective examples documentation.
Task-number: QTBUG-61706
Change-Id: I8fd3f894e6e81647bc4804df784b1e00b83d12d6
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
| |
Change-Id: I7d22a9c2a4f4aed1f364e672985da357158467e7
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pulls following changes:
1a14be1 Enable using gnu thin archives on Linux
296b240 Silence gcc -Waddress warnings in logging.h
fabd7e0 Fix building without git installed
1173dda Do not export c memory handling functions
25ceaa6 Do not launch zygote processes in single-process mode
721a4d1 Carry over user-agent override when opening new windows
Change-Id: If48223d76fbb35f1847e416a7f244e4b6ed85f33
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Windows there is an issue that an OpenGL-backed fullscreen window
will prevent other top-level windows from appearing on top of it (for
example a select / combo box popup). This appears to be a limitation of
the Windows platform compositor (DWM).
The workaround is to call
QWindowsWindowFunctions::setHasBorderInFullScreen on the QWindow which
will show the fullscreen WebEngine view.
Task-number: QTBUG-61563
Change-Id: I5e0f08ef49de6119ef7910cec2b32ea267301c18
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Chromium 56 the --touch-events switch controls both the availability
of the Touch Events API in JavaScript (presence of 'ontouchstart' in
'window' object), and whether touch events are dispatched at all.
In Chromium 57, the switch controls only the Touch Events API
availability, and touch events are always dispatched.
In Qt 5.9.0 which is based on Chromium 56, we always dispatched touch
events, ignored the value of --touch-events, and determined the
availability of the Touch Events API by checking if QTouchDevice lists
any touch screen devices (essentially Chromium's --touch-events=auto
option).
This commit changes the behavior of WebEngine to match that of Chromium
57, so that users can choose to enable or disable the Touch Events API
via the --touch-events switch, whereas the default will be 'auto' mode.
Touch events will always be dispatched as usual. Users that wish to
stop dispatching touch events can install an event filter on
WebEngine's view focus proxy.
Task-number: QTBUG-61045
Change-Id: I07404af3336619869aa87a90a1b426036548dd55
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure that a non-Core Profile OpenGL Context is created on the
Chromium side, so that sharing between the Qt global context and the
Chromium ones works.
Change-Id: Ifc5f39268395615fe50c8aa9467f833c0de233a8
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously when a default QSurfaceFormat was set with an OpenGL Core
profile, all the contexts created on the Qt side would obey the profile,
but Chromium would still use the Compatibility profile for its contexts
leading to warnings when trying to create shared contexts.
The fix is to check which OpenGL profile is used in the Qt global
shared context, and pass that information along to Chromium.
Note that this works only on macOS for now, and the default non-Core
profile is used on other platforms, even though Core was requested.
Passing CoreProfile to Chromium on Windows and Linux currently leads
to crashes.
Task-number: QTBUG-60605
Change-Id: I27a77091923624d19ccc2019953a5b07f9282916
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
When one searches for text on one page and then navigates away,
results for the search-term are also highlighted on the new page.
To stop this from happening, we now call adapter->stopFinding()
when we navigate away from a page.
Task-number: QTBUG-61506
Change-Id: I09e064d7788b12eae0a67c01e4f5872d94924617
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Debug symbol level 1 is not enough to generate all debug symbols on
Windows. The symbols for the files found in src/core are generated with
symbol_level=1, but no symbols are generated for the files in
src/3rdparty.
Change-Id: I30729981d5956c1c6a8040008bc00af1f19c15d2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
| |
Change-Id: Icf8a81d76f5ef4bcfac56101f2da7cf689bd92b7
|
|
|
|
|
|
|
|
|
|
|
| |
We need to ensure that the path is using forward slashes to avoid any
chances of a trailing backslash escaping the final quote. Additionally
we need to quote the whole string in case there is a space, we can't use
shell_quote for this as this preserves the backslashes which can cause
a problem.
Change-Id: Iadde9a10e2d80ad48efd695d414af58d891c7412
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zygote process is responsible for initializing ResourceBundle on Linux.
Thus it is expected to be initialized in Renderer process. When zygote
is disabled the Renderer process can't reload locale resources since the
ResourceBundle hasn't been initialized yet. However, there is no need
for reload because without zygote, Renderer Process initializes
ResourceBundle for itself.
Pulls in Chromium changes:
5352138 [Backport] Initialize RenderSandboxHostLinux in --no-zygote
mode to not crash.
Change-Id: Iace3585e23b4f18850783a813b1466a3ff5fe12f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
SelectionRegion::caret_rect is only documented to be supported on
macOS, so use anchor, focus instead. Also make sure that the rect
always has a width > 0; Both the Windows QPA and the native API
require this.
Task-number: QTBUG-60334
Change-Id: I8436fbfaa204d243578b33cbcaa3f28871b462ee
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove two out of five layers of ifdefs around and inside this method.
- Now always compiled but will yield an error if printing is disabled.
- Remove printing-related ifdefs from demobrowser.
Task-number: QTBUG-61510
Change-Id: I79781189d3d3fb62db0a2216b2b989e3fa1d1f86
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Rolf Eike Beer <eb@emlix.com>
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
mkspecs/features/functions.prf
Change-Id: I53d65ea49f546c7d4aadfdaff178fd2f3f4cdf11
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Pulls in the last security patches from Chrome 59 release.
Changes:
cf318fb Fix crash if glGetString returns null pointer
d34da87 [Backport] Fix for CVE-2017-5071
cb447f7 [Backport] Have sendBeacon throw for Blobs with a type that is not CORS-safelisted.
a83fe7e [Backport] Fix for CVE-2016-5078
ff6f88a [Backport] Fix for CVE-2017-5079
5c34ac7 [Backport] Protect against lifecycle updates that delete a layout object for autoscroll.
f9ecfa6 [Backport] Fix for CVE-2017-5083
17dfc0d [Backport] Fix for CVE-2017-5088
c66a939 [Backport] Fix for CVE-2017-5089
Task-number: QTBUG-61337
Change-Id: Ia634429ef58070d947970a3c07886e94730aa950
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ic58c0d6c7ff65c482f6ec7a70eb0207417ef77fc
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With the no-accessibility feature moved to qtgui-config, we don't
always include it where web_content_apapter_client.h is included, which
gives it an inconsistent binary layout.
Solve it by making the optional method always defined as it doesn't
rely on anything from accessibility.
Task-number: QTBUG-61200
Change-Id: I65f34ab2b6763f3166b945e700994bd8d019a835
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Turns out that we still run out of memory when linking on a 32 bit
Windows.
This reverts commit 53b632ee0b6dc92ffc4f94f88755d94f7533637a.
Change-Id: Ifd8319927b816a52664f214a2540bad31f67935a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I3d1157d109c2413593a4d30126fc70349480fe93
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Read the correct QT_ARCH and QT_TARGET_ARCH variables from QMAKE. This
fixes cases where toolchain arch does not match host arch (e.g. x86 tools
on x64).
Also removes unnecessary WEBENGINE_ARCH variable, and a mismatch in GN
mips names.
Task-number: QTBUG-61528
Change-Id: I11b050977ce6203c10d1776a15eb32efa4693290
Reviewed-by: Rolf Eike Beer <eb@emlix.com>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-61429
Change-Id: I936f1c924ae8158a5243fdf20d12e6c5508b684a
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We don't support building with the Intel compiler and since it fakes being
msvc and gcc, we need to explicitly test for it to block it.
Task-number: QTQAINFRA-1196
Change-Id: I727b17d271dab67af8ce69f80bd3d2414cdc4060
Reviewed-by: Tony Sarajärvi <tony.sarajarvi@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
By default we should allow persistent cookies otherwise
demobrowser might give an impression that cookies are not working.
Task-number: QTBUG-58675
Change-Id: I13ef2729b7f4a757a0d7e0c695dafd4e2f1f75be
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The page content is used as a URL, which is limited to 2 MB
by Chromium.
Task-number: QTBUG-59369
Change-Id: Id0b81b577d1d997dd722c43e3b71b8979d86ee81
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ice02dffc1db2f263c156f855c1f6f64713c6935d
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were returning the PDF byte-data as a javascript unicode string using
the deprecated ascii cast constructor.
This patch changes the behavior to match that of runJavaScript callbacks
and uses a script value over QVariant.
[ChangeLog][QtWebEngine] The callback version of WebEngineView::printToPdf
is now called with a proper bytearray result instead of PDF byte data
in a javascript string.
Change-Id: I71565623465c54052568bb5ff34665baaa93e187
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use the new signals and slots syntax, QStringLiteral, lambdas and nullptr.
- Use tr consistently for user-visible text.
- Use unprefixed CSS transform properties.
- Remove the "; undefined" workaround for runJavaScript calls, which is supposed
to prevent a "possible recursion loop and crash" due to QVariant conversion.
However, since no callback is passed to the method, no such conversion is
taking place nowadays.
Task-number: QTBUG-60655
Change-Id: Iad9131a17e488bf5e6b1905483be33b562dbfc62
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Setting httpCacheType followed by persistentCookiesPolicy
may lead to io thread calling generateHttpCache just before
generateCookieStore, which triggers assert in line 344.
Recall generateHttpCache in case generateHttpCache was
called before generateCookieStore.
Task-number: QTBUG-61047
Change-Id: I1cfe5f18a884bd0d76fce4b30da0e22359cab2af
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
The issue that prevented us from doing so seems to be fixed.
Change-Id: I230419b61352d91e794e5680ca70802d02393bc0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
e38fb8e [Backport] Add gcc toolchain for arm64/linux
363741c Fix compilation with system ICU 59
0346f46 [Backport] Fix for CVE-2017-5076
615b0eb [Backport] Fix for CVE-2017-5075
7931a3c [Backport] Fix for CVE-2017-5070
ef06643 [Backport] Fix for CVE-2017-5077
41c17e9 [Backport] avformat/oggparseogm: Check available data before reading global header
3996e12 [Backport] Flowthread should move its floatlists to container when evacuating
cf200aa FIXUP: Integrate spell checker sources, fix compilation issues
Change-Id: I0148069f30fc8738f63ca6b691fee955efbf4df7
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting with Qt 5.9, the values in QMAKE_RPATHDIR were passed along
to GN, which resulted in both qmake and GN adding rpath linker flags,
leading to duplicate rpath values.
This lead to the Qt package installer not removing all absolute path
rpath values when installing Qt, which subsequently caused issues
with code signing Qt applications.
The fix is not to pass the rpath values to GN, and rely on the ones
generated by qmake.
Task-number: QTBUG-61413
Change-Id: Ib27d9c232674534d4b053cb1e12750f5c8bc87a9
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the extra "/" element from the list of results and pass
an empty file list to the backend.
Task-number: QTBUG-61186
Change-Id: Ib2c577c15502e8d1506948e9683921ed211b9c48
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
We were using the wrong spellcheck preferences, they have moved to the
spellcheck component. It mostly worked because their internal names had
stayed the same.
Change-Id: I485b11d88ee9c6e13d9c2b769c271d27bee4ba30
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|