| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Change-Id: Icf8a81d76f5ef4bcfac56101f2da7cf689bd92b7
|
|
|
|
|
|
|
|
|
|
|
| |
We need to ensure that the path is using forward slashes to avoid any
chances of a trailing backslash escaping the final quote. Additionally
we need to quote the whole string in case there is a space, we can't use
shell_quote for this as this preserves the backslashes which can cause
a problem.
Change-Id: Iadde9a10e2d80ad48efd695d414af58d891c7412
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Zygote process is responsible for initializing ResourceBundle on Linux.
Thus it is expected to be initialized in Renderer process. When zygote
is disabled the Renderer process can't reload locale resources since the
ResourceBundle hasn't been initialized yet. However, there is no need
for reload because without zygote, Renderer Process initializes
ResourceBundle for itself.
Pulls in Chromium changes:
5352138 [Backport] Initialize RenderSandboxHostLinux in --no-zygote
mode to not crash.
Change-Id: Iace3585e23b4f18850783a813b1466a3ff5fe12f
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
SelectionRegion::caret_rect is only documented to be supported on
macOS, so use anchor, focus instead. Also make sure that the rect
always has a width > 0; Both the Windows QPA and the native API
require this.
Task-number: QTBUG-60334
Change-Id: I8436fbfaa204d243578b33cbcaa3f28871b462ee
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove two out of five layers of ifdefs around and inside this method.
- Now always compiled but will yield an error if printing is disabled.
- Remove printing-related ifdefs from demobrowser.
Task-number: QTBUG-61510
Change-Id: I79781189d3d3fb62db0a2216b2b989e3fa1d1f86
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Reviewed-by: Rolf Eike Beer <eb@emlix.com>
|
|\
| |
| |
| |
| |
| |
| | |
Conflicts:
mkspecs/features/functions.prf
Change-Id: I53d65ea49f546c7d4aadfdaff178fd2f3f4cdf11
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Pulls in the last security patches from Chrome 59 release.
Changes:
cf318fb Fix crash if glGetString returns null pointer
d34da87 [Backport] Fix for CVE-2017-5071
cb447f7 [Backport] Have sendBeacon throw for Blobs with a type that is not CORS-safelisted.
a83fe7e [Backport] Fix for CVE-2016-5078
ff6f88a [Backport] Fix for CVE-2017-5079
5c34ac7 [Backport] Protect against lifecycle updates that delete a layout object for autoscroll.
f9ecfa6 [Backport] Fix for CVE-2017-5083
17dfc0d [Backport] Fix for CVE-2017-5088
c66a939 [Backport] Fix for CVE-2017-5089
Task-number: QTBUG-61337
Change-Id: Ia634429ef58070d947970a3c07886e94730aa950
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ic58c0d6c7ff65c482f6ec7a70eb0207417ef77fc
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
With the no-accessibility feature moved to qtgui-config, we don't
always include it where web_content_apapter_client.h is included, which
gives it an inconsistent binary layout.
Solve it by making the optional method always defined as it doesn't
rely on anything from accessibility.
Task-number: QTBUG-61200
Change-Id: I65f34ab2b6763f3166b945e700994bd8d019a835
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Turns out that we still run out of memory when linking on a 32 bit
Windows.
This reverts commit 53b632ee0b6dc92ffc4f94f88755d94f7533637a.
Change-Id: Ifd8319927b816a52664f214a2540bad31f67935a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I3d1157d109c2413593a4d30126fc70349480fe93
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Read the correct QT_ARCH and QT_TARGET_ARCH variables from QMAKE. This
fixes cases where toolchain arch does not match host arch (e.g. x86 tools
on x64).
Also removes unnecessary WEBENGINE_ARCH variable, and a mismatch in GN
mips names.
Task-number: QTBUG-61528
Change-Id: I11b050977ce6203c10d1776a15eb32efa4693290
Reviewed-by: Rolf Eike Beer <eb@emlix.com>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
|
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-61429
Change-Id: I936f1c924ae8158a5243fdf20d12e6c5508b684a
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We don't support building with the Intel compiler and since it fakes being
msvc and gcc, we need to explicitly test for it to block it.
Task-number: QTQAINFRA-1196
Change-Id: I727b17d271dab67af8ce69f80bd3d2414cdc4060
Reviewed-by: Tony Sarajärvi <tony.sarajarvi@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
By default we should allow persistent cookies otherwise
demobrowser might give an impression that cookies are not working.
Task-number: QTBUG-58675
Change-Id: I13ef2729b7f4a757a0d7e0c695dafd4e2f1f75be
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The page content is used as a URL, which is limited to 2 MB
by Chromium.
Task-number: QTBUG-59369
Change-Id: Id0b81b577d1d997dd722c43e3b71b8979d86ee81
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ice02dffc1db2f263c156f855c1f6f64713c6935d
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We were returning the PDF byte-data as a javascript unicode string using
the deprecated ascii cast constructor.
This patch changes the behavior to match that of runJavaScript callbacks
and uses a script value over QVariant.
[ChangeLog][QtWebEngine] The callback version of WebEngineView::printToPdf
is now called with a proper bytearray result instead of PDF byte data
in a javascript string.
Change-Id: I71565623465c54052568bb5ff34665baaa93e187
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use the new signals and slots syntax, QStringLiteral, lambdas and nullptr.
- Use tr consistently for user-visible text.
- Use unprefixed CSS transform properties.
- Remove the "; undefined" workaround for runJavaScript calls, which is supposed
to prevent a "possible recursion loop and crash" due to QVariant conversion.
However, since no callback is passed to the method, no such conversion is
taking place nowadays.
Task-number: QTBUG-60655
Change-Id: Iad9131a17e488bf5e6b1905483be33b562dbfc62
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Setting httpCacheType followed by persistentCookiesPolicy
may lead to io thread calling generateHttpCache just before
generateCookieStore, which triggers assert in line 344.
Recall generateHttpCache in case generateHttpCache was
called before generateCookieStore.
Task-number: QTBUG-61047
Change-Id: I1cfe5f18a884bd0d76fce4b30da0e22359cab2af
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
The issue that prevented us from doing so seems to be fixed.
Change-Id: I230419b61352d91e794e5680ca70802d02393bc0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
e38fb8e [Backport] Add gcc toolchain for arm64/linux
363741c Fix compilation with system ICU 59
0346f46 [Backport] Fix for CVE-2017-5076
615b0eb [Backport] Fix for CVE-2017-5075
7931a3c [Backport] Fix for CVE-2017-5070
ef06643 [Backport] Fix for CVE-2017-5077
41c17e9 [Backport] avformat/oggparseogm: Check available data before reading global header
3996e12 [Backport] Flowthread should move its floatlists to container when evacuating
cf200aa FIXUP: Integrate spell checker sources, fix compilation issues
Change-Id: I0148069f30fc8738f63ca6b691fee955efbf4df7
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Starting with Qt 5.9, the values in QMAKE_RPATHDIR were passed along
to GN, which resulted in both qmake and GN adding rpath linker flags,
leading to duplicate rpath values.
This lead to the Qt package installer not removing all absolute path
rpath values when installing Qt, which subsequently caused issues
with code signing Qt applications.
The fix is not to pass the rpath values to GN, and rely on the ones
generated by qmake.
Task-number: QTBUG-61413
Change-Id: Ib27d9c232674534d4b053cb1e12750f5c8bc87a9
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the extra "/" element from the list of results and pass
an empty file list to the backend.
Task-number: QTBUG-61186
Change-Id: Ib2c577c15502e8d1506948e9683921ed211b9c48
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
We were using the wrong spellcheck preferences, they have moved to the
spellcheck component. It mostly worked because their internal names had
stayed the same.
Change-Id: I485b11d88ee9c6e13d9c2b769c271d27bee4ba30
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
| |
Task-number: QTBUG-59824
Change-Id: Id72428996721bd60596becc5b13b29a132f70e69
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
(cherry picked from commit af422d3fc6061ef057bb6f8b58b97af62304e836)
|
|
|
|
|
|
|
| |
Task-number: QTBUG-60655
Change-Id: Ie385232d5c126eafc18c08f49c15cc5e18c69ba1
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Fixes build issue on Windows:
html2pdf.cpp(88): error C2027: use of undefined type
'QtNamespace::QTextStream'
Change-Id: Idf43d826f72a6dd06245c3d072b6c6ea58ea2ae6
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
If we don't give Chromium a host toolchain it will pick one of its own
overriding which compiler should be used, and breaking native builds
on non-x86 architectuers.
Task-number: QTBUG-61128
Change-Id: Ia25a4f43a28214003abcb11dc75a0e57064f76a7
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
| |
Replace references to global settings with references to the
profile that the page belongs to.
Task-number: QTBUG-57349
Change-Id: I19a2bf999608f2d4f7b565ea50bac1cbf9690c46
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise an application shortcut like Shift+Delete would no longer
work when webengine has focus (e.g. "delete mail" in KMail)
This removes unconditional calls to editorActionForKeyEvent for
ShortcutOverride event handling. We can remove those, because the key
sequences that are checked by editorActionForKeyEvent are a subset of
the key sequences checked by isCommonTextEditShortcut.
This amends commit 3902b27e.
Change-Id: I12a98368381edef36f11457c8b864d843efb871a
Reviewed-by: David Faure <david.faure@kdab.com>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
| |
Change some compares to tryCompares to wait for
downloadStateChanged signal before comparing downloadState.
Change-Id: If8f7f15a776e60c937f0e006d2ac337f6c1f9ad9
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
tst_loadProgressSignal.qml is a duplicate of tst_loadProgress.qml.
Move loadProgressChanged signal check to tst_loadProgress.qml
and delete tst_loadProgressSignal.qml.
Change-Id: I14821d4979def7b9f1985859384224b8f8111bd6
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
7a81e62 FIXUP: Fix assert on QRC urls
08948cb Add switch option for using OpenGL Core Profile in Chromium
c2c63f9 Fix assert triggered by CHROME_IPC_LOGGING
e38d326 Fix build with WebRTC disabled
8bb5341 Fix DCHECK with audio-only desktop capture
801c957 [Backport] GN: Add Arm64 Linux support
b4b03ce Fix windows builds with plugins disabled
Change-Id: I2e2a1b3ac4db138309cc0c16964de948275b4ee8
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Mea culpa ! This is not only not required in 5.9.1 but
also does not even compile.
This reverts commit dc70e81da3f7b639ace9c5cc14e1fd4eb1942e4c.
Task-number: QTBUG-61299
Change-Id: I0879abe58a23588bddf9e4217899d7bfbf604438
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The /WHOLEARCHIVE option was introduced in Visual Studio 2015 Update 2.
Since we support no older MSVC version we can unconditionally use this
option and remove our hack that simulates whole-archive by writing
object file names into a linker reponse file.
Change-Id: I32d2cb556c15f9a8aa2f77f608268e0af7ab6a1d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Clean up the logic for cross-building to x86 on x86-64 windows, avoiding
enabling debug symbols when force_debug_info is set, remove them 32-bit
builds even it _is_ set, and use the standard logic for getting the GN
target arch.
Change-Id: Ia6a5a5e7429ffb1cf07629deaeebfb2466280a9b
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously when a screen sharing request was accepted on macOS, instead
of showing the captured screen, a black rectangle was displayed. This
was due to passing an incorrect screen id to the screen capturer, which
resulted in a failed attempt to find the main active screen.
The fix is to query for all available screen ids from the operating
system, and choose the first id as the id to pass along to the screen
capturer.
Task-number: QTBUG-55165
Change-Id: Id8e648e59755aa2820b05b990adeaa9b58fd26f0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix destruction of browser context, which takes
place on qt_call_post_routines. Unfortunately demo browser
destructs its windows just before qapplication
destructor runs, so there is no more main event loop running.
Please note this is just a quick fix, and proper fix would require
refactoring the example not to use anit-pattern of deriving from
qapplication.
Task-number: QTBUG-58675
Change-Id: I419a1655a70397e69fecef2ceb37cbfc7e7f5ca4
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Add dependency to spellchecker build_feature
Task-number: QTBUG-61165
Change-Id: Ib730280f00b07c9f8a0ffb59399e0a25bc9829a3
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When files are dropped then it's expected that dataTransfer.files and
dataTransfer.items have the same amount of entries. That means that
whenever QMimeData contains files we must only convert those and ignore
the rest.
But while files do not allow other items before them, text and URLs may
co-exist in content::DropData.
This is consistent with the behavior of Chromium and Firefox and what
web pages expect.
Task-number: QTBUG-59690
Change-Id: Iad56aac3e071dcfa09fa5dfcc788c1c54c6eeae6
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The resources files are currently installed twice. Once in src/core.pro
and once in src/core_module.pro.
The core.pro installation steps should be removed, because they do not
cover the macOS framework case, thus ending up with creating resources
both in the framework directory, as well as in the installation root.
Task-number: QTBUG-60707
Change-Id: Id0121c82d7439949474f605c6630ae045125f7ba
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
Use 'visibilty' attribute instead of 'static' to hide
extra symbols - clang compiler does not like it.
Task-number: QTBUG-61138
Task-number: QTBUG-60565
Change-Id: Ibf4b469a179ad77b68ad4e54ab541e7276367a44
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
tst_QWebEngineHistory has lots of race conditions similar to those
we have seen for example in tst_QWebEngineView. We now use QSignalSpy
and QTRY_COMPARE instead of SignalBarrier and ensureSignalEmitted(),
because these are more robust. We did the same for
tst_QWebEngineView.
Task-number: QTBUG-58473
Change-Id: I1d12914670aa1c08b7edf7593df8c950ad6d4b0b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-55766
Change-Id: Ic90eb7b9a211b09281ccbb3eae727e8a1c081b9a
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
| |
Change-Id: I9eccddd420cd0eb8b5be3006a4091465d4b3fab0
Task-number: QTBUG-60472
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When opening a new window, for example by using the JavaScript
method window.open('...'), the requested url is not stored
in the content::WebContents object we get in
WebContentsDelegateQt::createWindow (at this point, it should
at least be stored as pending request in the WebContents'
NavigationController, but it is not).
Because of this, the QQuickWebEngineNewViewRequest object
in QQuickWebEngineViewPrivate::adoptNewWindow never contained
the url. We have access to the target url in
WebContentsDelegateQt::WebContentsCreated, so now we store
it there in a new property m_initialTargetUrl, from where
WebContentsDelegateQt::createWindow takes it and passes it
to WebContentsAdapter::adoptNewWindow as a new parameter.
[ChangeLog][WebEngine] Fix WebEngineNewViewRequest::requestedUrl being empty when opening window from JavaScript
Task-number: QTBUG-57675
Change-Id: I7e2c7866899baade17ce2517e6be8b2b2709699e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\
| |
| |
| | |
Change-Id: Iba6114263488d6bf84b255b38182904dc5880386
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Changes:
889f71d Fix Linux kernel lacking V4L2_CID_POWER_LINE_FREQUENCY_AUTO
7a02c7ed Stop erronous deadlock errors in sandboxed debug mode
72edffd [Backport] Fix traverseNonCompositingDescendantsInPaintOrder for
float-under-inline cases
aa2fdd6 Revert "Revert "[Backport] Fix for CVE-2017-5064""
Change-Id: I315a11ed196da1eec5255c6243ef820622afd3c1
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The symbol name for delete operators did not
match the actual function definitions, however
linker had no problem with that and simply skipping
the symbol version export. Due to lazy binging
in PLT this also got unnoticed when testing
with test app, where delete was called on exit.
Task-number: QTBUG-60565
Change-Id: I2be2f394a0097f1d06cf9ecda33ae5b22f83a77c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|