summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* init-repository: pass regexp in raw string to git log --grepAndras Becsi2014-07-181-2/+2
| | | | | | | | | | This prevents python from escaping the special characters that resulted in git not finding the proper shasum for the git-svn-id regular expression line. Change-Id: Ic5449db6319b638cf692d2b4427ce5de7cbac66e Reviewed-by: Michael Bruning <michael.bruning@digia.com> Reviewed-by: Adam Kallai <kadam@inf.u-szeged.hu>
* init-repository: fix checkout of pure git repositoriesAndras Becsi2014-07-161-7/+8
| | | | | | | | | | Since some projects are maintained in git repositories only even the 'svn' DEPS file has some git shasums instead of svn revisions. Check the current shasum and tag outside of the ref block so we actually end up checking out the parsed shasum for non-git-svn repositories. Change-Id: Iabc4a5b15e50a0f0df84179a65929352ee2addb7 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Implement accessibility hit testingFrederik Gladhorn2014-07-162-0/+19
| | | | | | | childAt needs to return any child at the given coordinates. Change-Id: I19bfbd24a9bfc868fd1602f058cb9ce873ceef52 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Fix init-repository to also work on Windows.Michael Brüning2014-07-161-2/+5
| | | | | | | | This creates a requirement to have pscp / PuTTY installed when wanting to initialize the upstream repositories on Windows. Change-Id: I404de5d45c70fd950a284a86403ca47c64826392 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Unstage upstream repositories after initializing themAndras Becsi2014-07-161-0/+4
| | | | | | | | This prevents accidentally pushing automatically staged upstream submodules which are meant to be local-only. Change-Id: I565fe8f3e0157a6623338ba7a236941184a98b8e Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Use the version tag when checking out chromiumAndras Becsi2014-07-152-18/+24
| | | | | | | | | | Instead of grepping for the VERSION file update in the git log check out the sha1 that has been tagged with the requested version. Also harden the regexp we use to translate svn revisions to git sha1's and further clean up the findShaAndCheckout function. Change-Id: Iaeb7ebee558b7ebadaf3428e06626736601198cf Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix crash when accessibility queries bounds on startupFrederik Gladhorn2014-07-151-0/+2
| | | | | | | On startup we may not yet have an accessibility manager. Change-Id: I9fda09c20de40ed3c8fb7108fd0314a789eb50f5 Reviewed-by: Andras Becsi <andras.becsi@digia.com> Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix interpretation of ARIA Application roleFrederik Gladhorn2014-07-151-1/+1
| | | | | | | | | Setting the Qt role Application will lead Qt to returning the qApp accessible representation. Instead make it a document. Change-Id: Id0b0a3462115905664b8147ab7d529bae7e4fa4b Reviewed-by: Andras Becsi <andras.becsi@digia.com> Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Implement accessible value interfaceFrederik Gladhorn2014-07-153-2/+99
| | | | | Change-Id: I837d7f3041aec59ae83c0fe802bc83b746e62b76 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Implement accessible text interfaceFrederik Gladhorn2014-07-154-4/+184
| | | | | Change-Id: I3a9143c61ecda98513be031fc554fd4bfcef7b7c Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix define in windows.priZoltan Arvai2014-07-151-1/+1
| | | | | | | GYP_ARGS needs a -D option before defining a value. Change-Id: I4acb78e3f201a5d7369c3e998eb7356769bb7553 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix RenderWidgetHostViewQt::GetViewBoundsFrederik Gladhorn2014-07-148-1/+23
| | | | | | | | | | GetViewBounds should return the bounds of the view, not the screen rect. The view bounds are for example used to calculate the screen position of accessible objects (which gets fixed with this patch). Change-Id: I5b342113af737847c1756a13183cd2b8b8db648a Reviewed-by: Andras Becsi <andras.becsi@digia.com> Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix the indexOfChild function for the web documentFrederik Gladhorn2014-07-113-0/+12
| | | | | Change-Id: I37a32bd5dd8760bc91173968a620a1932ae67b4e Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Improve text for accessiblesFrederik Gladhorn2014-07-112-3/+24
| | | | | Change-Id: I0301ed0403b56169e610cf1c38a1e5da39ee164f Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Implement functions of BrowserAccessibilityDelegateFrederik Gladhorn2014-07-110-0/+0
| | | | | | | This is in line with how other platforms do it. Change-Id: Ia258511d3fa35387a69c81c9c02c181fc2995e6c Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Fix duplicate document roleFrederik Gladhorn2014-07-112-1/+3
| | | | | | | | The blink root element already has document as role. By setting it in the webview we'd get two documents in the hierarchy. Change-Id: Ie14e57b4e2050dbd9495c4fa94de4e2faebc02c1 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Implement functions of BrowserAccessibilityDelegateFrederik Gladhorn2014-07-115-178/+60
| | | | | | | This is in line with how other platforms do it. Change-Id: Ia258511d3fa35387a69c81c9c02c181fc2995e6c Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Widget based accessibility glue codeFrederik Gladhorn2014-07-106-0/+159
| | | | | | | | | With this patch the accessibility hierarchy inside webengine becomes available when navigating from QWidget based web views. Change-Id: Ib3625a6ec93b4d3f298fb845ab85209b348349ba Reviewed-by: Zeno Albisser <zeno.albisser@digia.com> Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Add core accessibilityFrederik Gladhorn2014-07-0917-7/+936
| | | | | | | | | | | | | | | | This commit adds the basics to bridge the blink accessibility classes to QAccessibleInterfaces. Note that it needs two follow up commits to implement the bridging from the QWidget/Qt Quick worlds. [ChangeLog][Accessibility] QtWebEngine now has accessibility support, enabling assistive technology such as screen readers to work with it. Change-Id: Ied1d97e61a024115ac7a9245331211f6d9fac1b4 Reviewed-by: Zeno Albisser <zeno.albisser@digia.com> Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Fix the build with recent qtbaseAndras Becsi2014-07-073-0/+6
| | | | | | | | | | | | Since 3cd70c11bc7bbe3c5e9e4972d2273cf51bbdc30e in qtbase Qt modules require cmake tests to be present which makes QtWebEngine fail with "Missing CMake tests." We do not support building with cmake at this point, so disable these tests by setting CMAKE_MODULE_TESTS to '-' for module pro files. Change-Id: I777e6b2c7ce975ad021281800987f9d3ce173399 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix requests for audio and video permissionsFrederik Gladhorn2014-07-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Requesting MediaAudioCapture would unconditionally ask for QQuickWebEngineViewExperimental::MediaAudioVideoDevices instead of MediaAudioDevices since the if wrongly tested for the same condition twice. In addition fix a warning: variable 'feature' is used uninitialized whenever 'if' condition is false api/qquickwebengineview.cpp:369:13: warning: variable 'feature' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] else if (requestFlags.testFlag(WebContentsAdapterClient::MediaVideoCapture)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ api/qquickwebengineview.cpp:371:57: note: uninitialized use occurs here Q_EMIT e->featurePermissionRequested(securityOrigin, feature); ^~~~~~~ api/qquickwebengineview.cpp:369:9: note: remove the 'if' if its condition is always true else if (requestFlags.testFlag(WebContentsAdapterClient::MediaVideoCapture)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ api/qquickwebengineview.cpp:364:4: note: variable 'feature' is declared here QQuickWebEngineViewExperimental::Feature feature; ^ Change-Id: If63fbb5a59a71dede1d1829695f66c22849a4dcd Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Remove stray semicolonsFrederik Gladhorn2014-07-071-3/+3
| | | | | Change-Id: I87d6532babc9475e46e28f6be7d1593622958764 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Add missing header file to .proFrederik Gladhorn2014-07-071-0/+1
| | | | | Change-Id: I4543cc9a42f803fd763b889cf7c36d8cfd54fc42 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* tst_qwebenginepage: Fix type in javaScriptConsoleMessage signatureFrederik Gladhorn2014-07-071-1/+1
| | | | | Change-Id: Ie4a2a75388f3db3316e3e333e2b8d578ade034ac Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Enable Chromium on Windows to link to correct ANGLE configuration.Michael Brüning2014-07-032-0/+3
| | | | | | | | | | | | This is done by setting qt_egl_library and qt_glesv2_library to the correct value depending on whether the build is using debug or release config. This also updates the 3rdparty submodule as necessary. Change-Id: I536310073d1d2436f7ed529b935421f6c9a8cae9 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* tools: add reset option to patch_upstream.pyAndras Becsi2014-07-033-1/+41
| | | | | | | | This patch makes it possible to reset the upstream chromium repository to its baseline state. Change-Id: Idff94a0f873e994716f77c83f4c5b79bcd48aec5 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* tools: add check_patches.py script for checking patch annotationsAndras Becsi2014-07-031-0/+108
| | | | | | | | | | | | | | | | This script should be ran whenever adding new patches to our chromium snapshot and makes sure we keep the upstream build functional. Having clean patches is beneficial to keep it possible to upstream patches to the Chromium project, and to keep an overview of our changes. An annotation is not needed if the patch is adding files to the chromium snapshot that were removed by take_snapshot.py, thus are already present in the upstream repository. In these cases the non-annotated patch will be ignored by the scripts. Change-Id: I46605c559825d9da2653036e9a12a2a5730330a0 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* tools: move upstream repo utility functions to version_resolver.pyAndras Becsi2014-07-032-50/+61
| | | | | | | This makes it possible to use them in other scripts as well. Change-Id: I8aa76c1a9be91c56fd232a592ac41de5079eb3c7 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Reorder files alphabeticallyPierre Rossi2014-07-011-10/+10
| | | | | Change-Id: I1b7bea888290be340b2e368f8e77b661e8d66018 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Add .tag file and the git-archive export optionsSergio Ahumada2014-07-012-0/+5
| | | | | | | | The .gitattributes and .gitignore files do not need to be present in packaged sources, as they are for people using the Git repository. Change-Id: I0c9cd62fae0c4f4ca75552cbac966e27cadac45d Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* XFAIL tst_QWebEnginePage::backActionUpdateJocelyn Turcotte2014-07-011-0/+1
| | | | | | | | | The test relies on events being propagated from the QWebEngineView to its children. We should probably send those events directly to the WebContentsAdapter to fix this kind of use case. Change-Id: Ib5cc199fe8fc27c21603888b49334d1c1f71e575 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* XFAIL tst_QWebEngineFrame::setUrlHistoryJocelyn Turcotte2014-07-011-6/+17
| | | | | | | | | | Update the checks to cover the case where the count could be the same with different URLs, and mark those checks as currently failing because QtWebEngine doesn't have the logic preventing QUrl() to affect the history. Change-Id: Id0260d21d32d9e85fbd14f44536c2c93b6eb40b1 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Prevent premature deletion of JavaScript alert dialog object.Michael Brüning2014-06-303-8/+9
| | | | | | | | | | | This fixes a crash on Windows when dismissing a JavaScript dialog. It was caused by the JavaScriptDialogController object deleting itself and its private object from a method call and subsequently trying to run the JavaScript dialog callback. Task-number: QTBUG-39883 Change-Id: I74300c53943ec7ebc492362ef7d75d83aa1f8051 Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
* OS X: Fix the build with the Qt SDKAndras Becsi2014-06-273-3/+3
| | | | | Change-Id: Icc4219ace4121a4b30302e0348e48dc75cae54cb Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
* Fix crash when loading context menu on Windows.Michael Brüning2014-06-261-1/+1
| | | | | | | | | | | Use QUrl::fromLocalFile to load components from the installation Qml directory. Using just the absolute file path wasn't a problem on Linux, but did not work on Windows. Other Qt modules are also using QUrl::fromLocalFile to do this. Change-Id: I689c516dc63a6c966435eedb94441d7c9246dd25 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Install ICU data file to Qt on WindowsZoltan Arvai2014-06-201-0/+5
| | | | | | | ICU data file is required by Qt5WebEngineCore. Change-Id: Ifcbb1119e9dfe25b6a1bb206475176f21278c2a9 Reviewed-by: Michael Bruning <michael.bruning@digia.com>
* Fix keyboard scrollingAllan Sandfeld Jensen2014-06-182-3/+10
| | | | | | | | | | | | Arrow keys and page-up/page-down was not working. These are detected on RayKeyDown events which both the Win and GTK versions sends instead of KeyDown. Also fixes a mistake in reading the length of the UTF16 text string that was using sizeof on a pointer. Change-Id: I441ef21c15430dafcaeda00d43eb9aec81cd88b8 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix patch_upstream script on WindowsZoltan Arvai2014-06-171-2/+9
| | | | | | | | | | | Preventing failure while applying patches on submodules that are skipped on Windows. Non Windows related submodules are not checked out from upstream repository. This behavior is a workaround for git issues. Change-Id: If34d9d2916829f87c7397a07803f79c156c05c57 Reviewed-by: Michael Bruning <michael.bruning@digia.com> Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Project quads to z=0 instead of compressing them between 0 and 1Jocelyn Turcotte2014-06-171-30/+6
| | | | | | | | | | | | | Since all quads are already separated in non-intersecting geometries and ordered according to their depth by Chromium, there is no need to keep any z value once the perspective projection has been applied. Avoid the useless computation and project the quads to z=0 the same way that QMatrix4x4::toTransform() does when used to flatten QQuickItem::transform(). Change-Id: I3ec5dc2da23cf431e2d8d0bb8b1ed48f2f2d2d8e Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Explicitly return false in WasAllocatedUsingRobustnessExtensionJocelyn Turcotte2014-06-162-0/+2
| | | | | | | | | | | | This is the default behavior of gfx::GLContext, but explicitly do it for documentation purpose and cover the case of the behavior of gfx::GLContext would change in the future. This also updates the submodule to include the change that uses this value. Change-Id: I214376d92b4f9f11bd491c2b1263cf8159e5779f Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Update .gitignore with build artifactsAndras Becsi2014-06-051-0/+2
| | | | | | | | This hides the prepared patches directory for upstream builds and gyp cache files produced for idl files. Change-Id: I340e5f6af5169810a780c9295d19bc7ce5fefd8c Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix typos and warnings in the Quick testsSzabolcs David2014-06-056-18/+23
| | | | | | | | | - Add valid size to tst_faviconLoad.qml - Add missing files to qmltests.pro - Rename test cases and files from WebView to WebEngineView Change-Id: I40163117a11672b18230046a1604624bc4620dba Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Fix import versions in the Quick testsSzabolcs David2014-06-0514-14/+14
| | | | | Change-Id: I5f16a2f824112bdfa2c50b3e4d93d6d47e34ba1b Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Remove separately maintained patches from repositoryAndras Becsi2014-06-0541-3447/+0
| | | | | | | | | | | | | | We maintain them on top of the Chromium snapshot. A new script tools/scripts/patch_upstream.py replaced patches/patch-chromium.sh with the recent snapshot update. The patches that we have on top of the baseline version are prepared from the chromium snapshot and applied on the upstream chromium checkout. A consequence of this is that init-repository.py -u from now on requires a snapshot checkout as well. Change-Id: I639c45904b72952804e5227ebc948a8859cf74dd Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
* Update ninja and bump Chromium version to 33.0.1750.170Andras Becsi2014-06-054-10/+130
| | | | | | | | | | | | | | | | | | | This patch also changes the way we handle our patches. We'll always take a new snapshot without patching Chromium and rebase our patches on top of the snapshot. This removes the need for separate patch files for the ustream repository since we can use the patches of the snapshot and apply them on the upstream checkout if we want to use an upstream build. This makes it easier for us to have branches for the release and maintain and minimize the number of patches we need on top of upstream Chromium. For now a snapshot checkout is needed to be able to prepare the patches for an upstream build but in future we cold improve this to fetch the patches from the remote snapshot repository if needed. Change-Id: I6280ffbe2d50d25d252734bc76d19bfaaa081637 Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
* Add --baseline-upstream option to init-repository.pyAndras Becsi2014-06-051-1/+6
| | | | | | | | | This flag makes it possible to initialize an upstream repository without applying the QtWebEngine patches, which will be the used to take a new snapshot, on top of which we will rebase our patches. Change-Id: I89a6a135bb457edfc31c24a052f1732fb70299dc Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* Define mac_sdk_min and mac_deployment_target instead of mac_sdk_pathAndras Becsi2014-06-043-5/+8
| | | | | | | | | | With Qt 5.3 mac_sdk_path ends up being empty, so make sure to set the proper flags for chromium to pick the right sdk. Also add clang_use_chrome_plugins=0 so we can remove it as well from the Mac-Use-libc-instead-of-stdlibc patch. Change-Id: Ia132f079f905761644ad26c728f7116f538ea62d Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Add update_change_ids.py to update Change-Ids of a set of patchesAndras Becsi2014-06-041-0/+86
| | | | | | | | This will be useful when updating the snapshot and rebasing patches. These patches need updated IDs to keep the gerrit database happy. Change-Id: I62e9fc11a902f57497a2693cc59b873f13cfce12 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix the build on MacAndras Becsi2014-06-041-0/+1
| | | | | | | clang complains about unknown scoped_refptr Change-Id: Iee7590f9ad45cab55a5918bf1c756aa769fa3fd9 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* Fix init-repository.py's --no-gerrit optionAndras Becsi2014-06-041-1/+1
| | | | | | | | | | The argument should not be added to the mutually exclusive group but to the parser itself to make it usable with upstream checkouts as well. Change-Id: If2361c7beb0463a471cea9ce01e18a51abeed4ee Reviewed-by: Jeff Rogers <jrogers@blackberry.com> Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-05-05 20:51:39 +0000