summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | Merge remote-tracking branch 'origin/5.4' into devFrederik Gladhorn2015-01-0212-10/+84
| |\| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: .qmake.conf src/3rdparty src/core/content_browser_client_qt.h src/core/core_module.pro Change-Id: Ia05a6564a4d17ca14ff9b76ae018c3f4ef33d535
| | * | Use QDir::separator() where paths might be generated for WindowsAllan Sandfeld Jensen2014-12-151-2/+2
| | | | | | | | | | | | | | | | | | | | Change-Id: Id7afc11cd58f671ff5ce629cfc29bdb6d9567dc2 Reviewed-by: Pierre Rossi <pierre.rossi@theqtcompany.com>
| | * | Enable cmake config files generationJocelyn Turcotte2014-12-125-6/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As QtWebEngine now uses 5.x as its version number, we can just provide cmake tests and let qmake scripts do the rest. Task-number: QTBUG-42073 Change-Id: I28ccddbd1849980074dfbeefb5cb5a70c9209ab1 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
| | * | Bump versionOswald Buddenhagen2014-12-121-1/+1
| | | | | | | | | | | | | | | | Change-Id: Id56d08a3b3192c63ee6d2f56cee8085ed41ac666
| | * | Force active focus for touch beginAndras Becsi2014-12-081-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the focusing issues on touch devices. Change-Id: I26c0080ea70aeabbd608e15fbd3705b907bdb68e Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| | * | Check for EGL_KHR_fence_sync instead of EGL_KHR_reusable_syncAndras Becsi2014-12-082-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We create an EGL_KHR_fence_sync on the chromium thread but try to verify if the wait function implementation is available by testing for the EGL_KHR_reusable_sync extension in the scene graph thread. Since the latter extension is not supported by most of our devices, we never actually waited for the rendering to finish. Change-Id: Ied829d4035d42899cfb3f86de018bc48e61c0cc0 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| | * | Add a stub QuotaPermissionContext implementationSzabolcs David2014-12-042-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This prevents the crash when the application requests persistent storage access using the Quota API (e.g. on http://codepen.io/matt-west/full/CrfKh). The request has been disallowed for now, because it should rely on user permission. Change-Id: I4ae057c9485d3f06f45a637c7eeda9dd69fe6b54 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
| | * | Add class and enum documentation to QWebEngineCertificateErrorAllan Sandfeld Jensen2014-12-031-0/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without the class description the methods documentation was never generated. Change-Id: I0d7232e8f5cc6765908cb28b77d0fe0f514d359d Task-number: QTBUG-42996 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| | * | Flush UI message loop before quittingAllan Sandfeld Jensen2014-12-021-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cookies were not flushed on application exit because objects deleted lazy on the UI-thread never had their destructors called because we did not flush the queue on exit. Change-Id: If53cdb5547e15a9f39de8b99b1da313e307b1c90 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | | Revert the version number in experimental back to 1.0Andras Becsi2015-01-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts the accidental version number update, since we provide no guarantees for the experimental API, we can update the version number as soon as we make the corresponding API public. Change-Id: I03d8ba83182f185bb42af0840880561d5e962043 Reviewed-by: Adam Kallai <kadam@inf.u-szeged.hu> Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | | Make Chromium use the same locale as QtAllan Sandfeld Jensen2015-01-133-1/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Tell Chromium to use the locale Qt has determined as the default locale. Change-Id: I16986d84afcc0b496a22441b4a92fc09a5c89121 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
* | | | Do not allow desktop notificationsAllan Sandfeld Jensen2015-01-132-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The default implementation of CheckDesktopNotificationPermission always allows desktop notifications. Until we have implemented them we want them always disabled. If we do not, we will end up with invalid cancel notification Closures being called. Task-number: QTBUG-41893 Change-Id: I609222d538ba6f3d1ac264eacd692211e4e653a7 Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
* | | | Add QML download APIAndras Becsi2015-01-1221-185/+783
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This patch exposes downloadStarted and downloadFinished signals on the WebEngineProfile to notify about downloads. The WebEngineDownloadItem exposes a subset of Chromium's content::DownloadItem functionality. For now we expose minimal requirements to be able to control downloads in QML but this can be extended in the future. This patch also adds a DownloadView to quicktestbrowser to demonstrate the usage of the new API. [ChangeLog][QtWebEngineQML] Add QtQuick download API Change-Id: I8d8f0daf02c4e0151000427fc2a4b37d28b9db52 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | | API for controlling tracking of visited linksAllan Sandfeld Jensen2015-01-087-3/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also fixes updating the visited links manager when off-the-record changes or a storage path is set or changed. Change-Id: Iffa90edde35f2d84146f3ab3b3861ef113e321f3 Reviewed-by: Robin Burchell <robin.burchell@viroteck.net> Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
* | | | Disable the GPU thread completely when Qt uses ANGLEJocelyn Turcotte2015-01-071-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ANGLE doesn't support multithreading and we already disabled WebGL and accelerated canvas drawing for that reason. It's still wrong to let the GPU thread do tile texture upload through ANGLE while Qt is using it in the scene graph thread for that reason, so ask Chromium to get tile images and let QtQuick do the texture upload itself instead. This means that Chromium will never use ANGLE directly for drawing and will fall back to its software compositing code path, but we still get hardware accelerated compositing by handing out delegated frames to QtQuick. Change-Id: Ia0bf9b8f6c462106866899f79a502ae161472122 Reviewed-by: Michael Brüning <michael.bruning@theqtcompany.com>
* | | | Do not use QDir::separator()Allan Sandfeld Jensen2015-01-075-15/+16
|/ / / | | | | | | | | | | | | | | | | | | | | | Build all paths Qt-style using / separators, and only convert it when converted to Chromium types. Change-Id: I181be6edb903f38e1772bcd324972d1d4e6672fc Reviewed-by: Pierre Rossi <pierre.rossi@theqtcompany.com>
* | | Don't crash when using onEditingFinishedPierre Rossi2014-12-193-0/+128
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to stay in line with the behavior expected by Chromium, we focus the view on load. This is problematic when relying on the editingFinished signal of text inputs in QML, as it is fired both when pressing enter and when losing focus. In our case, this would lead to reentering into load and in turn QQuickWindowPrivate::setFocusInScope, and when returning from the outer call, QQuickWindow would try to access the RWHVQtDelegateQuick from the first load through a now dangling pointer. It seems preferable to guard WebContentsAdapter::load against recursion. Adds a simple autotest that covers the crash scenario. Task-number: QTBUG-42929 Change-Id: Ib3bf9f421b1a91645b3e0e9aa658f2a3646d9caf Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com> Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
* | | Update public API test expectationsAllan Sandfeld Jensen2014-12-121-0/+27
| | | | | | | | | | | | | | | Change-Id: I0b9a35c59d6eadb426143c041538ebb9c9d6d800 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | Make deserializeNavigationHistory staticPierre Rossi2014-12-121-1/+1
| | | | | | | | | | | | | | | | | | | | | Fixing up an oversight. Change-Id: Ie09a93380b56b5f9314f43206eedbd5f1f36f2a2 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
* | | QML API for WebEngineProfilesAllan Sandfeld Jensen2014-12-1211-13/+541
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduces the QML API for the WebEngineProfiles already implemented for QtWebEngineWidgets. [ChangeLog][QtWebEngineQML][QQuickWebEngineProfile] New API for profiles applying to groups of QQuickWebEnginePages. Change-Id: Ideccddb9f1fb19628297592fe0cec504c9890e46 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
* | | Introduce QWebEngineProfile APIAllan Sandfeld Jensen2014-12-1220-475/+1211
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Introduces initial widgets API for the Chromium BrowserContext. Adds API for controlling cookie jar policy, user-agent string and cache and persistent data paths. Similar QML API will follow in another patch. [ChangeLog][QtWebEngineWidgets][QWebEngineProfile] New API for profiles applying to groups of QWebEnginePages. Change-Id: I3c4ef4053fde7564af29178c91a0aca8a2b61a5f Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | Update the version number to 5.5.0Jocelyn Turcotte2014-12-041-1/+1
| | | | | | | | | | | | | | | Change-Id: Ice525f351fab9db9208611a5b0efa04f5232365d Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
* | | Enable running on the wayland platform pluginLaszlo Agocs2014-12-041-1/+1
| | | | | | | | | | | | | | | | | | Change-Id: I472279f6f391b036f5af9eb6a07f6803b3786320 Reviewed-by: Andy Nichols <andy.nichols@theqtcompany.com> Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
* | | Use in-memory caches for off-the-record browsingAllan Sandfeld Jensen2014-12-034-21/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | Off the record should leave no record, which means we should not use disk storage for cookies and cache but instead trigger memory caching. Change-Id: I3e14ed0f91f925bc65675d2e7d9f07eb379a30b0 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com> Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | Do not allow taking snapshots with setting ignorecase=true.Zeno Albisser2014-12-031-0/+6
| | | | | | | | | | | | | | | Change-Id: Ia0cec7f1498c3459ec1d1ce6ab807994c04564e2 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
* | | take_snapshot.py: Do not adopt .gitattributes files.Zeno Albisser2014-12-031-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Some of these files enforce crlf conversion. For packaging reasons we have to make sure we never have crlf in our repository. Change-Id: I3b4da212c587f8461819f3d01e4967ebefaef4b0 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
* | | take_snapshot.py should only clear directories.Zeno Albisser2014-12-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Specifically we want to keep the file src/3rdparty/.gitattributes. Change-Id: I76f3fe6d6f8b8477834e31a4806f23928a0ca010 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
* | | Whitelist/Blacklist several files for the snapshot based on Chromium ↵Zeno Albisser2014-12-031-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 40.0.2214.5. Include files related to: - components_strings - chrome_version.rc.version - error_page - *.grdp files within components Exclude files related to: - junit - polymer - google_input_tools - cython Change-Id: I2388ec7694890d573cbea843de23471c6a5395a6 Reviewed-by: Andras Becsi <andras.becsi@theqtcompany.com>
* | | do proper escaping before replacingStephan Binner2014-12-021-3/+5
| | | | | | | | | | | | | | | Change-Id: I9d11038779494a3bb14107369b54c06baead96a9 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | Merge remote-tracking branch 'origin/5.4' into devAndras Becsi2014-12-0125-64/+387
|\| | | | | | | | | | | | | | | | | | | | | | | | | | Conflicts: src/core/access_token_store_qt.cpp src/core/access_token_store_qt.h src/core/content_browser_client_qt.cpp Change-Id: Id319ad0d87ce071e63d9c6c22b4fc35523ddfa74
| * | Fix deployment problems with developer buildsPeter Varga2014-11-284-2/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fix deploys the following files into qtbase without make install: - qtwebengine_resources.pak - translations/qtwebengine_locales/*.pak - icudtl.dat - plugins/qtwebengine/libffmpegsumo.so Change-Id: Id2c02f03fb01571942d3135b215ebb8ad7a3221b Reviewed-by: Andras Becsi <andras.becsi@digia.com>
| * | Merge remote-tracking branch 'origin/5.4.0' into 5.4Andras Becsi2014-11-2724-50/+383
| |\| | | | | | | | | | Change-Id: I2c48688f5f034233660bd7891693f81525fc1d6d
| | * Disable using the ICU data file on embedded linuxAndras Becsi2014-11-241-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Since we use the system ICU we do not need the extra data file. This fixes a crash caused by missing icudtl.dat file. Change-Id: Ic7a6ad83d6595ea3a89c736c281499636b05945e Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
| | * Use a relative install_name for QtWebEngineProcess' dependenciesv5.4.0-rc1Jocelyn Turcotte2014-11-201-2/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Until we can rely on Qt using @rpath on OSX, QtWebEngineProcess' dependencies must either be updated by macdeployqt when creating an .app bundle, either we must make that path relative at build time. Since QtWebEngineProcess.app is always deployed inside QtWebEngineCore.framework, we can safely assume that the dylib is always in a parent directory and that QtCore.framework can be found one directory higher. The additional dependencies of QtWebEngineCore.framework will be handled by the dynamic linker when it gets loaded, but this only works for QtWebEngineProcess when macdeployqt uses @loader_path instead of @executable_path (then relative to the application which is in a different directory than QtWebEngineProcess). This can be forced by passing a non-empty value for its -executable= command-line argument (e.g `macdeployqt Browser.app -executable=Browser.app/Contents/MacOS/Browser`) All this will be much simpler once we got Qt framework builds to use @rpath instead in a future minor version. Task-number: QTBUG-41611 Change-Id: Ied46c65a09f7033b622708da6e3d85855f9abf34 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
| | * Doc: Fix issues related to example docsTopi Reinio2014-11-175-2/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add documentation for Quick Nano Browser - Add all examples to the correct group - Add instructions to run the examples - Qt WebEngine Widgets index page: Add examples section Task-number: QTBUG-42668 Change-Id: Ie60f8708336b9c147d0c22afb555fe87287deddc Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by: Venugopal Shivashankar <venugopal.shivashankar@digia.com>
| | * Add missing header guardsPierre Rossi2014-11-152-0/+8
| | | | | | | | | | | | | | | Change-Id: I67d0040c2e9f00e8a7b842ac1228212c0e93873c Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| | * Process touch events in sorted order.Zeno Albisser2014-11-121-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are mapping a single QTouchEvent to multiple MotionEventQt for Chromium. For gesture recognition it is important that these motion events are being processed in a sorted manner, as a move event might trigger a different gesture depending on how many ACTION_DOWN or ACTION_POINTER_DOWN were received before. It is particularly illegal to process an ACTION_MOVE with multiple touch points without having received a ACTION_POINTER_DOWN before. Change-Id: I75d22dd845774a14b5f590e0e0ce46263c4a49f4 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com> Reviewed-by: Andras Becsi <andras.becsi@digia.com>
| | * Add a stub AccessTokenStore implementation.Robin Burchell2014-11-125-0/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | Callers inside Chromium expect an implementation of AccessTokenStore to exist. This fixes crashes with the geolocation-based APIs, exposed on e.g. google.com when faking an Android UA (as well as other places, probably). Change-Id: I45e6b483e096d5165fefd86927cdf34e799cc4d9 Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
| | * Merge remote-tracking branch 'origin/5.4' into 5.4.0Oswald Buddenhagen2014-11-121-2/+2
| | |\ | | |/ | |/| | | | Change-Id: I3b7df1ada08a8985734d804208b50cd5e0403903
| | * Disable accelerated 2D canvas rendering with ANGLEJocelyn Turcotte2014-11-111-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ANGLE isn't thread-safe and we're already taking a risk by letting Chromium do texture upload from the GPU thread with a shared GL context. Any kind of drawing happening concurrently between the GPU thread and the Qt scene graph thread might currently end up drawing on the same device context and this is creating visual artifacts and Direct3D errors. We're already disabling WebGL but we should also disable accelerated 2D canvas rendering to lower that risk. We should ultimately disable ANGLE from within Chromium or fix multithreading issues to properly support GL rendering scenarios across threads. Task-number: QTBUG-41627 Change-Id: I37a7a778f0e1066a454f51bb38e98df4dea8767e Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
| | * Merge "Merge remote-tracking branch 'origin/5.4' into 5.4.0" into ↵Jani Heikkinen2014-11-1016-42/+71
| | |\ | | | | | | | | | | | | refs/staging/5.4.0
| | | * Merge remote-tracking branch 'origin/5.4' into 5.4.0Oswald Buddenhagen2014-11-1016-42/+71
| | | |\ | | | | | | | | | | | | | | | Change-Id: I01615a492c958bf123deeef5d2ddf9fb01b1a9d0
| | * | | Update snapshot sha1 to include various crash fixes for the release.Andras Becsi2014-11-101-0/+0
| | |/ / | | | | | | | | | | | | | | | | Change-Id: I2d04e910c7a08e1c630bc490d1f8b1be3d27a6f1 Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
| | * | Disable error page while testing loadFail signal of Quick APIPeter Varga2014-11-062-15/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Error page should be disabled while testing loadFail signal since testing signals of the internal error page is not possible yet. Change-Id: I07f0bb6378fcbf5d18634197808801c94606803c Reviewed-by: Andras Becsi <andras.becsi@digia.com>
| | * | Fix crashes in QQuickWebEngineSettingsPeter Varga2014-11-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove QQuickWebEngineSettingsPrivate object's pointer from the global setting list before the object is destructed. Change-Id: I1cca6bf8aa2438903692d9e2ef863c8fc543adbd Reviewed-by: Andras Becsi <andras.becsi@digia.com>
| | * | Deploy external data in QtWebEngineCore.framework for framework buildsJocelyn Turcotte2014-11-064-16/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is currently no convenient way to deploy QtWebEngine into an application bundle on OSX. macdeployqt copies frameworks into a .app bundle's Frameworks directory but this makes no sense unless all the needed files are also distributed with the bundle. This patch moves: - The ffmpegsumo.so library into Libraries/ - Locale .pak files, qtwebengine_resources.pak and icudtl.dat into Resources/ - QtWebEngineProcess into its own .app bundle, itself into Helpers/ QMAKE_BUNDLE_DATA is used to copy files into the bundle while INSTALLS is used when installing normally. A LOCALE_LIST is explicitly listed since QMAKE_BUNDLE_DATA can't handle the * glob to match all source files. Change-Id: I5c0df57b4b9e93f9cce34a74a6e024bf90d37b5c Task-number: QTBUG-41611 Reviewed-by: Zeno Albisser <zeno.albisser@digia.com> Reviewed-by: Andras Becsi <andras.becsi@digia.com>
| | * | Move extra installs from core.pro to core_module.proJocelyn Turcotte2014-11-062-27/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | core_module.pro is the one responsible for deployment of the binary so it makes sense to also let it handle the other files to install. This leaves core.pro to only handle sub-projects dependencies. Change-Id: Ibe433eceec7fb0a9f806dfa89dccb0bedeaccc59 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* | | | For correctness fileListingHelper template function must return some value.Zeno Albisser2014-11-281-1/+1
| | | | | | | | | | | | | | | | | | | | Change-Id: I8f1c109bfeae72971539a68dfd1216d1bd185951 Reviewed-by: Andras Becsi <andras.becsi@digia.com>
* | | | Make BrowserContext name configurableAllan Sandfeld Jensen2014-11-263-10/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a name to BrowserContexts to separate cookies and cache paths. Change-Id: I3f00444dc7e87d1a63383053e91a4bc7056553bb Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
* | | | Don't use Q_FOREACH on QHash::valuesJocelyn Turcotte2014-11-251-5/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | QHash::values will copy all values into a new QList, increasing the ref-count of all stored QSharedPointer temporarily. Use the QHash iterators directly to avoid this. Change-Id: I49b1af24b706da195dc4df7206133f039198aad7 Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>