| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: I3a9143c61ecda98513be031fc554fd4bfcef7b7c
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
| |
GYP_ARGS needs a -D option before defining a value.
Change-Id: I4acb78e3f201a5d7369c3e998eb7356769bb7553
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
GetViewBounds should return the bounds of the view, not the screen rect.
The view bounds are for example used to calculate the screen position of
accessible objects (which gets fixed with this patch).
Change-Id: I5b342113af737847c1756a13183cd2b8b8db648a
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
| |
Change-Id: I37a32bd5dd8760bc91173968a620a1932ae67b4e
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: I0301ed0403b56169e610cf1c38a1e5da39ee164f
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
| |
This is in line with how other platforms do it.
Change-Id: Ia258511d3fa35387a69c81c9c02c181fc2995e6c
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
| |
The blink root element already has document as role. By setting it in
the webview we'd get two documents in the hierarchy.
Change-Id: Ie14e57b4e2050dbd9495c4fa94de4e2faebc02c1
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
| |
This is in line with how other platforms do it.
Change-Id: Ia258511d3fa35387a69c81c9c02c181fc2995e6c
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
| |
With this patch the accessibility hierarchy inside webengine becomes
available when navigating from QWidget based web views.
Change-Id: Ib3625a6ec93b4d3f298fb845ab85209b348349ba
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit adds the basics to bridge the blink
accessibility classes to QAccessibleInterfaces.
Note that it needs two follow up commits to implement the bridging from
the QWidget/Qt Quick worlds.
[ChangeLog][Accessibility] QtWebEngine now has accessibility
support, enabling assistive technology such as screen readers to work
with it.
Change-Id: Ied1d97e61a024115ac7a9245331211f6d9fac1b4
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since 3cd70c11bc7bbe3c5e9e4972d2273cf51bbdc30e in
qtbase Qt modules require cmake tests to be present
which makes QtWebEngine fail with "Missing CMake tests."
We do not support building with cmake at this point,
so disable these tests by setting CMAKE_MODULE_TESTS
to '-' for module pro files.
Change-Id: I777e6b2c7ce975ad021281800987f9d3ce173399
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Requesting MediaAudioCapture would unconditionally ask for
QQuickWebEngineViewExperimental::MediaAudioVideoDevices instead of
MediaAudioDevices since the if wrongly tested for the same condition
twice.
In addition fix a warning: variable 'feature' is used uninitialized whenever 'if' condition is false
api/qquickwebengineview.cpp:369:13: warning: variable 'feature' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
else if (requestFlags.testFlag(WebContentsAdapterClient::MediaVideoCapture))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
api/qquickwebengineview.cpp:371:57: note: uninitialized use occurs here
Q_EMIT e->featurePermissionRequested(securityOrigin, feature);
^~~~~~~
api/qquickwebengineview.cpp:369:9: note: remove the 'if' if its condition is always true
else if (requestFlags.testFlag(WebContentsAdapterClient::MediaVideoCapture))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
api/qquickwebengineview.cpp:364:4: note: variable 'feature' is declared here
QQuickWebEngineViewExperimental::Feature feature;
^
Change-Id: If63fbb5a59a71dede1d1829695f66c22849a4dcd
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
| |
Change-Id: I87d6532babc9475e46e28f6be7d1593622958764
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
| |
Change-Id: I4543cc9a42f803fd763b889cf7c36d8cfd54fc42
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
| |
Change-Id: Ie4a2a75388f3db3316e3e333e2b8d578ade034ac
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is done by setting qt_egl_library and qt_glesv2_library to
the correct value depending on whether the build is using debug or
release config.
This also updates the 3rdparty submodule as necessary.
Change-Id: I536310073d1d2436f7ed529b935421f6c9a8cae9
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
| |
This patch makes it possible to reset the upstream chromium repository
to its baseline state.
Change-Id: Idff94a0f873e994716f77c83f4c5b79bcd48aec5
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This script should be ran whenever adding new patches to our chromium
snapshot and makes sure we keep the upstream build functional.
Having clean patches is beneficial to keep it possible to upstream
patches to the Chromium project, and to keep an overview of our changes.
An annotation is not needed if the patch is adding files to the chromium
snapshot that were removed by take_snapshot.py, thus are already present
in the upstream repository.
In these cases the non-annotated patch will be ignored by the scripts.
Change-Id: I46605c559825d9da2653036e9a12a2a5730330a0
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
| |
This makes it possible to use them in other scripts as well.
Change-Id: I8aa76c1a9be91c56fd232a592ac41de5079eb3c7
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
| |
Change-Id: I1b7bea888290be340b2e368f8e77b661e8d66018
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
| |
The .gitattributes and .gitignore files do not need to be present in
packaged sources, as they are for people using the Git repository.
Change-Id: I0c9cd62fae0c4f4ca75552cbac966e27cadac45d
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
| |
The test relies on events being propagated from the QWebEngineView to
its children. We should probably send those events directly to the
WebContentsAdapter to fix this kind of use case.
Change-Id: Ib5cc199fe8fc27c21603888b49334d1c1f71e575
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
Update the checks to cover the case where the count could be the same
with different URLs, and mark those checks as currently failing because
QtWebEngine doesn't have the logic preventing QUrl() to affect the
history.
Change-Id: Id0260d21d32d9e85fbd14f44536c2c93b6eb40b1
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a crash on Windows when dismissing a JavaScript dialog.
It was caused by the JavaScriptDialogController object deleting
itself and its private object from a method call and subsequently
trying to run the JavaScript dialog callback.
Task-number: QTBUG-39883
Change-Id: I74300c53943ec7ebc492362ef7d75d83aa1f8051
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
| |
Change-Id: Icc4219ace4121a4b30302e0348e48dc75cae54cb
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Use QUrl::fromLocalFile to load components from the installation
Qml directory. Using just the absolute file path wasn't a problem
on Linux, but did not work on Windows.
Other Qt modules are also using QUrl::fromLocalFile to do this.
Change-Id: I689c516dc63a6c966435eedb94441d7c9246dd25
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
| |
ICU data file is required by Qt5WebEngineCore.
Change-Id: Ifcbb1119e9dfe25b6a1bb206475176f21278c2a9
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Arrow keys and page-up/page-down was not working. These are detected
on RayKeyDown events which both the Win and GTK versions sends instead
of KeyDown.
Also fixes a mistake in reading the length of the UTF16 text string that
was using sizeof on a pointer.
Change-Id: I441ef21c15430dafcaeda00d43eb9aec81cd88b8
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Preventing failure while applying patches on submodules that are
skipped on Windows.
Non Windows related submodules are not checked out from upstream
repository. This behavior is a workaround for git issues.
Change-Id: If34d9d2916829f87c7397a07803f79c156c05c57
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since all quads are already separated in non-intersecting geometries
and ordered according to their depth by Chromium, there is no need to
keep any z value once the perspective projection has been applied.
Avoid the useless computation and project the quads to z=0 the same
way that QMatrix4x4::toTransform() does when used to flatten
QQuickItem::transform().
Change-Id: I3ec5dc2da23cf431e2d8d0bb8b1ed48f2f2d2d8e
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the default behavior of gfx::GLContext, but explicitly do it
for documentation purpose and cover the case of the behavior of
gfx::GLContext would change in the future.
This also updates the submodule to include the change that uses this
value.
Change-Id: I214376d92b4f9f11bd491c2b1263cf8159e5779f
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
| |
This hides the prepared patches directory for upstream
builds and gyp cache files produced for idl files.
Change-Id: I340e5f6af5169810a780c9295d19bc7ce5fefd8c
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
| |
- Add valid size to tst_faviconLoad.qml
- Add missing files to qmltests.pro
- Rename test cases and files from WebView to WebEngineView
Change-Id: I40163117a11672b18230046a1604624bc4620dba
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: I5f16a2f824112bdfa2c50b3e4d93d6d47e34ba1b
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We maintain them on top of the Chromium snapshot.
A new script tools/scripts/patch_upstream.py replaced
patches/patch-chromium.sh with the recent snapshot update.
The patches that we have on top of the baseline version
are prepared from the chromium snapshot and applied on
the upstream chromium checkout.
A consequence of this is that init-repository.py -u
from now on requires a snapshot checkout as well.
Change-Id: I639c45904b72952804e5227ebc948a8859cf74dd
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch also changes the way we handle our patches.
We'll always take a new snapshot without patching Chromium
and rebase our patches on top of the snapshot. This removes
the need for separate patch files for the ustream repository
since we can use the patches of the snapshot and apply them
on the upstream checkout if we want to use an upstream build.
This makes it easier for us to have branches for the release
and maintain and minimize the number of patches we need on
top of upstream Chromium.
For now a snapshot checkout is needed to be able to prepare
the patches for an upstream build but in future we cold improve
this to fetch the patches from the remote snapshot repository
if needed.
Change-Id: I6280ffbe2d50d25d252734bc76d19bfaaa081637
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
| |
This flag makes it possible to initialize an upstream repository
without applying the QtWebEngine patches, which will be the used
to take a new snapshot, on top of which we will rebase our patches.
Change-Id: I89a6a135bb457edfc31c24a052f1732fb70299dc
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
With Qt 5.3 mac_sdk_path ends up being empty, so make sure to set
the proper flags for chromium to pick the right sdk.
Also add clang_use_chrome_plugins=0 so we can remove it as well from
the Mac-Use-libc-instead-of-stdlibc patch.
Change-Id: Ia132f079f905761644ad26c728f7116f538ea62d
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
| |
This will be useful when updating the snapshot and rebasing patches.
These patches need updated IDs to keep the gerrit database happy.
Change-Id: I62e9fc11a902f57497a2693cc59b873f13cfce12
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
| |
clang complains about unknown scoped_refptr
Change-Id: Iee7590f9ad45cab55a5918bf1c756aa769fa3fd9
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
The argument should not be added to the mutually exclusive group
but to the parser itself to make it usable with upstream checkouts
as well.
Change-Id: If2361c7beb0463a471cea9ce01e18a51abeed4ee
Reviewed-by: Jeff Rogers <jrogers@blackberry.com>
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On QNX platform, we implement video streaming via OpenGL
EGLStream streams. Changes were added to StreamVideo class
to support EGLStream objects. For non-QNX platforms, we
kept the StreamVideoNode class unchanged - assuming other
platforms will continue to support streaming via EGLImage
objects.
On QNX, cc::StreamVideoDrawQuad contains an
external OES texture that is associated with an
EGLStream. Before we draw with that texture, an
'acquire' is performed to grab latest video frame.
See EGL_KHR_stream specs from Khronos.
Change-Id: Ia3fe25e9047f475594a55591e3e11caa0eab1e6a
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
| |
Currently some variables defined in os independent section.
Change-Id: I661d840b2271dc4bccf98dc2a252feaf6907952c
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The findNext flag tells the frame to search starting from the current
selection, but the code assumes that the flag won't be used when there
isn't any find selection (like when the Frame changed).
Make sure that we won't use that flag after we received a load
committed signal.
Change-Id: I10f0f84226232d150f19fd644d7afe78bc425f74
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
QPlatformBackingStore still doesn't enable blending when compositing
a QOpenGLWidget with the rest of the widget tree. This means that a
tranparent pixel will show as black.
Until we get to properly go through the work of making it possible to
render a transparent webview, set the glClear color to white in order
to avoid seeing any black background before we get our first frame
from Chromium.
Change-Id: Idf7bb831a3b0d62b02f2527e2a15d830bf1e8ad4
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
|
|
|
|
|
|
|
|
| |
We had the logic in place to detect mocable cpp files all along,
but only used it for headers.
Change-Id: I00ea4e3ba081c5c7d37fe35ec78233e4961481e3
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
Use eglContext instead of eglcontext as a parameter of
nativeResourceForContext() function on windows:
qtbase/src/plugins/platforms/windows/qwindowsnativeinterface.cpp
Change-Id: Id6b4b5b6b8befad5b8a20b44e1c2a80c034921f9
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
Cygwin is still required for build on Windows. It was accidentally
blacklisted. Utils in cygwin used by third_party/WebKit build and
gyp uses cygwin for wrapping linux style commands on Windows.
Change-Id: Ifac069c67ebd1bef2f41618e7688d3b64028517b
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: Iee7f3dc7fb9deba03e57a80ed48b74069490fe0d
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
| |
Lookup the correct UIDelegates import path once lazily, and reuse
this information. If there is none, then we don't expect any UI
delegation to work, but it should not crash.
Change-Id: I73be7273d83b8d89b74641dc550341cf2b7eb602
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|