| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: Ic5ec80679f19235f441108e99e06d489ff2cabc3
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
| |
It has a section that tree times appended on Windows because qmake does debug_and_release.
Change-Id: Iba86e578a52846cf0e95e1e7c901879ef5f8ea0b
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
| |
On Windows a python file without extension is not runnable by itself, it needs the python executable.
Change-Id: I99cbfadc790acf3b3205faf6b940c26fb3c71e89
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This provides a stub implementation that renders quads and RenderPasses
using QSGNodes in QQuickWebEngineView.
The BackingStore code path is still supported when the delegated renderer
switch is not enabled. To use the new rendering, pass the following switches:
--enable-delegated-renderer --enable-threaded-compositing
This uses debug, plain color textures until we can fetch tiles and
textures from the ResourceProvider across OpenGL context boundaries.
Change-Id: I33ea0738dc5a326ef79c1435f75c044c42e8551f
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
| |
Change-Id: If3617d86ea44f665a44a54b6ba57935b69220a9e
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
| |
Change-Id: I48c0ed54cd946f223dc050b8a1f26282b02964a2
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
| |
Something seems to be busted with 5.2 lately. Specifically on Mac.
Work around the problem for now.
Change-Id: I4180257f31e67d02d46e26808e8b044f3b0c0cd2
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
We have to disable forward declaration of objective-c
types in Qt when building chromium code.
Chromium does have different, incompatible
forward declarations.
Change-Id: Ib7f7e9839e5c85d758d1e5bb921e67c57a55c4ef
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This is essentially the widgets part, with some tricks to get it to
honor the widget's context menu policy.
It enables c++11 for the widgets library for the convenience of using lambdas,
which admitedly we could do without, but seems reasonable considering our timeline
and the fact that we build chromium that way.
Change-Id: I6a632a78d2aa48fb0dfecfe491e92651d12407db
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
Also remove 3rdparty_upstream from from submodules, accidentally
added in https://codereview.qt-project.org/#change,67241
This fixes init-repository.py.
Change-Id: I08c095e4830581156efc3f069e00e733dda1ffd8
Reviewed-by: Adam Kallai <kadam@inf.u-szeged.hu>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
| |
Long live the new v4 (formerly known as v4vm)! :)
Change-Id: I9648e43276abb332b270a7c788a4bbff7334b919
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
| |
Change-Id: Ibde02d2ef64f2684ccf626b908aad9721148297a
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
| |
Set favicon image source to the value of the icon property, not the
url. D'oh!
Change-Id: I411f787f4f19fbeb2db9a61e4aada79b3527dcfb
Reviewed-by: Arvid Nilsson <anilsson@blackberry.com>
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This exposes loadProgress in both widget and quick webengineviews.
However, the progress will not change until we get an upstream change
in Chromium where the content LoadProgressChanged API is exposed to all
ports, not just Android. The upstream change is
https://src.chromium.org/viewvc/chrome?revision=221010&view=revision
Once we get that change, you'll see the widget example browser start to
paint a blue progress rectangle in the background of the URL bar. Also,
a progress bar was added to the quicknanobrowser, but it will be stuck
at 0 for now.
Change-Id: Icbaa01b86c013e0052b3abb7672c38e57128f44a
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a favicon API modelled after the WebKit2 QQuickWebView API, but
using an http(s) URL instead of a custom protocol, because there's no
icondatabase yet.
The icon URL lingers even when a new load is committed, until the load
finishes. It might be more prudent to clear the icon when committing a
new load, but I opted to let the app take care of that detail if
desired. Many browsers show a spinner instead of the favicon while
loading, for example.
There's no widget API implementation for favicons yet, because that API
only makes sense if we have a full-fledged icon database (case in
point: QWebEngineSettings::iconForUrl()).
Change-Id: I1e7b85104c80de2ae46a5fe9a273104d43a5c71f
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
| |
Change-Id: I7ef26e4a2e6c9eb228bcf5542ad272b998f8c6a3
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
| |
Change-Id: I7dd9f77c131afdaaae476a8574bae114540f1ee6
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
| |
We should not not use the $$ syntax to collect the output of the gyp
call instead we should just fail with an error in case gyp_qtwebengine
fails.
Change-Id: Ib6218bdfb998100a3717470713ed5bf5f30db339
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
| |
Change-Id: I240da0d785eaddc81701f36862f1e29d83d686ae
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
| |
This option initializes the upstream chromium repository
and additionally to the submodules needed for the matching
OS it also clones submodules needed for Android.
Change-Id: I1df84973aabc10f5c839bc4e3db7c6024f2c5145
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using make_global_settings, we can pass along the compiler and linker
that qmake uses, still allowing overriding it through environment variables.
We generate qmake_extras.gypi and populated with the host and target compilers
so that it also works when cross compiling.
Based on patch by Pierre Rossi <pierre.rossi@digia.com>
Change-Id: Ia3789abeea88f4d3cde75c2cf07cc9de66d7afbf
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
| |
Iterate over all diectories specified in QMAKE_RPATHDIR and generate a
rpath linker argument for each directory.
Change-Id: I90948eee9ef9319017ce99138ae7146d50c9636a
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GYP has a section named libraries under linker_settings, as well as an
ldflags section. Previously, we put all of qmake's LIBS under ldflags,
but this patch extracts all "-l" entries in LIBS and puts them as
"libraries" instead of "ldflags". This causes our libraries to be
grouped together with chromium's libraries at the end of the linker
line, before they were grouped together with other ldflags at the
beginning of the linker line. Also, it fixes the build on my machine.
Change-Id: I0ff9cde0d954a928dc5e880d7ed822a7b8edbf64
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
This prepares the addition of a delegated renderer implementation
for the QtQuick view.
Use a template for the base class since the accelerated delegate
will derive from QQuickItem instead of QQuickPaintedItem.
Change-Id: I5619290c0023bafdd27f18dab9edc10f5fbbf838
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
| |
This value won't change and this will force us to avoid
spreading runtime checks.
Change-Id: I7928cbe12d75bacddb5ad5c0578ae9a25d7c138e
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
| |
This should enable namespaced builds of Qt and QtWebEngine.
Change-Id: I4c9d506d864b42a346026b980dcf3777b9680957
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
Fixes the ASSERT we were seeing on double clicks and
implements detection for triple, quadruple etc. clicks.
Double mouse clicks forwarded from QMouseEvent are swallowed.
Change-Id: I9be83f809805ab3dea7a508b648046238ce36a90
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
| |
Use the appropriate method to convert to base::FilePath::StringType.
Also removes unused and unneeded variables.
Change-Id: I6005e0e9b566a8bb4182005571a68d5b9da9b409
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
| |
Unconditionally return a 800 by 600 like in QtWebKit.
Change-Id: I6ae151d535fb35ad3420f17921be73ba55878945
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
|
|
| |
This is to unclutter git status --untracked
Change-Id: I782066cf24f0b9ddf7ab4e94d1feb0257bbe0c52
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
| |
This is not needed anymore since the ownership changed
Change-Id: I7bfbb51c79a0d48ca8197a9b3a5d18986ee40e36
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
|
| |
Change-Id: Ica9f675a63e6dd3707f842edd86d30d860f2614c
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
| |
Change-Id: I0d963ee8b38eacde269d51c2f180190ce7d03048
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implementation will download files to the standard
download directory and assign unique file names should
there be a file with the same name existing or being downloaded.
It should be replaced with some more sophisticated code that also
takes into account settings and user choice possibly.
For now, it is only added to make downloads work at all.
Known issue: We do not get notified about completed downloads even though
we are observing the DownloadItem objects.
Change-Id: I2b52246635d3fd1358edc6b648d470ff821bc9f1
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
Since the QWindow returned by the RWHV delegates was always 0 we never
actually propagated a valid WebScreenInfo to chromium.
Additionally the painting and scrolling in the backing store had to be
fixed so that the device pixel ratio is taken into account.
Change-Id: I22dc135e8e090362201292863ed911464b9fc133
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the necessary changes to handle
WebContentsDelegateQt::AddNewContents and funnel the callback
through createWindow in QWebEnginePage and QWebEngineView.
- Expose the AddNewContents callback through WebContentsAdapterClient
- Allow creating a WebContentsAdapter attached only on the Chromium side,
leaving the choice to QWebEnginePage to either adopt it and call
WebContentsAdapter::initialize to attach itself as the client, or
destroy it if the application isn't handling the call.
- Delay the InitAsChild handling in RenderWidgetHostViewQt when
it is called before an adapter client has been attached.
- Since WebContentsAdapterClient::CreateRenderWidgetHostViewQtDelegate
is only a factory method, not creating any link with the callee client,
allow using the creating window's adapter client to create the RWHVQtDelegate.
This allows an unparented delegate to be created instead of needing to
add numerous null-checks in RWHVQt.
Use content::WebContents::CreateParams::context for this purpose,
which can be used both when creating a WebContents ourselves and when
a new window's WebContents is created for us.
Change-Id: I032262e867931dc40a7c2eca0c993027a555f56e
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
| |
Change-Id: I574ce207384e084c8b65cd66114e47e01cd4f42a
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the build_all option on Mac for now to prevent building
both debug and release libraries in the same run since it causes
linking issues with framework builds of Qt because of the
platform suffix of debug libraries.
Eventually the build system should be adapted to Mac specific
configurations.
Create unix binaries instead of app bundles to ease testing since
currently the examples need DYLD_LIBRARY_PATH to run.
Change-Id: I7fe3a7e6963510fb5a8863d9e68df487c168ff20
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
| |
Comment out QT_NOT_YET_IMPLEMENTED in MovePluginWindows and
SetTooltipText since they make too much noise and hide every
other message. Add missing macro where it might be useful.
Change-Id: I6a5b7bb677cfa5e74521a06955338552a6b011f0
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
This is needed to handle createWindow where a WebContentsAdapter will
be created to wrap the new WebContents and will passed up through the
API. If the application doesn't handle the callback, this will allow
managing the lifetime of the WebContents more easily.
Change-Id: I40ae1973a9bdf8c3d75f9ff137228d48ed92cfb2
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
| |
This isn't needed since the ownership was removed from WebContentsDelegateQt.
Change-Id: I44755966fd7681c638da083803cfde6262cb2dc2
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
| |
Flatten the ownership tree by removing WebContentsDelegateQt from the
ownership chain of the content::WebContents.
This also let WebContentsAdapter do the needed initialization work.
Change-Id: Ie652bbcad54799b66d28a4a33e627f667b1c0d28
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary to have a proper project
description with build instructions on
the gitorious page.
Other websites use rst, but it seems that
gitorious only supports md.
Change-Id: I5a987bca9a61e025f0ba81bb93ad2b9265a119b2
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|
|
|
|
|
|
|
|
| |
This fixes the ssh error where scp tried to connect to the default
port 22 which timed out.
Change-Id: I7914fafbc3f82eb2c68d52dffb6579d98bcfedd1
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
| |
This reverts commit e13b70626cdc593d9cfad48b9ffff6d4c4993585
since it seems to cause problems with the init-repository script.
Change-Id: Ie8a038041b3a17dcb0bb1f629285205a328a6819
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
| |
This should prevent them showing up in the pushed changes on gerrit.
Change-Id: Id750d8b80baffc61cba804840d2c1199e6372374
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
| |
Skip Mac specific tst_QWebEnginePage::macCopyUnicodeToClipboard()
which uses the unimplemented QWebEnginePage::setHtml.
Change-Id: I39c2d0d7b61517646e1702ca4f1ac119daef1585
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds --upstream (-u) and --snapshot (-s) flags to the
init-repository script which make it possible to choose the
Chromium sources to use when building QtWebEngine. The default
is to use the upstream submodules.
This option is persisted with git config and used throughout the
build system.
This patch also keeps support for the CHROMIUM_SRC_DIR env
variable which can be used to specify external Chromium
sources which are assumed to be set up for the build and
thus left untouched by the script.
Change-Id: Ic83984199770076f90867f1b22a63b220bfe7359
Reviewed-by: Zeno Albisser <zeno.albisser@digia.com>
|
|
|
|
|
|
|
|
|
| |
Blink uses the WebKeyboardEvent::keyIdentifier string to detect
Tab key presses. Make sure that we properly populate this field
before forwarding the event.
Change-Id: I7da52b5678cfc1bd7f433d9cc9cd4531e6a24728
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
|
|
|
|
|
| |
Change-Id: I0d6257d967413de93665e6bd3f06cb49d9e0607a
Reviewed-by: Andras Becsi <andras.becsi@digia.com>
|