summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix leak of properties after XkbRF_GetNamesPropKirill Burtsev2021-10-051-1/+11
| | | | | | | | | | | | Struct _XkbRF_VarDefs for XkbRF_GetNamesProp needs special cleanup logic, but it's currently missing from API: https://gitlab.freedesktop.org/xorg/lib/libxkbfile/-/issues/6 Workaround it with manual deinitialization. Pick-to: 6.2 Change-Id: I3ebe20f58199277521b31b2cd8034c92fd1f2b7f Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix leak on getDefaultScreeenIdKirill Burtsev2021-10-051-0/+1
| | | | | | | | | XRRMonitorInfo struct is supposed to be cleaned-up after getMonitors with a separate call to freeMonitors. Pick-to: 6.2 5.15 Change-Id: Iacc296d1f5e434a1d52798fe09d57833660b7952 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix theoretical use after moveAllan Sandfeld Jensen2021-10-021-8/+5
| | | | | | | We can't recover from a failure to post Change-Id: I6a5addf7346e36112e16878e3173048cf85fb7b5 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2021-10-011-4/+4
| | | | | Change-Id: I95d7aaf64e356827b3fc30100a9322414cd4a578 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Disconnect safelyAllan Sandfeld Jensen2021-09-304-3/+12
| | | | | | Pick-to: 6.2 Change-Id: Ic1c25724ea2d6c2241ab2665703380002efae8c3 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Change protected members to private in UIDelegatesManagerBalazs Egedi2021-09-301-1/+1
| | | | | | | | | There is no derived class from UIDelegatesManager any more. Pick-to: 6.2 Task-number: QTBUG-93666 Change-Id: I7316e7e37f1f5f5a40d0f2ea71344f093ab5ad1b Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix use after delete with self assignmentAllan Sandfeld Jensen2021-09-301-1/+4
| | | | | | | | Not sure this is actually used. Discovered in static analyzer Pick-to: 6.2 Change-Id: I1c143002e5da1ec809887626e348ea08a74b3715 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Fix move of moved valueAllan Sandfeld Jensen2021-09-301-1/+1
| | | | | | | | Do not call the copy to selection with the unique data source pointer. Pick-to: 6.2 Change-Id: Ie2c60e3efd2eb4e634bf95f8bdbe1ba8f1f89301 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix seeking on null QIODevice in pathological corner caseAllan Sandfeld Jensen2021-09-301-1/+1
| | | | | | Pick-to: 6.2 Change-Id: I5b242bc27f27a844d9d2fe0725e2a1f48e50b25b Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Doc: Fix broken attributions to the Public DomainLuca Di Sera2021-09-304-4/+4
| | | | | | | | | | | | | | | | | | | | | The attributions generated trough `qtattributionscanner` support generating links to SPDX licenses. Four such attributions used a `LicenseId` of `DocumentRef-PublicDomain`, which is a non-existent license. Indeed, the SPDX project seems to shy away from making a single license representing all Public Domain attributions, preferring to make a database entry for each Public Domain attribution. To avoid the broken link, such attributions were modified to use a dejacode LicenseId, which has a catch-all Public Domain entry, as suggested by Kai Köhne. Task-number: QTBUG-96127 Pick-to: 6.2 Change-Id: I88e0048c08d6099521e44e74ad7f0e8b3d77b907 Reviewed-by: Kai Koehne <kai.koehne@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2021-09-291-4/+4
| | | | | Change-Id: I83872e0df636ff7c026440517ac436853e7a6f75 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix gn moc path pointing to debug moc for super buildMichal Klocek2021-09-281-1/+6
| | | | | | | | | | | | | | | | | | | | In 53e99bd we used genex to get moc path, this works well, but not for mulitconifg build where genex will output path to debug moc in case of superbuild. To fix issues like that cmake 3.20 introduces $<OUTPUT_CONFIG:...> and $<COMMAND_CONFIG:...> generator-expressions, however it will not help much since they do not work with file(GENERATE), moreover minimal current version is 3.19 Use target property to query moc location or recreate path in case of superbuild. Fixes: QTBUG-96375 Pick-to: 6.2 Change-Id: Ief0fc32d57a36191694102ed010314b5d3395334 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2021-09-281-4/+4
| | | | | Change-Id: Id7c3a572c0991b23a268ffb2aea9bceb18e80502 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Do not require widgets for quick examplesMichal Klocek2021-09-273-17/+2
| | | | | | | | | | | We needed widgets to get qqc1 styling, since we now use only qqc2 drop that requirement. Fixes: QTBUG-96771 Task-number: QTBUG-95367 Pick-to: 6.2 Change-Id: I7338cd04885069169fef1c4bca17e0777b11de8c Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix extract_cflag cmake function to not add extra semicolonPeter Varga2021-09-271-0/+1
| | | | | | | | | | LIST(APPEND cflags ...) separates appended elements with a semicolon. This may break parsing cflags and can result invalid args.gn. Remove semicolons from cflags before parsing it. Pick-to: 6.2 Change-Id: I3898bcad2051276d44953ae72d87cf4f91516012 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix WebChannel when JavaScript is disabledSzabolcs David2021-09-273-9/+40
| | | | | | | | | | | | | WebChannel was not working in ApplicationWorld with JavaScript disabled in MainWorld, because WebChannelIPCTransport::DidClearWindowObject() is called only when the window object was cleared in the main world. Moving the WebChannelTransport installation logic to DidCreateScriptContext() works in other worlds, so fixes the problem. Task-number: QTBUG-88875 Pick-to: 6.2 Change-Id: Ia75613b66a1e049f617f0664684b153b6875e9de Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix no webrtc buildsMichal Klocek2021-09-261-2/+6
| | | | | | | | | | | In case of ozone x11 backend we need x11, which is pulled by use_webrtc_x11, however in case of no webrtc build we lack x11 dependency. Add missing dependency. Change-Id: I19eada846115073251cdf85ce1fabd4d1d2baf2e Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 630062f1189b95689e28e40c5c76d95d3214d123)
* Doc: Fix QDoc warnings for licensing documentationTopi Reinio2021-09-241-0/+16
| | | | | | | | | | | | | | licenses.py takes the value of the URL attribute directly from Chromium's license attribution files, and uses it as a link target for QDoc's \l command. Some of the URLs are not valid, however. Add \externalpage entries for the invalid ones to either direct to the correct URL or to expand to an empty '#' link. Pick-to: 6.2 Change-Id: I06e9c54bceb5465c89de115cb8cd8aa0e75e9c51 Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Use qWarning() in preference to QTest::qWarn()Edward Welbourne2021-09-241-2/+2
| | | | | | | | | QtTest's custome message handler routes it to the same place and QTest::qWarn() is on its way to deprecation. Change-Id: I467b2ba81c87b2430a66a9f88c9ef0375dbbff45 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Fix use_lld_linker on WindowsAllan Sandfeld Jensen2021-09-241-0/+9
| | | | | | | | | We need to set the cmake base path, when not controlling the toolchain like on Linux. Pick-to: 6.2 Change-Id: I0e2f1ea76d9c52bb9bf867daa8fa2feceff3707e Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* CMake: Bump almost all cmake_minimum_required calls to 3.16Alexandru Croitor2021-09-242-2/+2
| | | | | | | | | | | | | Needed for subsequent change that will check and error out if the version is lower than 3.16. We do that to ensure all policies introduced by CMake up to version 3.16 have their behavior set to NEW. Pick-to: 6.2 Task-number: QTBUG-95018 Change-Id: I6385d1fc83af8a937f0e7987fade1178bfc9c487 Reviewed-by: Kai Koehne <kai.koehne@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2021-09-241-4/+4
| | | | | Change-Id: I164d33fc2cfb61bb488173ae0670d9f54992f165 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Apply separate_debug_info to QtWebEngineProcessAllan Sandfeld Jensen2021-09-231-5/+3
| | | | | | | | Was missing the calls to the qt cmake standard methods for that. Pick-to: 6.2 Change-Id: I47507c6fa89b7f3e66fe4eb7526f6fb6074f2293 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix "We mean it." warningsPeter Varga2021-09-233-0/+33
| | | | | | Pick-to: 6.2 Change-Id: I70a491617faff31901162cb382b388a7594816fa Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove our handling of IME hidden text supportAllan Sandfeld Jensen2021-09-225-27/+12
| | | | | | | | | | QtBase should be disabling it now, if not supported. Pick-to: 6.2 Change-Id: I79bae11764d3cbaba1ae1e0987bf0a472eee3325 Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Add run-time getter of patch levelAllan Sandfeld Jensen2021-09-222-0/+13
| | | | | | | | Unfortunately it requires manual updating, unless we agree on a separate place to store it. Change-Id: Ib150afec05005b05b254ef5aeb143f5187ea969d Reviewed-by: Michael Brüning <michael.bruning@qt.io>
* Make example consistent with documentationAllan Sandfeld Jensen2021-09-211-2/+2
| | | | | | | Pick-to: 6.2 Fixes: QTBUG-96002 Change-Id: Ib7434b568ffa0ad7998eaf66a8d989fc3cd2aa1d Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Ensure load in newly created page first before checking for UserAgentKirill Burtsev2021-09-212-3/+2
| | | | | | | | | | | | Condition to use UserAgent override 'ShouldUseUserAgentOverride' is only activated when DocumentLoader is set. This happen only after load, so test should check that before checking UserAgent. Task-number: QTBUG-76249 Change-Id: I3b966f8a2141ed656890ce922667e55be09c8676 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit e918a90f6c2166f753eb1516f115962968ef1cb4) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2021-09-211-4/+4
| | | | | Change-Id: Ic589c7ead626e11e348b609c157db6934dc1c40c Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix CMake error when configuring for cross-compilationPeter Varga2021-09-211-1/+6
| | | | | | | | | | | | The error is: CMake Error at src/CMakeLists.txt:166 (add_dependencies): Cannot add target-level dependencies to non-existent target "run_core_GnReady". Change-Id: I8adc3a90d18fc0edab39ba9a37eaf3e18636b30e Reviewed-by: Michal Klocek <michal.klocek@qt.io> (cherry picked from commit d8bf7df001670b879492743cd4431c5956708653) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Polish the markdown editor exampleFriedemann Kleint2021-09-203-17/+24
| | | | | | | | | | | | - Implement the exit handling using QWidget::closeEvent() - Mark PreviewPage::acceptNavigationRequest() as override - Use mime types with QFileDialog - Add status bar messages Pick-to: 6.2 Change-Id: I0fcbb1350f736a5ee04f266aac81942b7a269644 Reviewed-by: Cristian Maureira-Fredes <cristian.maureira-fredes@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Remove .qmake.conf from this repositoryJoerg Bornemann2021-09-201-8/+0
| | | | | | | | | | | | | | This file was necessary for the qmake build and the CI. The qmake build is history, and the CI does now read .cmake.conf (see QTQAINFRA-4392). In addition to being superfluous, the existence of .qmake.conf triggers QTBUG-76140 when building Qt examples with qmake. Removing the file alleviates the symptoms of this bug. Fixes: QTBUG-92271 Change-Id: I169796a041cf03fbbb4456839bdf45ff623a3639 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix rpaths on mac framework buildsMichal Klocek2021-09-181-3/+6
| | | | | | | | | | | | | | | | | | In case of framework builds webengine process needs LC_RPATH with @loader_path or @executable_path which resolves to the absolute path of the webengine process executable so correct value is @loader_path/../../../../../../../ Do not try to resolve relative path in qtbase because for some reason it can give different result on different build setups use fixed INSTALL_RPATH property. Fixes: QTBUG-96539 Change-Id: I6e8f8c15ac40c261a4f5e3c6b9ed8b4c168a38ec Reviewed-by: Michael Brüning <michael.bruning@qt.io> Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 310db2b8164fd2a8d9bed4bbf46faa674ff553cc) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix build when xcb only over egl/es2Michal Klocek2021-09-181-2/+3
| | | | | | | | | | | Qt's xcb can be compiled without the glx support, do not use Chromium flag to check that. Fixes: QTBUG-96398 Change-Id: Ie7f1fe74699cd83aee1f9e5aff59760d4d7a70bf Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 0fba07e0238a9ff0a1b496eae60ad92257ea76af) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix jumbo configurationAllan Sandfeld Jensen2021-09-171-1/+1
| | | | | | | | | The check was reverted putting more memory pressure on low levels, and less on greater ones. Pick-to: 6.2 Change-Id: I1d0afeb0b96ff2d4ccd6249e7dd7312375c2fad4 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2021-09-161-4/+4
| | | | | Change-Id: Iec34ee46e95ab0629d935589114d91f531cf6680 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Bump versionJani Heikkinen2021-09-140-0/+0
| | | | Change-Id: I3c160f49a109aabdc756fbef5af3c5a57ac53105
* Bump versionJani Heikkinen2021-09-142-2/+2
| | | | Change-Id: Icd8250391057bfde5f221e34a3502ea7da3a0cc2
* Rename Quick examples' folder from webengine to webenginequickBalazs Egedi2021-09-13126-62/+62
| | | | | | | | Fix webengine directory path in project files and comments Pick-to: 6.2 6.2.0 Change-Id: I06ed9ee41111e7135fa9feb152ad2a5eb2262b76 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Remove check for profile directory from favicon service factoryKirill Burtsev2021-09-111-3/+0
| | | | | | | | | | | | | Since the directory itself in initialized asynchronously this check may lead to desynchronization with how profile is considered to be off the record and what it really is. Subsequently, with a possible wrong initialization of a favicon service with invalid history service for non-otr profile. Pick-to: 6.2 6.2.0 Fixes: QTBUG-95580 Change-Id: I66fbb7914a303650490e1577989beee5cd883037 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix disconnect on null old page win Simple Browser exampleKirill Burtsev2021-09-101-11/+12
| | | | | | | | Eliminates constant warnings from QObject on every new tab create Pick-to: 6.2 6.2.0 Change-Id: I93b3a2561a8a99932ea2a8c77cc12ded4a6906e7 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Fix wrong save file filter for Markdown Editor exampleKirill Burtsev2021-09-101-1/+1
| | | | | | | | | Comma is treated as a part of suffix, and a separator is just a space. Fixes: QTBUG-95770 Pick-to: 5.15 6.2 Change-Id: I7b27ae98757418c4c09fc92804ecefd6373cbc48 Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Add Chromium version source documentationAllan Sandfeld Jensen2021-09-101-0/+3
| | | | | | | Change-Id: I9796f31dab4cac7f8fbf0fdc2474304f0cde8fc3 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit 9b10ac64734f76c635c96d902217fd9d954915c1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Fix drag and drop againAllan Sandfeld Jensen2021-09-102-6/+6
| | | | | | | | | | Return the right QObjects Fixes: QTBUG-96308 Change-Id: If04be10fe19db6b8c0552c7df588961c711c1250 Reviewed-by: Michael Brüning <michael.bruning@qt.io> (cherry picked from commit e85e4ab275fb0a0c072f19ed3d5c5b5b46de8321) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
* Stop listing Adobe Flash as a featureAllan Sandfeld Jensen2021-09-091-47/+1
| | | | | | | | This has been removed Pick-to: 6.2 6.2.0 Change-Id: I9f4be83d584427935bccfff3f23419a49c1664a4 Reviewed-by: Kirill Burtsev <kirill.burtsev@qt.io>
* Update ChromiumMichael Brüning2021-09-092-0/+5
| | | | | | | | | | | | | | | | | | Submodule src/3rdparty f8a944bb..202e3447: > [Backport] CVE-2021-30566: Stack buffer overflow in Printing > [Backport] CVE-2021-30618: Inappropriate implementation in DevTools > [Backport] CVE-2021-30616: Use after free in Media. > [Backport] Security bug 1227228 > [Backport] Security bug 1239116 > [Backport] Security bug 1216595 > [Backport] Security bug 1206289 > [Backport] CVE-2021-30613: Use after free in Base internals Pick-to: 6.2 6.2.0 Change-Id: I52c611ae7029baafcc182a6d66890f4bfff81d34 Fixes: QTBUG-96209 Task-number: QTBUG-96292 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Fix rsp workaround for super buildMichal Klocek2021-09-091-3/+8
| | | | | | | | | | | | | Since 9f4914248 we have poor man workaround for broken rsp files on windows with cmake. It requires copy of rsp files to directory where the linker call takes place. Adjust the output directory for super build. Pick-to: 6.2 6.2.0 Fixes: QTBUG-96266 Change-Id: Ib09add2d6069782ba25a820e950759932eefc457 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
* Update dependencies on 'dev' in qt/qtwebengineQt Submodule Update Bot2021-09-091-4/+4
| | | | | Change-Id: I209506807929535b0efbab9eea1bf27d58876ff7 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
* Fix runGn of qtpdf target for developer build with clangKirill Burtsev2021-09-091-5/+5
| | | | | | | | | | | | | | | Resolves an error on gn_config_cxx.cmake include: CMake Error at src/pdf/RelWithDebInfo/x86_64/gn_config_cxx.cmake:4: Parse error. Function missing ending ")". End of file reached. Lists for config vars may contain values, like -Wno-error=#warning for GN_CXX_COMPILE_OPTIONS, which cause parsing errors and should be quoted. Pick-to: 6.2 6.2.0 Change-Id: I983f5b23c9013d55f728ffe4354f6abbb0db1911 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>
* Support more module flags for 'configure' scriptKirill Burtsev2021-09-097-42/+105
| | | | | | | | | | | | Support flags passed to main 'configure' and separate 'qt-configure-module' scripts with flags like '-no-build-qtpdf', '-webengine-full-debug-info', '-no-webengine-jumbo-build', etc. Fixes: QTBUG-95717 Pick-to: 6.2 6.2.0 Change-Id: Ia12602e9a9b31f4f2256f983f6c1e3fbe50cb9e3 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> Reviewed-by: Michal Klocek <michal.klocek@qt.io>