| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because of weird interaction between deleteLater(),
Qt::WA_DeleteOnClose, and QQuickRenderControlPrivate::windowDestroyed()
which executes all the deferred deletions at a bad time, there were
some use-after-free crashes.
The workaround is not to close the window when the last tab is closed,
but rather create a new tab, like the behavior was on non-macOS
platforms.
Task-number: QTBUG-58982
Change-Id: I00295838c298af382cac78bb22c47d6de60e7755
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
The example did always set an application proxy, though it
was empty if no proxy was explicitly set in the system. This
however blocked the use of the system settings.
Task-number: QTBUG-58748
Change-Id: I50d9116e491cb7c1ab5b8fc610736d60e0bc9ea8
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, the MainWindow and QWebEngineView remains on the heap when closing
the application.
Task-number: QTBUG-59765
Change-Id: Ia643d1e919ca5f0a1d9405ba9b7ab72aabd8c051
Reviewed-by: Viktor Engelmann <viktor.engelmann@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
| |
It's going to be deprecated.
Change-Id: Iec967478785d327caa846a259fb8eeff18173429
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
|
|\
| |
| |
| | |
Change-Id: Iff6ab3c287c58d8ec84a1513460bfce5218e8a61
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Previously when Airplay was activated and a new QWebEngineView instance
was created, a black area would be rendered inside the view.
This happened because of incompatible OpenGL contexts. The global Qt
OpenGL context could not share its textures with the newly created
"after-airplay" context, due to the contexts being used by different
GPUs (only possible on a MacBook Pro).
The fix is to add the NSSupportsAutomaticGraphicsSwitching option into
the application plist file, which informs macOS that the application
supports usage of dual GPUs, and thus allows sharing of contexts
across GPUs.
Task-number: QTBUG-54053
Change-Id: Ic37fb75f164922bcca6456054174171fa9ba2bfb
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Instead of calling deleteLater, just tell close to delete the menu
itself.
Task-number: QTBUG-59080
Change-Id: I3eae382781f813ed3c6f27b78088b94ed1c486dd
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|/
|
|
|
|
|
|
|
|
|
| |
fullScreenNotification is a child of fullScreenView and should not be
deleted.
On multiscreen systems, the fullScreenView window was always shown on
the main monitor
Restore the main window position
Change-Id: I2c940306d06668ad52a2388832ceb48b4791779d
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
| |
The languages submenu was not working corectly,
languages could not be checked
Change-Id: I7221d3527dbd6e071eb8d1585fb6d90812c61f94
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of adding individual example projects into SUBDIRS from the
top-level examples.pro, add a .pro file for both /examples/webengine
and /examples/webenginewidgets that handles them.
This way, it's easier to e.g. build all webengine examples from
binary packages, as the top-level examples.pro is not packaged.
Task-number: QTBUG-57124
Change-Id: I8cf8ac7b13b86306b31bc43c79e3d8272193b1d3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I35a5c815c9f2b3ebacb5991ba6645641b17db2db
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
| |
Removes RequestType prefix from FormValidationMessageRequest's
RequestType enumeration members.
Change-Id: I51b7eb77b0bae2a8d3109e3ee3b7ea42349b211c
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|
|
|
|
|
|
|
|
| |
The example shows how to create and use custom dialogs
instead of webengine's default dialogs.
Task-number: QTBUG-56063
Change-Id: I440305b2d4357d2b47c6b5a1a821b25c71221aa2
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
| |
Task-number: QTBUG-56074
Change-Id: I2a66e91dd4ed1026e5ab2539cfd3f9094263b48c
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The change fixes spellchecking to work on macOS.
A new WebEngine configure option is available to allow spellchecking on
macOS to use either Hunspell like the other platforms, or the native
spellchecker that comes with the OS. The default is to use Hunspell.
Task-number: QTBUG-53135
Change-Id: I3e45b2e0d728b1bf2659c35f3d0a042b0ecd6239
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: I283365c72d351e62bc749cbc60e06472e52255ec
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
| |
Most actions do not make sense. A custom context menu might be good for
text actions, but would require reimplementing QWebEngineView.
Change-Id: Idf94939c16469e1dcee96d9ecfd0eb5309589fdd
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
|
|
|
|
|
| |
Change-Id: Ia7438535398aa9ae39d0c49e244c4cde05a55b89
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
|
|
|
|
|
|
| |
We need to delete the QPrintDialog.
Change-Id: I959f963ba2e44091acb0c762ac680037bccc5b43
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The example uses WebEngineView and Qt Quick Controls 2 items to
demonstrate how to write a small hybrid QtQuick / HTML application,
and also shows the usage of the new focusOnNavigationEnabled setting.
Task-number: QTBUG-52999
Change-Id: I1813a658a2f46e90f9ca4e8229a8c8fbb6590248
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
|
|
|
| |
Change-Id: I307103956bf50469a5c4cbe3656f655925f55653
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: I907f6ea73a1d707eda536764c4b0b2edea49a963
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Also blacklist tst_QWebEnginePage::comboBoxPopupPositionAfterChildMove()
and comboBoxPopupPositionAfterMove().
Conflicts:
.qmake.conf
src/3rdparty
src/core/render_widget_host_view_qt.cpp
src/core/resources/resources.gyp
src/webengine/doc/src/qtwebengine-platform-notes.qdoc
src/webenginewidgets/render_widget_host_view_qt_delegate_widget.cpp
src/webenginewidgets/render_widget_host_view_qt_delegate_widget.h
tests/auto/widgets/qwebenginepage/BLACKLIST
tests/auto/widgets/qwebenginepage/tst_qwebenginepage.cpp
tools/qmake/mkspecs/features/functions.prf
Task-number: QTBUG-55158
Change-Id: I1d73ac9b3ca5293ad3c7e3a56f4c395da930e6f4
|
| |\
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Conflicts:
src/3rdparty
src/core/resources/resources.gyp
src/webengine/doc/src/qtwebengine-overview.qdoc
src/webenginewidgets/api/qwebenginepage.cpp
src/webenginewidgets/api/qwebenginescriptcollection.cpp
src/webenginewidgets/api/qwebenginescriptcollection_p.h
tests/auto/widgets/qwebenginepage/BLACKLIST
And readded newly in 5.6 enabled tests to the BLACKLIST.
Change-Id: I4ab1fc54ebfaaf940df81b0d8d6bdd15cae8b7c4
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Remove backspace short-cut, Chromium will already handle that if it is
standard on the platform. Also we were not triggering on Back/Forward
buttons due to those being mapped to prev/next tab item in Qt.
Task-number: QTBUG-54546
Change-Id: I9a4f48c718c5685ca9ca1b032d8b04409ac622ca
Reviewed-by: Jesus Fernandez <jesus.fernandez@theqtcompany.com>
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
| |\|
| | |
| | |
| | | |
Change-Id: Ic6686df8f82f710a3441501b7eeaffe69fbcbdf7
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add a flag to let checkForExpired remove the entries directly.
Task-number: QTBUG-54222
Change-Id: Iddac9e50f645d74b95d0ea13ed76d7f858ddd137
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Setting the Qt::AA_EnableHighDpiScaling attribute makes sure that the
scrollbars are scaled, and that the default zoom level is sensible.
Task-number: QTBUG-54113
Change-Id: I0ae7eb97cb9e2824e7f9b92d77cf2986cac66685
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
[ChangeLog][QtWebEngineQML][QQuickWebEngineView] View Source feature is
now supported
[ChangeLog][QtWebEngineWidgets][QWebEnginePage] View Source feature is
now supported
Change-Id: Icc16da71fc6ec95880897fc9744dd8be8c004e00
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ied45cf010aef87e319a01274399938cff7c1a53e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This example demonstrates how to convert 'dic' dictionary files
into 'bdict' binary format using qwebengine_convert_dict tool.
It shows how to implement language selection. It adds two dummy
dictionaries.
Change-Id: Iffc23a0ed4e51cbc749f666c8f565fafb3739a9b
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|\|
| |
| |
| | |
Change-Id: Ib010ede9756fb02992a3276ae7ec90ef1ab56a00
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add missing include to fix
error C2027: use of undefined type 'QDebug'
on MSVC.
Change-Id: Icc62cdf36f417f30691445ab4994b822c8e37db9
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Application short-cuts override the passing the keys to WebCore, and
makes it impossible to type '/' in form elements.
Change-Id: I7df99547f99a3a0703d98d19d3ccdb23de0641ce
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This makes it possible to also test flash from simplebrowser.
Change-Id: I94677383fdbea4a723432ea6811ee72314c019fd
Reviewed-by: Alexandru Croitor <alexandru.croitor@theqtcompany.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Do not redefine QWebEngineView::iconChanged.
This fixes the following warning:
QMetaObject::indexOfSignal: signal iconChanged(QIcon) from
QWebEngineView redefined in WebView
Change-Id: I2489bfcf9379200f9bfa24345b56679f138894fe
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
This amends commit 213fbe76.
Change-Id: Ie5ca9f7713b0653e0e5241eb3e99644425a3b1e3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
src/3rdparty
src/core/browser_context_adapter.cpp
src/core/web_contents_adapter.cpp
src/webengine/doc/src/qtwebengine-platform-notes.qdoc
tests/auto/widgets/qwebenginepage/BLACKLIST
Change-Id: I768fc954a9a2147fc3669961286163a0a824def3
|
| |\
| | |
| | |
| | | |
Change-Id: I96aa7487c341f40c74832f00bc72995d25969329
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ifee9bb458de2c15760da21938b5e5bb598936161
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Passing just command line options to Chromium prevents loading of the
initial startup url. This happens because the startup url is
overridden by the last command line argument, which happens to be a
Chromium option, thus an invalid URL.
Fix consists in using the last command line argument as the loading url
only if it can be parsed as valid url.
Change-Id: I3615ef57b6eddc5098de79cba1b1ba6b6af193ef
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
In case of render epic fails, let the user
leave the loaded page with dignity.
Change-Id: I27f692fc0bb181c1d4f7ce43f5772d5573d7e385
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I2843a633721212850db77c772caf24e0ea82b450
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Current implementation of history manager seems to
be not straight forward. To display history we use QList to keep
history items plus model adapter in form of HistoryModel
(QAbstractTableModel) plus HistoryFilterModel to avoid
duplication, plus HistoryTreeModel to make a tree view with
split for dates, plus TreeProxyModel on top to enable
sorting. This approach unfortunately falls apart when items
should be deleted from the model by treeView. This ends
badly with corrupted cached values.
This fix removes history items using history manager.
It also abandons HistoryTreeModel since frequent sourceReset calls make
it unusable. If split for dates it desired the better approach
would be to implement history tree model already at HistoryManager
level to avoid unmaintainable code.
Task-number: QTBUG-49913
Task-number: QTBUG-50255
Change-Id: Ic9cebb52b623bd453119e11b5e907eaa90609e34
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Passing just command line options to Chromium prevents loading of the
initial startup url. This happens because the startup url is
overridden by the last command line argument, which happens to be a
Chromium option, thus an invalid URL.
Fix consists in iterating through the command line arguments, until
a non-option argument is found (doesn't start with a dash), and use
that as the startup URL.
Change-Id: Ibe2946b25b2e023c094a85e50d2ccbd5bfce2977
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
The standard pdf print dialog does not work on OS X and Windows.
Task-number: QTBUG-53016
Change-Id: Ic9dd1a1603e1cdbd82fef095cc660814bcd8c98e
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I329397621f19ba3890be5daf44a6bb2d668ad2d8
|
| |
| |
| |
| |
| |
| |
| |
| | |
Adds missing deleteLater on close
Change-Id: Id337856f138e0d38f0c72d3962ccac309d36c73e
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove the unused m_loadingUrl member.
Remove the loadingUrl signal that was forwarded to urlChanged.
QWebEngineView already emits urlChanged. There's no need to do this twice.
Change-Id: Ib9734c5b1571745f7b82b4e5f2bc92c7f1d8f51c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@theqtcompany.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Clear the model before saving. Otherwise the cleared history will appear
again after restarting the demobrowser.
Change-Id: I79f939c1f1e8ee993127d139cefe7f5818ce593c
Reviewed-by: Kai Koehne <kai.koehne@qt.io>
|