| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Pick-to: 6.2
Change-Id: I8402b044d8e12d75e144a00984b856f3de10bffd
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
| |
Task-number: QTBUG-51184
Change-Id: Ie050cb23f2c86841a66ec384bfbcdf0713cffa7c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\
| |
| |
| | |
Change-Id: Ia01415e5a44b1df9ed8b3966ff3b39a414b1563c
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Cover all cases from https://pdfobject.com/static
- Plugin placeholder is generally broken: displays garbage and crashes
on interaction. Fix it and show when PDFs are included by <embed>
or <object> tags.
- Do not start an automatical download when the disabled PDF plugin
was requested by an iframe. Show a clickable placeholder and let the
end-users start it manually.
- Remove unused class PluginPlaceholderQt
Task-number: QTBUG-76314
Change-Id: I01a0c93ab23f54e4272f5aeb30578de0dcf18932
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I0dd7c64669f4b130047a4a3836f62f7ee5b5f8d9
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Let Chromium know about the status of plugin availability from
WebEngineSettings. This way it can decide whether the response is
a download and it has more benefits:
- It doesn't have to start a new load request to download a PDF file,
it just treats the original response accordingly.
- Fixes websites which are protected from cross-domain requests (e.g. by
checking the Referer header) and/or redirecting requests for PDFs.
Calling DownloadManager "manually" and not passing the original request
headers did not work when the server relied on them.
Task-number: QTBUG-78114
Change-Id: I8cfa90c211418001c60c4b2f0f8818ee453101fc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the basic support of guest views, implemented based
on Chrome.
- Embed PDF as a child frame instead of navigating to its
extension WebUI. Keep the original URL (pointing to the file) to
extend functionality of PDF viewer with URL parameters.
- Make RenderWidgetHostInputEventRouter to work and modify most of
the event forwarding logic to use that. This way WebEngine supports
pages with multiple RenderWidgetHost and guest views can be
interactive with user input.
[ChangeLog] PDF files are opened as embedded objects, WebEngine
will not navigate the content away from the requested file to
present it. PDF viewer can accept URL parameters (e.g. to control
zooming or fitting to view). Also, PDF viewer is interactive
when displayed in a subframe.
Task-number: QTBUG-80463
Task-number: QTBUG-86152
Task-number: QTBUG-90712
Change-Id: Ib1591fbd9a594891cdeace8e9dae0d3cc21a9f8e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Register browser interface binders for PDF viewer. Copied back this
logic from the guest view implementation (from dev) to enable usage
of chrome.resourcesPrivate API in the PDF viewer of 5.15.
- Implement template replacements for extensions. Replace i18n
placeholders in the PDF viewer HTML to prevent syntax issues and
support localization.
Task-number: QTBUG-90035
Change-Id: Ief5fc536435e5c183dc987462d89311dfa429970
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
| |
[ChangeLog] Enable hangout services extension and implement its
WebRTC desktop capture extension API dependency.
Fixes: QTBUG-85731
Task-number: QTBUG-51185
Task-number: QTBUG-61676
Change-Id: I7a659c2b0039243ac8d8c58685716ffc55265e3b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
| |
Change-Id: Ic4ffd98e02f986dbaf986405360e727c813e696e
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
| |
Change-Id: I33c1af7c431055d95e0fb540246765cce684de15
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
| |
Change-Id: I359805d0bea84147fca6de2e2c7b17b4dcb17bc7
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
| |
Change-Id: I63ed851426b18623d549ceaf87f1b6eeec527966
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
| |
Change-Id: Ie422b327025da084bc8038c7a0aadee2db801f29
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
| |
We need to be able to recognize generated resources as well.
Task-number: QTBUG-84340
Change-Id: Ib0a783a681c349c05972c0c67e2f0cf20d1c99c4
Reviewed-by: Szabolcs David <davidsz@inf.u-szeged.hu>
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
|
|
|
| |
We don't add any extension API beyond the core ones and are just
duplicating what CoreExtensionsBrowserAPIProvider does.
Change-Id: Ia50f89e7e23dc0e155f8f2e01b4f7f1e262cbe53
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
| |
Change-Id: Icaf68648cbc2c13a61fc3b208ff1e64ca36c90b6
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
Including removal of renderer service.
[ChangeLog][QWebEngineSetting] XSS Auditing has been removed, and
XSSAuditingEnabled no longer has any effect.
Change-Id: I0835e2a76551057f3eea30a343e0373b642192f0
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
|
|
|
|
|
|
|
|
| |
Extension resources are now loaded through ExtensionsBrowserClientQt's
LoadResourceFromResourceBundle, and permission to load extra schemes
is now handled by installing subresource URL loaders.
Change-Id: Id0445088607c9be019fbfc134db4e60b94e54479
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
With IsHandledURL() implemented extensions were blocked from loading
resources, becauset their rights were not correctly granted by the
extension webcontents observer, which failed beause we were using
process-per-site instead of site-per-process.
Change-Id: Iee9b97fda39b4307a9cb4f63f11cbdef0bcc2660
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
|
|
| |
Picking suggested changes for a clang-format run.
Change-Id: I1a803b0c0bbf305b3e0861fa42b47ee404b4b255
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix all warnings save for -Wdeprecated-declarations in tests.
Warnings from GCC 9.2.0:
src/core/renderer/extensions/resource_request_policy_qt.cpp:157:23:
warning: variable 'resource_root_relative_path' set but not used
[-Wunused-but-set-variable]
src/core/chromium_overrides.cpp:121:21:
warning: moving a local object in a return statement prevents copy elision
[-Wpessimizing-move]
src/core/render_widget_host_view_qt.cpp:540:12:
warning: enumeration value 'kNull' not handled in switch [-Wswitch]
warning: enumeration value 'kMiddlePanningVertical' not handled in switch
[-Wswitch]
warning: enumeration value 'kMiddlePanningHorizontal' not handled in switch
[-Wswitch]
warning: enumeration value 'kDndNone' not handled in switch [-Wswitch]
warning: enumeration value 'kDndMove' not handled in switch [-Wswitch]
warning: enumeration value 'kDndCopy' not handled in switch [-Wswitch]
warning: enumeration value 'kDndLink' not handled in switch [-Wswitch]
warning: enumeration value 'kMaxValue' not handled in switch [-Wswitch]
src/core/type_conversion.cpp:57:12:
warning: enumeration value ‘kRGBA_F16Norm_SkColorType’ not handled in switch
[-Wswitch]
src/core/api/qtbug-60565.cpp:83:6:
warning: 'void __ShimCppDeleteArrayNoThrow(void*, const std::nothrow_t&)'
alias between functions of incompatible types 'void(void*, const
std::nothrow_t&) noexcept' and 'void(void*)' [-Wattribute-alias=]
src/core/api/qtbug-60565.cpp:79:6:
warning: 'void __ShimCppDeleteNoThrow(void*, const std::nothrow_t&)' alias
between functions of incompatible types 'void(void*, const std::nothrow_t&)
noexcept' and 'void(void*)' [-Wattribute-alias=]
src/core/api/qtbug-60565.cpp:75:6:
warning: 'void __ShimCppNewArrayNoThrow(size_t, const std::nothrow_t&)'
alias between functions of incompatible types 'void(size_t, const
std::nothrow_t&) noexcept' {aka 'void(long unsigned int, const
std::nothrow_t&) noexcept'} and 'void*(size_t)' {aka 'void*(long unsigned
int)'} [-Wattribute-alias=]
src/core/api/qtbug-60565.cpp:71:6:
warning: 'void __ShimCppNewNoThrow(size_t, const std::nothrow_t&)' alias
between functions of incompatible types 'void(size_t, const std::nothrow_t&)
noexcept' {aka 'void(long unsigned int, const std::nothrow_t&) noexcept'}
and 'void*(size_t)' {aka 'void*(long unsigned int)'} [-Wattribute-alias=]
Warnings from Clang 9.0.1:
src/core/renderer/extensions/renderer_permissions_policy_delegate_qt.h:61:29:
warning: private field 'm_dispatcher' is not used [-Wunused-private-field]
src/core/web_event_factory.cpp:1296:5:
warning: unannotated fall-through between switch labels
[-Wimplicit-fallthrough]
src/core/compositor/compositor_resource_fence.h:55:81:
warning: extra ';' after member function definition [-Wextra-semi]
src/core/renderer/render_frame_observer_qt.h:81:10:
warning: 'ReadyToCommitNavigation' overrides a member function but is not
marked 'override' [-Winconsistent-missing-override]
src/core/extensions/mime_handler_view_guest_delegate_qt.h:69:27:
warning: private field 'guest_' is not used [-Wunused-private-field]
src/core/chromium_overrides.cpp:121:12:
warning: moving a local object in a return statement prevents copy elision
[-Wpessimizing-move]
src/core/chromium_overrides.cpp:145:64:
warning: missing field 'set_up_command_line' initializer
[-Wmissing-field-initializers]
src/core/chromium_overrides.cpp:146:55:
warning: missing field 'set_up_command_line' initializer
[-Wmissing-field-initializers]
src/core/render_widget_host_view_qt.cpp:540:13:
warning: 7 enumeration values not handled in switch: 'kNull',
'kMiddlePanningVertical', 'kMiddlePanningHorizontal'... [-Wswitch]
src/core/compositor/stream_video_node.cpp:50:18:
warning: 'updateState' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
src/core/compositor/stream_video_node.cpp:103:18:
warning: 'initialize' overrides a member function but is not marked
'override' [-Winconsistent-missing-override]
src/core/type_conversion.cpp:57:13:
warning: enumeration value 'kRGBA_F16Norm_SkColorType' not handled in
switch [-Wswitch]
src/core/renderer_host/web_channel_ipc_transport_host.cpp:59:60:
warning: extra ';' outside of a function is incompatible with C++98
[-Wc++98-compat-extra-semi]
tests/auto/widgets/loadsignals/tst_loadsignals.cpp:237:10:
warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
tests/auto/widgets/qwebenginedownloaditem/tst_qwebenginedownloaditem.cpp:1112:62:
warning: lambda capture 'item' is not used [-Wunused-lambda-capture]
tests/auto/widgets/qwebengineview/tst_qwebengineview.cpp:1534:55:
warning: lambda capture 'this' is not used [-Wunused-lambda-capture]
Change-Id: I374be0d4e58accc0a00a2596a560dd6103a98994
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
Reviewed-by: Michael Brüning <michael.bruning@qt.io>
|
|
|
|
|
|
| |
Fixes: QTBUG-77267
Change-Id: I181e24cf80ebee6991b95dde6c636f0d169b40a4
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
| |
Change-Id: Id6d18a3854b572334dc1d65f1916b8991a740cd2
Reviewed-by: Jüri Valdmann <juri.valdmann@qt.io>
|
|
|
|
|
| |
Change-Id: Idad08244e0c749a9f70f5eb9f8cd236039b941b3
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
| |
Change-Id: Icdefa05eec39c632328dfc40862e5b734170bf3f
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
|
|
| |
Change-Id: I565d1e327852110a5abebed3388d7cd6986bef06
Reviewed-by: Michal Klocek <michal.klocek@qt.io>
|
|
Adds the Chromium extensiuon system to Qt WebEngine.
Currently, it only exposes internal APIs to the internal
PDF viewer extension.
To load a PDF, simply navigate to it.
This feature can be configured via the webengine-extensions flag
and is turned on by default.
Needs patch in Chromium 71-based to build.
Adaptations to 71-based from 69-based include:
* Flag out update installation, add crx file dependency
* Move PostTask over to 71-based implementation
* Move extensions API providers to 71-based implementaion
* Don't use custom guest view and mime handler view delegates
* Adapt the URLRequestResourceBundleJob to match new interface
* Move extension system initialization to end of profile constructor
Change-Id: I4fa5149057291bb5847f048534c11820cd7ff58c
Fixes: QTBUG-50556
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|