| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
| |
Fixes: QTBUG-77267
Change-Id: I181e24cf80ebee6991b95dde6c636f0d169b40a4
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ignore on-disk values of spellCheckEnabled and spellCheckLanguages prefs to
preserve backwards compatibility. Fixes deterministic failure in second run of
tst_spellchecking because the first run disabled spellchecking.
Put all settings-related tests in tst_spellchecking into one test and pretend to
check that settings are not persisted. Since settings are currently read and
written on independent task sequences without guaranteed ordering, the test
would succeed even if settings were persisted. Specifically, in code like this
profile = new QWebEngineProfile("MyProf"); // 1
delete profile; // 2
profile = new QWebEngineProfile("MyProf"); // 3
the write from line 2 will usually happen after the read from line 3. Once
persistence becomes a public feature we probably should add some way to
guarantee the proper ordering of reads and writes.
Change-Id: Icb2290417049848dbe68b7f991bbe2d52756f295
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
| |
|
|
|
| |
Change-Id: Idad08244e0c749a9f70f5eb9f8cd236039b941b3
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
| |
|
|
|
| |
Change-Id: Icdefa05eec39c632328dfc40862e5b734170bf3f
Reviewed-by: Peter Varga <pvarga@inf.u-szeged.hu>
|
|
|
We can now persist the user preferences to disk at application exit so
they are correctly remembered for the next run. The preferences are
stored in dataPath()/user_prefs.json. This is managed via the
PrefServiceAdapter class.
It's not possible to test this in a correct pattern as we require the
app to exit properly to be able to guarantee that the preferences are
written to disk. The code added in ~PrefServiceAdapter() does not
provide any guarantees in the next profile construction that the
previous preferences have been written to disk.
Fixes: QTBUG-75740
Change-Id: I96bb3037707d90b05b3dfab4f083702351923aee
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
|
